Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.0] [IMP] dms: Attachment Integration #37

Merged
merged 2 commits into from
Nov 13, 2020

Conversation

victoralmau
Copy link
Member

@victoralmau victoralmau commented Nov 6, 2020

Attachment integration (V13) related to #24 (V12)
Cherry pick #24 and new commit related to V13 changes.

Please @pedrobaeza, @etobella, @ernestotejeda review it

@Tecnativa TT26661

@victoralmau victoralmau force-pushed the 13.0-imp-dms-attachment-integration branch 3 times, most recently from da4bbaa to b30698d Compare November 6, 2020 09:54
@victoralmau
Copy link
Member Author

Appear error in test related to lines added in test_file_migrate (error appear in admin user).

Any idea about it? I will keep on investigate about it.

@rvalyi
Copy link
Member

rvalyi commented Nov 6, 2020

Hello, I like this attachment integration. I take the opportunity to ask here: do you plan some kind of sftp or webdav integration? Do you have any hint for how to do it properly? Old Odoo versions had this but scalability and security issues. Are you optimistic it could be done properly?

@pedrobaeza
Copy link
Member

@rvalyi I don't really see the relation of this with SFTP/Webdav. This is only allowing to auto-create DMS files/directories from attachments in records. For what you want, I think it should be handled through adding storage options for attachments theirselves. Other way is to create new DMS storages, but that's for storing documents, not attachments.

@rvalyi
Copy link
Member

rvalyi commented Nov 6, 2020

Yeah of course I see this PR is not for what I was asking for, just took the opportunity to ask your view on it while developers likely to know could give orientation. Thanks for answering.

@pedrobaeza
Copy link
Member

Next time, open an independent issue instead. Does your doubt get answered?

@rvalyi
Copy link
Member

rvalyi commented Nov 6, 2020

yes thanks we may try it in the future.

@victoralmau victoralmau force-pushed the 13.0-imp-dms-attachment-integration branch 3 times, most recently from 2b32f45 to 7fbf562 Compare November 9, 2020 07:49
@Rad0van
Copy link

Rad0van commented Nov 9, 2020

Hello, I like this attachment integration. I take the opportunity to ask here: do you plan some kind of sftp or webdav integration? Do you have any hint for how to do it properly? Old Odoo versions had this but scalability and security issues. Are you optimistic it could be done properly?

@rvalyi I have WebDAV in my (very long) queue of ToDo things as I'd like to allow user edit attachments/documents without the need to download/edit/upload. However that would be a quite a big undertaking for me but I am willing to try...

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash your 2 migration commits into one

@pedrobaeza pedrobaeza added this to the 13.0 milestone Nov 10, 2020
@victoralmau victoralmau force-pushed the 13.0-imp-dms-attachment-integration branch from 7fbf562 to ce3fdb8 Compare November 10, 2020 09:20
@pedrobaeza
Copy link
Member

Let's merge finally this:

/ocabot merge major

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 13.0-ocabot-merge-pr-37-by-pedrobaeza-bump-major, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 595dbde into OCA:13.0 Nov 13, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at f3c2c78. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 13.0-imp-dms-attachment-integration branch August 8, 2023 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants