-
-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[13.0] [IMP] dms: Attachment Integration #37
[13.0] [IMP] dms: Attachment Integration #37
Conversation
da4bbaa
to
b30698d
Compare
Appear error in test related to lines added in Any idea about it? I will keep on investigate about it. |
Hello, I like this attachment integration. I take the opportunity to ask here: do you plan some kind of sftp or webdav integration? Do you have any hint for how to do it properly? Old Odoo versions had this but scalability and security issues. Are you optimistic it could be done properly? |
@rvalyi I don't really see the relation of this with SFTP/Webdav. This is only allowing to auto-create DMS files/directories from attachments in records. For what you want, I think it should be handled through adding storage options for attachments theirselves. Other way is to create new DMS storages, but that's for storing documents, not attachments. |
Yeah of course I see this PR is not for what I was asking for, just took the opportunity to ask your view on it while developers likely to know could give orientation. Thanks for answering. |
Next time, open an independent issue instead. Does your doubt get answered? |
yes thanks we may try it in the future. |
2b32f45
to
7fbf562
Compare
@rvalyi I have WebDAV in my (very long) queue of ToDo things as I'd like to allow user edit attachments/documents without the need to download/edit/upload. However that would be a quite a big undertaking for me but I am willing to try... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please squash your 2 migration commits into one
[IMP] dms: Attachment integration
7fbf562
to
ce3fdb8
Compare
Let's merge finally this: /ocabot merge major |
This PR looks fantastic, let's merge it! |
Congratulations, your PR was merged at f3c2c78. Thanks a lot for contributing to OCA. ❤️ |
Attachment integration (V13) related to #24 (V12)
Cherry pick #24 and new commit related to V13 changes.
Please @pedrobaeza, @etobella, @ernestotejeda review it
@Tecnativa TT26661