[13.0][MIG] account_invoice_ubl #156

astirpe · 2019-12-13T12:19:42Z

Depends on:

account_e-invoice_generate [13.0][MIG] account_e-invoice_generate #146
base_ubl_payment [13.0][MIG] base_ubl_payment #155
account_tax_unece [13.0][MIG] account_tax_unece community-data-files#74
account_payment_partner [MIG] account_payment_partner: Migration to 13.0 bank-payment#649

CasVissers-360ERP

👍 Functional review.

CasVissers-360ERP · 2019-12-17T11:24:24Z

@astirpe
Sorry did find something after-all :( When printing invoices (PDF) I get an empty PDF file.

If I comment this line: pdf_content = invoice.embed_ubl_xml_in_pdf(pdf_content)
The PDF starts working again..

astirpe · 2019-12-24T09:58:40Z

@CasVissers the empty PDF should be now fixed by fdaaab3 on module base_ubl (#154). Could you check?

CasVissers-360ERP · 2019-12-30T07:27:20Z

@astirpe Yes I can confirm it works now.

Print numbers with the approriate number of digits in the XML

Add support for partner bank matching on invoice update (before, it was only supported on invoice creation)

Rename __openerp__.py to __manifest__.py and set installable to False

Also port all the modules that generate the XML documents: account_invoice_ubl, account_invoice_zugferd, purchase_order_ubl and sale_order_ubl

Rename account_invoice_import_zugferd to account_invoice_import_factur-x Add module to support py3o reporting engine:

Add active buttons on invoice import config

… module Fix spelling mistake and other remarks on README by Tarteo

Add ubl invoice generation option in accounting config page

…xist in v10) in account_invoice_factur-x and account_invoice_ubl

Add script mass_invoice_import.py Code cleanup

* sale_order_ubl + purchase_order_ubl: restore get_pdf() in tests using HttpCase * Restore get_pdf() in tests of account_invoice_factur-x and account_invoice_ubl modules * Update oca_dependencies.txt

… embedding in PDF between account_invoice_factur-x and account_invoice_ubl

Enable delivery block in UBL

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: edi-12.0/edi-12.0-account_invoice_ubl Translate-URL: https://translation.odoo-community.org/projects/edi-12-0/edi-12-0-account_invoice_ubl/

Currently translated at 81.8% (9 of 11 strings) Translation: edi-12.0/edi-12.0-account_invoice_ubl Translate-URL: https://translation.odoo-community.org/projects/edi-12-0/edi-12-0-account_invoice_ubl/hr/

Currently translated at 90.9% (10 of 11 strings) Translation: edi-12.0/edi-12.0-account_invoice_ubl Translate-URL: https://translation.odoo-community.org/projects/edi-12-0/edi-12-0-account_invoice_ubl/hr/

aisopuro · 2020-04-27T08:17:24Z

This seems to have been sitting still with green lights for a while. @CasVissers do you know of any other maintainers of this repo who could take a look at this so it could be merged?

CasVissers-360ERP · 2020-05-07T09:57:45Z

@alexis-via

jgrandguillaume

LGTM thanks

OCA-git-bot · 2020-05-13T08:50:59Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

alexis-via · 2020-05-28T12:26:37Z

I found 2 bugs in this PR:

it generates UBL XML even when invoice.company_id.xml_format_in_pdf_invoice == facturx !
the button to generate UBL XML on invoice is shown in draft state, but it crashes
I'll fix it in my PR to port Factur-X to v13.

CasVissers-360ERP · 2020-06-24T07:59:42Z

@alexis-via

I found 2 bugs in this PR:

it generates UBL XML even when invoice.company_id.xml_format_in_pdf_invoice == facturx !

the button to generate UBL XML on invoice is shown in draft state, but it crashes
I'll fix it in my PR to port Factur-X to v13.

Did you fix point 2 somewhere I can check?

OCA-git-bot mentioned this pull request Dec 13, 2019

Migration to version 13.0 #133

Closed

11 tasks

CasVissers-360ERP approved these changes Dec 17, 2019

View reviewed changes

astirpe force-pushed the 13_mig_account_invoice_ubl branch from 0a1ca8e to e91b3e6 Compare December 17, 2019 14:53

astirpe force-pushed the 13_mig_account_invoice_ubl branch from e91b3e6 to 92f9f5d Compare March 3, 2020 12:31

alexis-via and others added 23 commits March 26, 2020 11:26

Add modules account_invoice_ubl + base_ubl_payment

f591552

Add partner identification hook in UBL XML party block generation

06804d5

Print numbers with the approriate number of digits in the XML

Add support for UBL 2.0 (required for e-fff)

3782e68

Update README

7aa084b

Handle lang in UBL XML file generation

08efee4

8.0 Add support for partner bank matching on invoice update (OCA#6)

5c420e0

Add support for partner bank matching on invoice update (before, it was only supported on invoice creation)

OCA Transbot updated translations from Transifex

8d39c95

Prepare v10 branch

eed01f5

Rename __openerp__.py to __manifest__.py and set installable to False

Port base_business_document_import* to v10

7cf716c

Also port all the modules that generate the XML documents: account_invoice_ubl, account_invoice_zugferd, purchase_order_ubl and sale_order_ubl

Rename account_invoice_zugferd to account_invoice_factur-x

fedb213

Rename account_invoice_import_zugferd to account_invoice_import_factur-x Add module to support py3o reporting engine:

FIX crash on self._model

0a93bac

Add active buttons on invoice import config

Continue port of modules for v10.0, in particular sale_order_import_*…

dc7358d

… module Fix spelling mistake and other remarks on README by Tarteo

Port purchase_order_import* to v10.0

d2132e4

Add ubl invoice generation option in accounting config page

Stop using precision_get('Account') (this decimal precision doesn't e…

f992d2e

…xist in v10) in account_invoice_factur-x and account_invoice_ubl

Update test suite

e12caf3

Improve + modularize generation of UBL (up-port from v8 PR)

2a24d45

Add script mass_invoice_import.py Code cleanup

Disable get_pdf() in all tests because it doesn't work in Travis

3d28d52

[10.0] restore get_pdf() in tests (OCA#31)

35e8b42

* sale_order_ubl + purchase_order_ubl: restore get_pdf() in tests using HttpCase * Restore get_pdf() in tests of account_invoice_factur-x and account_invoice_ubl modules * Update oca_dependencies.txt

Add module account_e-invoice_generate to ensure compatibility for XML…

52398ba

… embedding in PDF between account_invoice_factur-x and account_invoice_ubl

[11.0][MIG] account_invoice_ubl

50201aa

OCA Transbot updated translations from Transifex

3f58220

Add support for PaymentID in UBL

bad2d46

Enable delivery block in UBL

FIX is partner_shipping_id is empty

5053c12

oca-travis and others added 15 commits March 26, 2020 11:26

[UPD] Update account_invoice_ubl.pot

5630554

[UPD] README.rst

f6cda15

[12.0][MIG] account_invoice_ubl

d3b58ce

[UPD] README.rst

ffe111d

[ADD] icon.png

b15f434

[UPD] Update account_invoice_ubl.pot

d2a6885

[FIX] Related field not readonly

d321562

Update translation files

fe38131

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: edi-12.0/edi-12.0-account_invoice_ubl Translate-URL: https://translation.odoo-community.org/projects/edi-12-0/edi-12-0-account_invoice_ubl/

[UPD] README.rst

4e9a575

Added translation using Weblate (Croatian)

bfa5726

Translated using Weblate (Croatian)

1a0328f

Currently translated at 81.8% (9 of 11 strings) Translation: edi-12.0/edi-12.0-account_invoice_ubl Translate-URL: https://translation.odoo-community.org/projects/edi-12-0/edi-12-0-account_invoice_ubl/hr/

Translated using Weblate (Croatian)

13959a2

Currently translated at 90.9% (10 of 11 strings) Translation: edi-12.0/edi-12.0-account_invoice_ubl Translate-URL: https://translation.odoo-community.org/projects/edi-12-0/edi-12-0-account_invoice_ubl/hr/

[13.0][MIG] account_invoice_ubl

f5f7d00

pre-commit

5facfaf

Add coverage

d780e40

astirpe force-pushed the 13_mig_account_invoice_ubl branch from 92f9f5d to d780e40 Compare March 26, 2020 10:29

jgrandguillaume approved these changes May 13, 2020

View reviewed changes

OCA-git-bot added approved ready to merge labels May 13, 2020

alexis-via merged commit 55a4c96 into OCA:13.0 May 13, 2020

astirpe deleted the 13_mig_account_invoice_ubl branch May 14, 2020 06:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[13.0][MIG] account_invoice_ubl #156

[13.0][MIG] account_invoice_ubl #156

astirpe commented Dec 13, 2019 •

edited

Loading

CasVissers-360ERP left a comment

CasVissers-360ERP commented Dec 17, 2019

astirpe commented Dec 24, 2019

CasVissers-360ERP commented Dec 30, 2019

aisopuro commented Apr 27, 2020

CasVissers-360ERP commented May 7, 2020

jgrandguillaume left a comment

OCA-git-bot commented May 13, 2020

alexis-via commented May 28, 2020

CasVissers-360ERP commented Jun 24, 2020

[13.0][MIG] account_invoice_ubl #156

[13.0][MIG] account_invoice_ubl #156

Conversation

astirpe commented Dec 13, 2019 • edited Loading

CasVissers-360ERP left a comment

Choose a reason for hiding this comment

CasVissers-360ERP commented Dec 17, 2019

astirpe commented Dec 24, 2019

CasVissers-360ERP commented Dec 30, 2019

aisopuro commented Apr 27, 2020

CasVissers-360ERP commented May 7, 2020

jgrandguillaume left a comment

Choose a reason for hiding this comment

OCA-git-bot commented May 13, 2020

alexis-via commented May 28, 2020

CasVissers-360ERP commented Jun 24, 2020

astirpe commented Dec 13, 2019 •

edited

Loading