Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[13.0][MIG] account_invoice_ubl #156

Merged
merged 38 commits into from
May 13, 2020
Merged

[13.0][MIG] account_invoice_ubl #156

merged 38 commits into from
May 13, 2020

Conversation

astirpe
Copy link
Member

@astirpe astirpe commented Dec 13, 2019 •
edited
Loading

@OCA-git-bot OCA-git-bot mentioned this pull request Dec 13, 2019
Closed
11 tasks
CasVissers-360ERP
CasVissers-360ERP approved these changes Dec 17, 2019
View reviewed changes
Copy link

@CasVissers-360ERP CasVissers-360ERP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Functional review.
image

@CasVissers-360ERP
Copy link

@astirpe
Sorry did find something after-all :( When printing invoices (PDF) I get an empty PDF file.

If I comment this line: pdf_content = invoice.embed_ubl_xml_in_pdf(pdf_content)
The PDF starts working again..

@astirpe
Copy link
Member Author

astirpe commented Dec 24, 2019

@CasVissers the empty PDF should be now fixed by fdaaab3 on module base_ubl (#154). Could you check?

@CasVissers-360ERP
Copy link

@astirpe Yes I can confirm it works now.

@astirpe astirpe force-pushed the 13_mig_account_invoice_ubl branch from e91b3e6 to 92f9f5d Compare March 3, 2020 12:31
alexis-via and others added 23 commits March 26, 2020 11:26
@alexis-via @astirpe
Add modules account_invoice_ubl + base_ubl_payment
f591552
@alexis-via @astirpe
Add partner identification hook in UBL XML party block generation
06804d5 
Print numbers with the approriate number of digits in the XML
@alexis-via @astirpe
Add support for UBL 2.0 (required for e-fff)
3782e68
@alexis-via @astirpe
Update README
7aa084b
@alexis-via @astirpe
Handle lang in UBL XML file generation
08efee4
@astirpe
8.0 Add support for partner bank matching on invoice update (OCA#6)
5c420e0 
Add support for partner bank matching on invoice update (before, it was only supported on invoice creation)
@oca-transbot @astirpe
OCA Transbot updated translations from Transifex
8d39c95
@alexis-via @astirpe
Prepare v10 branch
eed01f5 
Rename __openerp__.py to __manifest__.py and set installable to False
@alexis-via @astirpe
Port base_business_document_import* to v10
7cf716c 
Also port all the modules that generate the XML documents: account_invoice_ubl, account_invoice_zugferd, purchase_order_ubl and sale_order_ubl
@alexis-via @astirpe
Rename account_invoice_zugferd to account_invoice_factur-x
fedb213 
Rename account_invoice_import_zugferd to account_invoice_import_factur-x
Add module to support py3o reporting engine:
@alexis-via @astirpe
FIX crash on self._model
0a93bac 
Add active buttons on invoice import config
@alexis-via @astirpe
Continue port of modules for v10.0, in particular sale_order_import_*…
dc7358d 
… module

Fix spelling mistake and other remarks on README by Tarteo
@alexis-via @astirpe
Port purchase_order_import* to v10.0
d2132e4 
Add ubl invoice generation option in accounting config page
@alexis-via @astirpe
Stop using precision_get('Account') (this decimal precision doesn't e…
f992d2e 
…xist in v10) in account_invoice_factur-x and account_invoice_ubl
@alexis-via @astirpe
Update test suite
e12caf3
@alexis-via @astirpe
Improve + modularize generation of UBL (up-port from v8 PR)
2a24d45 
Add script mass_invoice_import.py
Code cleanup
@alexis-via @astirpe
Disable get_pdf() in all tests because it doesn't work in Travis
3d28d52
@astirpe
[10.0] restore get_pdf() in tests (OCA#31)
35e8b42 
* sale_order_ubl + purchase_order_ubl: restore get_pdf() in tests using HttpCase

* Restore get_pdf() in tests of account_invoice_factur-x and account_invoice_ubl modules

* Update oca_dependencies.txt
@alexis-via @astirpe
Add module account_e-invoice_generate to ensure compatibility for XML…
52398ba 
… embedding in PDF between account_invoice_factur-x and account_invoice_ubl
@astirpe
[11.0][MIG] account_invoice_ubl
50201aa
@oca-transbot @astirpe
OCA Transbot updated translations from Transifex
3f58220
@alexis-via @astirpe
Add support for PaymentID in UBL
bad2d46 
Enable delivery block in UBL
@alexis-via @astirpe
FIX is partner_shipping_id is empty
5053c12
oca-travis and others added 15 commits March 26, 2020 11:26
@oca-travis @astirpe
[UPD] Update account_invoice_ubl.pot
5630554
@OCA-git-bot @astirpe
[UPD] README.rst
f6cda15
@astirpe
[12.0][MIG] account_invoice_ubl
d3b58ce
@OCA-git-bot @astirpe
[UPD] README.rst
ffe111d
@OCA-git-bot @astirpe
[ADD] icon.png
b15f434
@oca-travis @astirpe
[UPD] Update account_invoice_ubl.pot
d2a6885
@astirpe
[FIX] Related field not readonly
d321562
@oca-transbot @astirpe
Update translation files
fe38131 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: edi-12.0/edi-12.0-account_invoice_ubl
Translate-URL: https://translation.odoo-community.org/projects/edi-12-0/edi-12-0-account_invoice_ubl/
@OCA-git-bot @astirpe
[UPD] README.rst
4e9a575
@badbole @astirpe
Added translation using Weblate (Croatian)
bfa5726
@badbole @astirpe
Translated using Weblate (Croatian)
1a0328f 
Currently translated at 81.8% (9 of 11 strings)

Translation: edi-12.0/edi-12.0-account_invoice_ubl
Translate-URL: https://translation.odoo-community.org/projects/edi-12-0/edi-12-0-account_invoice_ubl/hr/
@badbole @astirpe
Translated using Weblate (Croatian)
13959a2 
Currently translated at 90.9% (10 of 11 strings)

Translation: edi-12.0/edi-12.0-account_invoice_ubl
Translate-URL: https://translation.odoo-community.org/projects/edi-12-0/edi-12-0-account_invoice_ubl/hr/
@astirpe
[13.0][MIG] account_invoice_ubl
f5f7d00
@astirpe
pre-commit
5facfaf
@astirpe
Add coverage
d780e40
@aisopuro
Copy link

This seems to have been sitting still with green lights for a while. @CasVissers do you know of any other maintainers of this repo who could take a look at this so it could be merged?

@CasVissers-360ERP
Copy link

@alexis-via

jgrandguillaume
jgrandguillaume approved these changes May 13, 2020
View reviewed changes
Copy link
Member

@jgrandguillaume jgrandguillaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@alexis-via alexis-via merged commit 55a4c96 into OCA:13.0 May 13, 2020
@astirpe astirpe deleted the 13_mig_account_invoice_ubl branch May 14, 2020 06:07
@alexis-via
Copy link
Contributor

I found 2 bugs in this PR:

  1. it generates UBL XML even when invoice.company_id.xml_format_in_pdf_invoice == facturx !
  2. the button to generate UBL XML on invoice is shown in draft state, but it crashes
    I'll fix it in my PR to port Factur-X to v13.

@CasVissers-360ERP
Copy link

@alexis-via

I found 2 bugs in this PR:

  1. it generates UBL XML even when invoice.company_id.xml_format_in_pdf_invoice == facturx !
  2. the button to generate UBL XML on invoice is shown in draft state, but it crashes
    I'll fix it in my PR to port Factur-X to v13.

Did you fix point 2 somewhere I can check?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CasVissers-360ERP CasVissers-360ERP CasVissers-360ERP approved these changes

@jgrandguillaume jgrandguillaume jgrandguillaume approved these changes

Assignees
No one assigned
Labels
approved ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@astirpe @CasVissers-360ERP @aisopuro @OCA-git-bot @alexis-via @jgrandguillaume @oca-transbot @oca-travis @badbole