Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.0][MIG] base_ubl #154

Merged
merged 27 commits into from
Mar 3, 2020
Merged

[13.0][MIG] base_ubl #154

merged 27 commits into from
Mar 3, 2020

Conversation

astirpe
Copy link
Member

@astirpe astirpe commented Dec 13, 2019

@OCA-git-bot OCA-git-bot mentioned this pull request Dec 13, 2019
11 tasks
@CasVissers-360ERP
Copy link

@astirpe
Also depends on base_vat_sanitized not yet available for v13

@astirpe
Copy link
Member Author

astirpe commented Dec 17, 2019

@CasVissers to speed up the approval, you may want to review this: OCA/partner-contact#821
I will fix the dependencies in this PR once one on the two unece modules is merged.

Copy link

@CasVissers-360ERP CasVissers-360ERP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM, functional test

@pedrobaeza pedrobaeza added this to the 13.0 milestone Dec 17, 2019
@astirpe astirpe force-pushed the 13_mig_base_ubl branch 3 times, most recently from 2aa9616 to bbe5e43 Compare December 19, 2019 09:45
@astirpe astirpe mentioned this pull request Dec 24, 2019
4 tasks
Copy link

@CasVissers-360ERP CasVissers-360ERP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and confirmed 👍

alexis-via and others added 16 commits February 28, 2020 08:31
Adapt module account_invoice_import_ubl to use the new base_ubl module
Small fixes

Parse customer/supplier ref in UBL and allow to match partner on 'ref'

Better generation of address block in UBL (make it coherent with the datamodel of Odoo)
Add generation of several UBL blocks: language, delivery, payment terms, customer party, spplier party
Add parsing of zip in UBL party (will be used in the future for delivery partner match)

Add matching of delivery partner

Use country code and state code to match partners
UBL: Add delivery terms and line item UBL XML block generation
UBL: add parsing of delivery block

Add module base_phone_business_document_import

Add unitests in base_business_document_import
Small code enhancements/simplifications

Add module base_business_document_import_stock

Rename key 'quantity' to 'qty' in all parsing dicts['lines']
Add common methods compare_lines() and post_create_or_update()
Make sure price_unit is always untaxed in UBL XML files

Update invoice lines on "Update Existing" invoice import

Add button "Update from File" on supplier invoice form
Use float_round() instead of round()

Add UBL 2.1 XSD files (can be used by all UBL modules ; avoids duplication of UBL XSD files)

Use StreetName/AdditionalStreetName instead of AddressLine blocks, because only the first one is accepted by Chorus Factures for example.

Update UBL methods to generate lines

Add UBL methods to generate some tax blocks

Add partner identification hook in UBL XML party block generation

Print numbers with the approriate number of digits in the XML

Use vat_sanitiezd in base_ubl

Add support for UBL 2.0 (required for e-fff)
PEP8 fix

8.0 Add support for partner bank matching on invoice update (OCA#6)

Add support for partner bank matching on invoice update (before, it was only supported on invoice creation)

8.0 Use try/except when importing external libs (OCA#8)

[FIX] LINT

Use try/except when importing external libs
Remove self.ensure_one() that has nothing to do in an api.model method
Rename __openerp__.py to __manifest__.py and set installable to False

Port base_business_document_import* to v10

Also port all the modules that generate the XML documents: account_invoice_ubl, account_invoice_zugferd, purchase_order_ubl and sale_order_ubl

Rename account_invoice_zugferd to account_invoice_factur-x

Rename account_invoice_import_zugferd to account_invoice_import_factur-x
Add module to support py3o reporting engine:

Add support for allowance and charges on Factur-X invoice import

To avoid headaches with invalid files, now check XSD of XML invoices before parsing it upon import
Move Factur-X/zugferd xsd to base_zugferd

Improve + modularize generation of UBL (up-port from v8 PR)

Add script mass_invoice_import.py
Code cleanup

FIX tax amount in UBL
Enable delivery block in UBL
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: edi-12.0/edi-12.0-base_ubl
Translate-URL: https://translation.odoo-community.org/projects/edi-12-0/edi-12-0-base_ubl/
Currently translated at 87.5% (7 of 8 strings)

Translation: edi-12.0/edi-12.0-base_ubl
Translate-URL: https://translation.odoo-community.org/projects/edi-12-0/edi-12-0-base_ubl/hr/
… to write to is not in binary mode. It may not be written to correctly. [pdf.py:453] (OCA#56)
Copy link
Contributor

@alexis-via alexis-via left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to remove the dependency on base_vat_sanitized because this feature is now native in base_vat in v13.

@astirpe
Copy link
Member Author

astirpe commented Mar 3, 2020

@alexis-via done. Thanks!

@alexis-via alexis-via merged commit 83c83eb into OCA:13.0 Mar 3, 2020
@astirpe astirpe deleted the 13_mig_base_ubl branch March 3, 2020 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.