-
-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[15.0][MIG] document_page (14.0->15.0) #320
Conversation
* Add dependency to knowledge * Adding hack in document_page_history to allow calling method that don't exists * document_page_history don't have _sql attribute * Filter more fields
* Changed history widget to html. * Improved views and added followers to pages. * Updated document_page pot and es translations. * document_page:^Cissing dependency.
* [MIG] Migration to version 10.0 * [FIX] Comments and CI errors * [FIX] ValueError: External ID not found in the system: base.menu_base_partner * [FIX] ValueError: Wrong value for ir.actions.act_window.target: 'inlineview' * [FIX] Based on @lasley comments * [FIX] External ID not found in the system: base.group_document_user
continue migration
Currently translated at 51.9% (28 of 54 strings) Translation: knowledge-11.0/knowledge-11.0-document_page Translate-URL: https://translation.odoo-community.org/projects/knowledge-11-0/knowledge-11-0-document_page/fa/
Currently translated at 77.8% (42 of 54 strings) Translation: knowledge-11.0/knowledge-11.0-document_page Translate-URL: https://translation.odoo-community.org/projects/knowledge-11-0/knowledge-11-0-document_page/de/
Fixing `Page` parents.
…Add history name field, to name revisions. Modified views to allow setting this field. [document_page] FIX BUG: UI hanging when editing content. This was due to the api.depends on _compute_diff. Removing it because it's not really necessary since the field is not stored. [document_page] page_id should be readonly. Improve active field [document_page] Update version number [UPD] Update document_page.pot [MIG] document_page_multi_company (OCA#188) * [MIG] document_page_multi_company Added this feature from the old module directly in document_page
- fix references: report module is now web module - display_* fields are removed in this version
* move menus to a higher level. * fix categories search view. * fix create menu action not being accessible in any way. * reorder form view, focusing in the content, not in secondary fields.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: knowledge-12.0/knowledge-12.0-document_page Translate-URL: https://translation.odoo-community.org/projects/knowledge-12-0/knowledge-12-0-document_page/
[UPD] README.rst document_page 12.0.1.1.0 Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: knowledge-12.0/knowledge-12.0-document_page Translate-URL: https://translation.odoo-community.org/projects/knowledge-12-0/knowledge-12-0-document_page/ [UPD] README.rst
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@etobella @pedrobaeza could we merge this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review. LGTM.
@@ -27,4 +27,4 @@ def _get_diff(self): | |||
raise UserError(_("Select one or maximum two history revisions!")) | |||
return diff | |||
|
|||
diff = fields.Text(readonly=True, default=_get_diff) | |||
diff = fields.Html(readonly=True, default=_get_diff) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't you use sanitize=False like in the other parts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
/ocabot merge nobump |
What a great day to merge this nice PR. Let's do it! |
@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-320-by-dreispt-bump-nobump. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
/ocabot merge nobump |
Hey, thanks for contributing! Proceeding to merge this for you. |
@gurneyalex your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-320-by-gurneyalex-bump-nobump. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
/ocabot merge nobump |
Hey, thanks for contributing! Proceeding to merge this for you. |
Congratulations, your PR was merged at 6c4b44b. Thanks a lot for contributing to OCA. ❤️ |
/ocabot migration document_page |
No description provided.