Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][REF] l10n_br_stock_account: Adaptando o código para os casos Sem Operação Fiscal ou Multi-Localizações #3144

Merged

Conversation

mbcosta
Copy link
Contributor

@mbcosta mbcosta commented Jun 28, 2024

Adaptando o código para os casos Sem Operação Fiscal ou Multi-Localizações, PR simples basicamente:

  • chamando onchange_product_id_fiscal da stock.move apenas quando o stock.picking tiver a Operação Fiscal
  • O método default da Operação Fiscal do stock.picking retornar False quando o Pedido de Vendas ou Compras não tiver Operação Fiscal para evitar que na criação da Fatura a partir do stock.picking acabe considerando ser um caso "Com Operação Fiscal". Isso está sendo feito no l10n_br_stock_account e não no l10n_br_purchase_stock ou l10n_br_sale_stock porque até onde entendi esses métodos default para serem chamados em outros módulos precisam sobre escrever o campo e parece que deixa de chamar o método original mesmo com o super e também acabaria duplicando código, talvez exista uma forma, por enquanto o attrs parece atender
  • Nos testes removi a chamada dos onhanges _onchange_fiscal_operation_id e _onchange_fiscal_operation_line_id por já serem chamados pelo _onchange_product_id_fiscal

cc @rvalyi @renatonlima @marcelsavegnago @mileo

…Operation, if a Purchase or Sale Order are defined without it the Picking should be the same.
Copy link
Member

@rvalyi rvalyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

valeu @mbcosta !

@rvalyi
Copy link
Member

rvalyi commented Jun 29, 2024

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 14.0-ocabot-merge-pr-3144-by-rvalyi-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jun 29, 2024
Signed-off-by rvalyi
@OCA-git-bot
Copy link
Contributor

@rvalyi your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-3144-by-rvalyi-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@rvalyi
Copy link
Member

rvalyi commented Jun 29, 2024

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-3144-by-rvalyi-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jun 29, 2024
Signed-off-by rvalyi
@OCA-git-bot
Copy link
Contributor

@rvalyi your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-3144-by-rvalyi-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@rvalyi
Copy link
Member

rvalyi commented Jun 29, 2024

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-3144-by-rvalyi-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 8055ed0 into OCA:14.0 Jun 29, 2024
4 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 90e425c. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants