Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

17.0 mig l10n ec delivery note #58

Closed

Conversation

jorge-luis-dev
Copy link
Contributor

Migration of Delivery Note module

@celm1990
Copy link
Contributor

/ocabot migration l10n_ec_delivery_note

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Dec 26, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Dec 26, 2023
4 tasks
@jorge-luis-dev jorge-luis-dev force-pushed the 17.0-mig-l10n_ec_delivery_note branch from f164a0c to 719a8a5 Compare March 21, 2024 01:30
@jorge-luis-dev jorge-luis-dev force-pushed the 17.0-mig-l10n_ec_delivery_note branch from a70f4ed to af6b76e Compare April 11, 2024 00:43
@jorge-luis-dev jorge-luis-dev marked this pull request as ready for review April 11, 2024 00:44
@jorge-luis-dev jorge-luis-dev force-pushed the 17.0-mig-l10n_ec_delivery_note branch 2 times, most recently from 998ff41 to a870b10 Compare April 11, 2024 01:56
@celm1990
Copy link
Contributor

@jorge-luis-dev please rebase your branch to fixes issues relates to taxes

@jorge-luis-dev jorge-luis-dev force-pushed the 17.0-mig-l10n_ec_delivery_note branch from a870b10 to e2a43a2 Compare April 16, 2024 01:18
@jorge-luis-dev jorge-luis-dev force-pushed the 17.0-mig-l10n_ec_delivery_note branch from 722702b to 2cc2a3e Compare April 18, 2024 00:56
@sabiduriainformatica
Copy link

Dear Jose Luis

In a delivery note made from sales, the invoice field should be set with the invoice number or allow this invoice number to be selected before authorizing said guide in the SRI.

image

@franklingerman
Copy link

Dear Jose Luis
The field should be set with the invoice number or allow this invoice number to be selected before authorizing said guide in the SRI.

@celm1990
Copy link
Contributor

@jorge-luis-dev
Before the migration process, the user could fill the invoice_id field into wizard at this line


And is used here
"invoice_id": self.env.context.get("invoice_id", False),

However, in the migration process, this wizard is no longer used, so the 'invoice_id' field is never filled in the delivery note. Please review this. If the sale order has an invoice, pass this record to the delivery note.

NOTE: @sabiduriainformatica @franklingerman This depends on the invoice policy from the product's configuration. You can deliver before creating the invoice and create the invoice later, so this scenario is complicated.

NOTE 2: Picking does not have a direct relation with the invoice, so we will only try to obtain the invoice from the sale order. Other alternative is add dependency to this module https://github.com/OCA/stock-logistics-workflow/tree/17.0/stock_picking_invoice_link what do you think?

Copy link

@eduxworks eduxworks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lo he probado me parece genial tu aporte.

@jorge-luis-dev jorge-luis-dev force-pushed the 17.0-mig-l10n_ec_delivery_note branch from be33923 to f75af37 Compare June 13, 2024 01:15
Copy link
Contributor

@rvjaraj rvjaraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probado y Aprobado

Como sugerencia agregar el motivo en el modelo stock.picking

@jorge-luis-dev jorge-luis-dev force-pushed the 17.0-mig-l10n_ec_delivery_note branch from 2e87496 to 97d03d4 Compare June 14, 2024 22:31
@jorge-luis-dev jorge-luis-dev force-pushed the 17.0-mig-l10n_ec_delivery_note branch from 8ed5450 to a29fa23 Compare July 27, 2024 01:14
@jorge-luis-dev jorge-luis-dev force-pushed the 17.0-mig-l10n_ec_delivery_note branch from 0f4b044 to 4a94aea Compare August 13, 2024 01:34
@jorge-luis-dev jorge-luis-dev force-pushed the 17.0-mig-l10n_ec_delivery_note branch from 729ff26 to 5a85703 Compare August 28, 2024 23:48
@jorge-luis-dev jorge-luis-dev force-pushed the 17.0-mig-l10n_ec_delivery_note branch from a0c1ea2 to 5874d81 Compare September 11, 2024 01:53
@jorge-luis-dev jorge-luis-dev closed this by deleting the head repository Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants