Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

11.0 mig l10n nl dutch company type #211

Merged
merged 5 commits into from
Jul 21, 2020
Merged

11.0 mig l10n nl dutch company type #211

merged 5 commits into from
Jul 21, 2020

Conversation

lfreeke
Copy link
Contributor

@lfreeke lfreeke commented Nov 22, 2018

No description provided.

@hbrunn
Copy link
Member

hbrunn commented Nov 29, 2018

please fix https://travis-ci.org/OCA/l10n-netherlands/jobs/458460707#L568

this depends on partner_company_type which isn't yet migrated in v11

@hbrunn hbrunn added this to the 11.0 milestone Nov 29, 2018
@lfreeke
Copy link
Contributor Author

lfreeke commented Nov 29, 2018

@hbrunn OCA/partner-contact#660 there is a pull request for partner_company_type. Should I wait until that is merged in?

@hbrunn
Copy link
Member

hbrunn commented Nov 29, 2018

yes, we can only go further here if all dependencies are merged

@hbrunn hbrunn added requesite pending this PR depends on some other PR(s) and removed needs fixing labels Nov 29, 2018
NL66278
NL66278 requested changes Jan 21, 2019
View reviewed changes
Copy link
Contributor

@NL66278 NL66278 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

@lfreeke lfreeke force-pushed the 11.0-mig-l10n_nl_dutch_company_type branch 2 times, most recently from 23af324 to 9cc1903 Compare February 16, 2019 17:39
@lfreeke
Copy link
Contributor Author

lfreeke commented Feb 18, 2019

yes, we can only go further here if all dependencies are merged

The dependency is merged. OCA/partner-contact#660

@NL66278
Copy link
Contributor

NL66278 commented Feb 19, 2019

@hbrunn Can you remove the requisite branding label?

@hbrunn hbrunn added needs review and removed requesite pending this PR depends on some other PR(s) labels Feb 19, 2019
@lfreeke lfreeke force-pushed the 11.0-mig-l10n_nl_dutch_company_type branch from 9cc1903 to 415f615 Compare March 13, 2019 10:33
@lfreeke
Copy link
Contributor Author

lfreeke commented Mar 13, 2019

@NL66278 I resolved the comments.

@lfreeke lfreeke force-pushed the 11.0-mig-l10n_nl_dutch_company_type branch from 415f615 to 7c85e0e Compare March 13, 2019 11:39
NL66278
NL66278 approved these changes Mar 13, 2019
View reviewed changes
Copy link
Contributor

@NL66278 NL66278 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM + tested

gfcapalbo
gfcapalbo reviewed Dec 6, 2019
View reviewed changes
l10n_nl_dutch_company_type/i18n/l10n_nl_dutch_company_type.pot
#
msgid ""
msgstr ""
"Project-Id-Version: Odoo Server 10.0\n"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

11

gfcapalbo
gfcapalbo reviewed Dec 6, 2019
View reviewed changes
l10n_nl_dutch_company_type/i18n/l10n_nl_dutch_company_type.pot
#. module: l10n_nl_dutch_company_type
#: model:res.partner.company.type,name:l10n_nl_dutch_company_type.company_type_association
msgid "Association"
msgstr ""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no translation?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No translation needed here, it is the pot file, translation are in nl.po

gfcapalbo
gfcapalbo reviewed Dec 6, 2019
View reviewed changes
l10n_nl_dutch_company_type/i18n/nl.po Outdated
#
msgid ""
msgstr ""
"Project-Id-Version: Odoo Server 10.0\n"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

11

gfcapalbo
gfcapalbo suggested changes Dec 6, 2019
View reviewed changes
l10n_nl_dutch_company_type/i18n/nl.po
"Report-Msgid-Bugs-To: \n"
"POT-Creation-Date: 2018-02-01 12:56+0000\n"
"PO-Revision-Date: 2018-02-01 12:56+0000\n"
"Last-Translator: <>\n"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add name

gfcapalbo
gfcapalbo reviewed Dec 6, 2019
View reviewed changes
l10n_nl_dutch_company_type/README.rst
Installation
============

To install this module, you need to:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete or complete readme

gfcapalbo
gfcapalbo reviewed Dec 6, 2019
View reviewed changes
l10n_nl_dutch_company_type/README.rst Outdated
@@ -0,0 +1,95 @@
==========================
l10n_nl_dutch_company_type
==========================
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

real name

@lfreeke lfreeke force-pushed the 11.0-mig-l10n_nl_dutch_company_type branch from 7c85e0e to 30478df Compare December 6, 2019 11:25
@lfreeke lfreeke closed this Dec 6, 2019
@lfreeke lfreeke reopened this Dec 6, 2019
@lfreeke lfreeke closed this Feb 21, 2020
@lfreeke lfreeke reopened this Feb 21, 2020
@lfreeke
Copy link
Contributor Author

lfreeke commented Apr 2, 2020

Is there a possibility that someone can rebuild this branch? Travis is giving this error

psycopg2.OperationalError: could not connect to server: No such file or directory
Is the server running locally and accepting
connections on Unix domain socket "/var/run/postgresql/.s.PGSQL.5432"?

@NL66278
Copy link
Contributor

NL66278 commented Apr 2, 2020

@lfreeke Update (in a separate commit) .travis.yml. Use 11.0 version of partner-contact as a guideline. At least update postgres to 9.6 instead of 9.2. Also add a MAKEPOT="0" to the line under global:

@NL66278
Copy link
Contributor

NL66278 commented May 13, 2020

@lfreeke Ping

@lfreeke
Copy link
Contributor Author

lfreeke commented May 13, 2020

@NL66278 see this merge request #257 and this one #258

@lfreeke lfreeke closed this May 19, 2020
@lfreeke lfreeke reopened this May 19, 2020
@NL66278
Copy link
Contributor

NL66278 commented Jul 21, 2020

/ocabot merge major

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 11.0-ocabot-merge-pr-211-by-NL66278-bump-major, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit b7289d0 into OCA:11.0 Jul 21, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at d1c137d. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gfcapalbo gfcapalbo gfcapalbo requested changes

@NL66278 NL66278 NL66278 approved these changes

Assignees
No one assigned
Labels
merged 🎉 needs review
Projects
None yet
Milestone
11.0
Development

Successfully merging this pull request may close these issues.
7 participants
@lfreeke @hbrunn @NL66278 @OCA-git-bot @gfcapalbo @oca-travis @astirpe