-
-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[13.0][FIX] l10n_nl_bsn: search bsn with dots #268
Conversation
6e0dc16
to
0347246
Compare
0347246
to
9c5b88f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see this is a followup of #242
This PR has the |
/ocabot merge patch |
This PR looks fantastic, let's merge it! |
It looks like something changed on |
@StefanRijnhart your merge command was aborted due to failed check(s), which you can inspect on this commit of 13.0-ocabot-merge-pr-268-by-StefanRijnhart-bump-patch. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
Apparently, the nuts import attempts a live connection to a remote server which does not respond consistently
It would be better to replace this live connection with a mock passing a recorded response. |
I opened #309 for a solution with mocked tests |
/ocabot merge patch |
This PR looks fantastic, let's merge it! |
@NL66278 your merge command was aborted due to failed check(s), which you can inspect on this commit of 13.0-ocabot-merge-pr-268-by-NL66278-bump-patch. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
It is now failing on another probably unrelated error:
|
/ocabot merge patch |
What a great day to merge this nice PR. Let's do it! |
@NL66278 your merge command was aborted due to failed check(s), which you can inspect on this commit of 13.0-ocabot-merge-pr-268-by-NL66278-bump-patch. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
/ocabot merge patch |
Hey, thanks for contributing! Proceeding to merge this for you. |
Congratulations, your PR was merged at 98a187e. Thanks a lot for contributing to OCA. ❤️ |
Forward port of latest changes made on #232