Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.0][FIX] l10n_nl_bsn: search bsn with dots #268

Merged
merged 1 commit into from
Sep 22, 2021

Conversation

astirpe
Copy link
Member

@astirpe astirpe commented Jul 31, 2020

Forward port of latest changes made on #232

Copy link
Member

@StefanRijnhart StefanRijnhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see this is a followup of #242

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@StefanRijnhart
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 13.0-ocabot-merge-pr-268-by-StefanRijnhart-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Mar 1, 2021
Signed-off-by StefanRijnhart
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 13.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 13.0-ocabot-merge-pr-268-by-StefanRijnhart-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Mar 1, 2021
Signed-off-by StefanRijnhart
@OCA-git-bot
Copy link
Contributor

@StefanRijnhart your merge command was aborted due to failed check(s), which you can inspect on this commit of 13.0-ocabot-merge-pr-268-by-StefanRijnhart-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@StefanRijnhart
Copy link
Member

Apparently, the nuts import attempts a live connection to a remote server which does not respond consistently

2021-03-01 12:38:42,526 5997 INFO openerp_test odoo.addons.l10n_nl_location_nuts.tests.test_l10n_nl_location_nuts: Starting TestNlLocationNuts.test_post_init_hook ...

2021-03-01 12:38:42,543 5997 INFO openerp_test odoo.addons.base_location_nuts.wizard.nuts_import: Importing NUTS 2013 English...

2021-03-01 12:38:42,544 5997 INFO openerp_test odoo.addons.base_location_nuts.wizard.nuts_import: Starting to download http://ec.europa.eu/eurostat/ramon/nomenclatures/index.cfm?TargetUrl=ACT_OTH_CLS_DLD&StrNom=NUTS_2013&StrFormat=XML&StrLanguageCode=EN&StrLayoutCode=HIERARCHIC

2021-03-01 12:38:47,325 5997 INFO openerp_test odoo.addons.l10n_nl_location_nuts.tests.test_l10n_nl_location_nuts: ======================================================================

2021-03-01 12:38:47,325 5997 ERROR openerp_test odoo.addons.l10n_nl_location_nuts.tests.test_l10n_nl_location_nuts: ERROR: TestNlLocationNuts.test_post_init_hook

Traceback (most recent call last):

File "/home/travis/virtualenv/python3.6.7/lib/python3.6/site-packages/urllib3/connectionpool.py", line 600, in urlopen

chunked=chunked)

File "/home/travis/virtualenv/python3.6.7/lib/python3.6/site-packages/urllib3/connectionpool.py", line 384, in _make_request

six.raise_from(e, None)

File "<string>", line 2, in raise_from

File "/home/travis/virtualenv/python3.6.7/lib/python3.6/site-packages/urllib3/connectionpool.py", line 380, in _make_request

httplib_response = conn.getresponse()

File "/opt/python/3.6.7/lib/python3.6/http/client.py", line 1331, in getresponse

response.begin()

File "/opt/python/3.6.7/lib/python3.6/http/client.py", line 297, in begin

version, status, reason = self._read_status()

File "/opt/python/3.6.7/lib/python3.6/http/client.py", line 258, in _read_status

line = str(self.fp.readline(_MAXLINE + 1), "iso-8859-1")

File "/opt/python/3.6.7/lib/python3.6/socket.py", line 586, in readinto

return self._sock.recv_into(b)

File "/home/travis/virtualenv/python3.6.7/lib/python3.6/site-packages/urllib3/contrib/pyopenssl.py", line 302, in recv_into

raise SocketError(str(e))

OSError: (104, 'ECONNRESET')

It would be better to replace this live connection with a mock passing a recorded response.

@astirpe
Copy link
Member Author

astirpe commented Mar 1, 2021

I opened #309 for a solution with mocked tests

@NL66278
Copy link
Contributor

NL66278 commented Jun 9, 2021

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 13.0-ocabot-merge-pr-268-by-NL66278-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jun 9, 2021
Signed-off-by NL66278
@OCA-git-bot
Copy link
Contributor

@NL66278 your merge command was aborted due to failed check(s), which you can inspect on this commit of 13.0-ocabot-merge-pr-268-by-NL66278-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@NL66278
Copy link
Contributor

NL66278 commented Jun 9, 2021

It is now failing on another probably unrelated error:

ERROR: TestTaxInvoiceBasis.test_02_tax_standard

Traceback (most recent call last):

  File "/home/travis/build/OCA/l10n-netherlands/l10n_nl_tax_invoice_basis/tests/test_tax_invoice_basis.py", line 91, in test_02_tax_standard

    self.invoice.action_post()

  File "/home/travis/odoo-13.0/addons/account/models/account_move.py", line 2345, in action_post

    return self.post()

  File "/home/travis/odoo-13.0/addons/account/models/account_move.py", line 2241, in post

    raise UserError(_('The entry %s (id %s) is already posted.') % (move.name, move.id))

odoo.exceptions.UserError: ('The entry BILL/2017/0001 (id 18) is already posted.', '')

@NL66278
Copy link
Contributor

NL66278 commented Aug 20, 2021

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 13.0-ocabot-merge-pr-268-by-NL66278-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Aug 20, 2021
Signed-off-by NL66278
@OCA-git-bot
Copy link
Contributor

@NL66278 your merge command was aborted due to failed check(s), which you can inspect on this commit of 13.0-ocabot-merge-pr-268-by-NL66278-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@hbrunn
Copy link
Member

hbrunn commented Sep 22, 2021

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 13.0-ocabot-merge-pr-268-by-hbrunn-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 516e077 into OCA:13.0 Sep 22, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 98a187e. Thanks a lot for contributing to OCA. ❤️

@astirpe astirpe deleted the 13_fix_l10n_nl_bsn branch September 22, 2021 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants