Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][ADD] l10n_es_aeat_sii_force_type: module to force "Tipo de Comunicación" for SII #3366

Merged
merged 1 commit into from
Mar 25, 2024
Merged

[16.0][ADD] l10n_es_aeat_sii_force_type: module to force "Tipo de Comunicación" for SII #3366

merged 1 commit into from
Mar 25, 2024

Conversation

ACheung-FactorLibre
Copy link
Contributor

@ACheung-FactorLibre ACheung-FactorLibre changed the title [16.0][ADD] l10n_es_aeat_sii_force_type: module to correctly reversals to SII [16.0][ADD] l10n_es_aeat_sii_force_type: module to force "Tipo de Comunicación" for SII Jan 11, 2024
@SoniaViciana SoniaViciana mentioned this pull request Jan 11, 2024
Merged
aritzolea
aritzolea approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@aritzolea aritzolea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technical approval

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@ACheung-FactorLibre
Copy link
Contributor Author

Hola @pedrobaeza,

¿Podrías revisar esto? Muchas gracias por tu tiempo.

Saludos

@pedrobaeza pedrobaeza added this to the 16.0 milestone Mar 14, 2024
pedrobaeza
pedrobaeza requested changes Mar 14, 2024
View reviewed changes
l10n_es_aeat_sii_force_type/readme/CONFIGURE.rst Outdated
@@ -0,0 +1 @@
Este modulo no requiere de ninguna configuración.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sí que la requiere: la casilla en las posiciones fiscales.

l10n_es_aeat_sii_force_type/readme/DESCRIPTION.rst Outdated
@@ -0,0 +1,2 @@
El objetivo del módulo es poder remitir correctamente al SII las devoluciones de IVA en Régimen Especial de Viajeros. Para ello, se habilita dentro de las posiciones fiscales la opción de forzar el "Tipo de Comunicación" para el SII. Si el valor está vacío, prevalece la lógica implementada en l10n_es_aeat_sii.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quita de aquí lo de la casilla y que vaya a CONFIGURE.rst

l10n_es_aeat_sii_force_type/readme/DEVELOP.rst Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No se deben añadir archivos vacíos.

l10n_es_aeat_sii_force_type/readme/INSTALL.rst Outdated
@@ -0,0 +1 @@
No requiere ninguna consideración especial para su instalación.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cuando no hay nada que denotar, se quita el archivo y ya está.

l10n_es_aeat_sii_force_type/readme/ROADMAP.rst Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fuera archivos vacíos

l10n_es_aeat_sii_force_type/readme/USAGE.rst
@@ -0,0 +1,11 @@
Desde la pestaña *SII* de la configuración de una posición fiscal, se puede
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Esto es repetido, e iría en CONFIGURE. Aquí indica dónde se cambia de la factura el tipo.

l10n_es_aeat_sii_force_type/static/description/icon.png Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Este icono no sigue la estela del AEAT y no tiene que ver en principio con el tema del módulo.

l10n_es_aeat_sii_force_type/models/account_fiscal_position.py Outdated
"Allow force communication type on invoices"
)

sii_default_force_communication_type = fields.Selection(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No se puede poner luego otra (y también con la d para ser correcto):

Suggested change
sii_default_force_communication_type = fields.Selection(
sii_forced_communication_type = fields.Selection(

l10n_es_aeat_sii_force_type/models/account_move.py
@api.depends("fiscal_position_id")
def _compute_sii_registration_key(self):
res = super()._compute_sii_registration_key()
for invoice in self.filtered("fiscal_position_id"):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Esto no es correcto de asignar otro campo que no tiene que ver con el compute.

@ACheung-FactorLibre ACheung-FactorLibre force-pushed the 16.0-add-l10n_es_aeat_sii_force_type branch 3 times, most recently from c53bc75 to 047098c Compare March 22, 2024 12:54
@ACheung-FactorLibre
Copy link
Contributor Author

Hola @pedrobaeza,

Se han llevado a cabo los cambios solicitados. Gracias.

Saludos

@pedrobaeza
Copy link
Member

Revisad por favor el CI

@ACheung-FactorLibre ACheung-FactorLibre force-pushed the 16.0-add-l10n_es_aeat_sii_force_type branch from 047098c to dddce86 Compare March 25, 2024 09:57
@ACheung-FactorLibre
Copy link
Contributor Author

Corregido @pedrobaeza, gracias.

pedrobaeza
pedrobaeza approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-3366-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit d6f57ca into OCA:16.0 Mar 25, 2024
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at bff612f. Thanks a lot for contributing to OCA. ❤️

@ACheung-FactorLibre ACheung-FactorLibre deleted the 16.0-add-l10n_es_aeat_sii_force_type branch April 3, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SoniaViciana SoniaViciana SoniaViciana approved these changes

@aritzolea aritzolea aritzolea approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
5 participants
@ACheung-FactorLibre @OCA-git-bot @pedrobaeza @aritzolea @SoniaViciana