[FIX] Upgrade mgmtsystem_claim to v9.0 #141

Jeroen7V · 2016-06-23T17:12:56Z

updated version number
removed dependency to document_page
- according to changelog in mgmtsystem no longer needed
copied the board view from v8.0
removed (commented) sequence type
- no longer needed in odoo v9
section_id became team_id in odoo v9
email.template became mail.template in odoo v9

oca-clabot · 2016-06-23T17:12:58Z

Hey @Jeroen7V, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/website.cla
Here is a list of the users:

@Jeroen7V (login unknown in OCA database)

Appreciation of efforts,
OCA CLAbot

max3903 · 2016-06-23T17:16:55Z

CLA fixed.

max3903 · 2016-06-23T17:17:38Z

README.md

@@ -42,7 +43,6 @@ addon | version | summary
 [mgmtsystem_action_audittrail](mgmtsystem_action_audittrail/) | 1.0 (unported) | Management System - Actions Audit Trail tracking
 [mgmtsystem_audit](mgmtsystem_audit/) | 8.0.1.2.0 (unported) | Management System - Audit
 [mgmtsystem_audit_audittrail](mgmtsystem_audit_audittrail/) | 1.0 (unported) | Management System - Audits Audit Trail tracking
-[mgmtsystem_claim](mgmtsystem_claim/) | 8.0.1.1.0 (unported) | Management System - Claim
 [mgmtsystem_claim_audittrail](mgmtsystem_claim_audittrail/) | 1.0 (unported) | Management System - Claims Audit Trail tracking


@Jeroen7V No need to touch this. It is updated automatically.

max3903 · 2016-06-23T17:21:15Z

@Jeroen7V Try to have modifications to one module only per pull request. It is easier to review.

dreispt · 2016-06-23T18:50:41Z

mgmtsystem_claim/models/mgmtsystem_claim.py

-        vals.update({
-            'reference': self.env['ir.sequence'].get('mgmtsystem.claim')
-        })
+        if vals:


I don't think this if is needed.

dreispt · 2016-06-23T18:58:05Z

Mr.Travis also has a few comments for you:

************* Module mgmtsystem
mgmtsystem/__init__.py:1: [W7908(missing-newline-extrafiles), ] security/ir.model.access.csv Missing newline
************* Module mgmtsystem_claim
mgmtsystem_claim/__init__.py:1: [C7902(missing-readme), ] Missing ./README.rst file. Template here: https://github.com/OCA/maintainer-tools/blob/master/template/module/README.rst
************* Module mgmtsystem_claim.__openerp__
mgmtsystem_claim/__openerp__.py:1: [C8201(no-utf8-coding-comment), ] No UTF-8 coding comment found: Use `# coding: utf-8` or `# -*- coding: utf-8 -*-`
mgmtsystem_claim/__openerp__.py:21: [C8103(manifest-deprecated-key), ] Deprecated key "description" in manifest file
************* Module mgmtsystem_claim.models.mgmtsystem_claim
mgmtsystem_claim/models/mgmtsystem_claim.py:1: [C8201(no-utf8-coding-comment), ] No UTF-8 coding comment found: Use `# coding: utf-8` or `# -*- coding: utf-8 -*-`
mgmtsystem_claim/models/mgmtsystem_claim.py:24: [C8104(class-camelcase), mgmtsystem_claim] Use `CamelCase` "MgmtsystemClaim" in class name "mgmtsystem_claim". You can use oca-autopep8 of https://github.com/OCA/maintainer-tools to auto fix it.
************* Module mgmtsystem_claim.tests.test_create_claim
mgmtsystem_claim/tests/test_create_claim.py:1: [C8201(no-utf8-coding-comment), ] No UTF-8 coding comment found: Use `# coding: utf-8` or `# -*- coding: utf-8 -*-`

max3903 · 2016-06-24T20:23:56Z

@Jeroen7V The form view displays the company field. Can you fix it (should be groups=..., plural):
https://github.com/aitvml/management-system/blob/aedc0267ad222b76c0e14cbfadeedd4af538dd7e/mgmtsystem_claim/views/mgmtsystem_claim.xml#L41

max3903 · 2016-06-24T20:30:38Z

@dreispt The email notification on the claim creation is added to the chatter. Please confirm this is expected.

dreispt · 2016-06-29T08:41:21Z

@max3903 Yes, the message_post methods work writing to the chatter, using a "subtype" that triggers an email. personally I find that useful, since we can track the notifications issues by the system.

dreispt · 2016-06-29T08:42:26Z

@max3903 A more streamlined alternative is to use the Odoo "tracking" features, like in project Issues/Tasks. But we can leave that to another PR.

dreispt · 2016-06-29T08:44:58Z

@Jeroen7V let us know when the the work on out comments is done.

max3903 · 2016-07-05T15:56:33Z

ping @Jeroen7V @aitvml

dreispt · 2016-07-16T17:41:42Z

@Jeroen7V The module fails to install with External ID not found in the system: mgmtsystem_claim.action_report_mgmtsystem_claim" while parsing /home/travis/build/OCA/management-system/mgmtsystem_claim/views/menus.xml:8

See https://travis-ci.org/OCA/management-system/jobs/144723455#L841

max3903 · 2016-07-20T20:30:32Z

@Jeroen7V Few comments:

Please revert your changes on the README.md, mgmtsystem/__openerp__.py and mgmtsystem/views/board_mgmtsystem_view.xml
The company field is displayed in the list view. Attribute name should be groups: https://github.com/aitvml/management-system/blob/3fad522f55d9778e9d153f42cbb468ff5183d305/mgmtsystem_claim/views/mgmtsystem_claim.xml#L23
There is no button and only one step in the workflow.

dreispt · 2016-07-22T13:00:03Z

mgmtsystem_claim/reports/mgmtsystem_claim_report.py

+                    mgmtsystem_claim m
+                group by m.user_id, m.stage_id, m.date, \
+                        m.create_date,m.date_deadline, \
+                        m.date_closed, m.id


This group by operation is redundant, since it groups by id.
IMO skip completely the report model, and instead just add a Pivot view to the mgmtsystem.claim model.

max3903 · 2016-08-01T18:46:12Z

ping @Jeroen7V

dreispt · 2016-08-03T16:27:04Z

I believe this is the last PR to finish the migration, correct?

max3903 · 2016-08-03T18:21:20Z

@dreispt: @lukvml also wanted @naousse to migrate mgmtsystem_kpi and @Jeroen7V to migrate mgmtsystem_nonconformity_claim and mgmtsystem_environment.

See #92

dreispt · 2016-08-04T12:56:12Z

I see. PRs are missing, then.

Jeroen7V · 2016-08-29T15:54:37Z

@max3903 I've reverted my changes and the attribute name is changed. What did you mean by "There is no button and only one step in the workflow."?

max3903 · 2016-08-29T18:18:56Z

@Jeroen7V There is 2 states in the workflow and no button to click to move from one state to the other.

Jeroen7V · 2016-09-25T09:04:51Z

@max3903 Could this be a rights issue? When I check the box 'Common to All Teams' under configuration -> claims -> stages, I am able to choose that stage when creating/editing a claim.

max3903 · 2016-09-26T14:53:11Z

@Jeroen7V Claims belongs to a Sales Team (Direct Sales). You need to add this team to the stages (draft, pending, open, closed and cancel) so users can click on the statusbar.

max3903

Allow claims to move in the workflow (add the stages to the sales team)

Jeroen7V · 2017-01-17T14:28:50Z

@max3903:
Is this the correct way to add the stages to the default stage team? And are there any other changes needed for this module?

max3903 · 2017-01-17T15:01:32Z

@Jeroen7V Let me check and I will get back to you. Hopefully today or later this week. Thanks!

dreispt

I don't see any issues with the code: LGTM

[FIX] Upgrade to odoo v9.0

aedc026

max3903 reviewed Jun 23, 2016
View reviewed changes

dreispt changed the title ~~[FIX] Upgrade to odoo v9.0~~ [FIX] Upgrade mgmtstsem_claim to v9.0 Jun 23, 2016

dreispt changed the title ~~[FIX] Upgrade mgmtstsem_claim to v9.0~~ [FIX] Upgrade mgmtsystem_claim to v9.0 Jun 23, 2016

dreispt reviewed Jun 23, 2016
View reviewed changes

max3903 added the needs fixing label Jun 24, 2016

max3903 added this to the 9.0 milestone Jun 24, 2016

pedrobaeza mentioned this pull request Jun 24, 2016

Migration to version 9.0 #92

Closed

30 tasks

Jeroen7V added 4 commits July 13, 2016 11:44

Merge branch '9.0' of https://github.com/OCA/management-system into HEAD

87d35c8

[FIX] Issues found when asking for pull

7dbaf7d

[ADD] pivot view, remove board

d68bbd2

[FIX] typo 'group=' to 'groups='

350fa99

Jeroen7V added 4 commits July 18, 2016 13:08

[FIX] menu.xml last

f8bcafe

[FIX] Order of xml views

8e9e32d

[FIX] ir_sequence.next deprecated, add acces rule report

d2f00f6

[FIX] lint errors

81de60c

[FIX] Lint errors

3fad522

dreispt reviewed Jul 22, 2016
View reviewed changes

Merge branch '9.0' of https://github.com/OCA/management-system into HEAD

24a860c

Jeroen7V added 3 commits August 24, 2016 09:18

Merge branch '9.0' of https://github.com/OCA/management-system into HEAD

9671dfa

[FIX] Attribute name should be groups

8f714ed

[FIX] revert changes

2b2e89f

max3903 requested changes Sep 28, 2016

View reviewed changes

Jeroen7V added 2 commits January 9, 2017 20:39

Merge branch '9.0' of https://github.com/OCA/management-system into HEAD

7c5c733

[ADD] add parameter case_default=true to claim stages

a721384

Jeroen7V closed this Jan 17, 2017

Jeroen7V reopened this Jan 17, 2017

max3903 requested a review from dreispt January 17, 2017 15:01

dreispt approved these changes Jan 18, 2017

View reviewed changes

max3903 approved these changes Jan 19, 2017

View reviewed changes

max3903 merged commit 2c84235 into OCA:9.0 Jan 19, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[FIX] Upgrade mgmtsystem_claim to v9.0 #141

[FIX] Upgrade mgmtsystem_claim to v9.0 #141

Jeroen7V commented Jun 23, 2016

oca-clabot commented Jun 23, 2016

max3903 commented Jun 23, 2016

max3903 Jun 23, 2016

max3903 commented Jun 23, 2016

dreispt Jun 23, 2016

dreispt commented Jun 23, 2016 •

edited by max3903

Loading

max3903 commented Jun 24, 2016

max3903 commented Jun 24, 2016

dreispt commented Jun 29, 2016

dreispt commented Jun 29, 2016

dreispt commented Jun 29, 2016

max3903 commented Jul 5, 2016

dreispt commented Jul 16, 2016

max3903 commented Jul 20, 2016 •

edited

Loading

dreispt Jul 22, 2016

max3903 commented Aug 1, 2016

dreispt commented Aug 3, 2016

max3903 commented Aug 3, 2016

dreispt commented Aug 4, 2016 •

edited

Loading

Jeroen7V commented Aug 29, 2016

max3903 commented Aug 29, 2016

Jeroen7V commented Sep 25, 2016

max3903 commented Sep 26, 2016

max3903 left a comment •

edited

Loading

Jeroen7V commented Jan 17, 2017

max3903 commented Jan 17, 2017

dreispt left a comment

[FIX] Upgrade mgmtsystem_claim to v9.0 #141

[FIX] Upgrade mgmtsystem_claim to v9.0 #141

Conversation

Jeroen7V commented Jun 23, 2016

oca-clabot commented Jun 23, 2016

max3903 commented Jun 23, 2016

max3903 Jun 23, 2016

Choose a reason for hiding this comment

max3903 commented Jun 23, 2016

dreispt Jun 23, 2016

Choose a reason for hiding this comment

dreispt commented Jun 23, 2016 • edited by max3903 Loading

max3903 commented Jun 24, 2016

max3903 commented Jun 24, 2016

dreispt commented Jun 29, 2016

dreispt commented Jun 29, 2016

dreispt commented Jun 29, 2016

max3903 commented Jul 5, 2016

dreispt commented Jul 16, 2016

max3903 commented Jul 20, 2016 • edited Loading

dreispt Jul 22, 2016

Choose a reason for hiding this comment

max3903 commented Aug 1, 2016

dreispt commented Aug 3, 2016

max3903 commented Aug 3, 2016

dreispt commented Aug 4, 2016 • edited Loading

Jeroen7V commented Aug 29, 2016

max3903 commented Aug 29, 2016

Jeroen7V commented Sep 25, 2016

max3903 commented Sep 26, 2016

max3903 left a comment • edited Loading

Choose a reason for hiding this comment

Jeroen7V commented Jan 17, 2017

max3903 commented Jan 17, 2017

dreispt left a comment

Choose a reason for hiding this comment

dreispt commented Jun 23, 2016 •

edited by max3903

Loading

max3903 commented Jul 20, 2016 •

edited

Loading

dreispt commented Aug 4, 2016 •

edited

Loading

max3903 left a comment •

edited

Loading