Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

9.0 mgmtsystem probability #156

Merged
merged 7 commits into from
Apr 25, 2017
Merged

Conversation

naousse
Copy link

@naousse naousse commented Sep 23, 2016

No description provided.

Copy link
Member

@max3903 max3903 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@naousse Same comments as in #157

@pedrobaeza pedrobaeza mentioned this pull request Sep 26, 2016
30 tasks
Copy link
Member

@dreispt dreispt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nitpicks, but OK otherwise

"website": "http://www.savoirfairelinux.com",
"license": "AGPL-3",
"category": "Management System",
"complexity": "normal",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deprecated

# You should have received a copy of the GNU Affero General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
#
##############################################################################
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to use the short license disclaimers

@@ -0,0 +1,63 @@
<odoo>
<data>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use noupdate="1"?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes!



class MgmtSystemProbability(models.Model):

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this blank line


checks = [
test_create_probability
]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this needed? Might it be deprecated?


* Clone the project from github on your instance
* git clone https://github.com/OCA/management-system.git
* Start odoo with the project in the addons path
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@naousse No need for content here.

To use this module, you need to:

* go to Management System > Configuration > Probability

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@naousse Please add the link to Runbot here.

Contributors
------------

* Loïc Faure-Lacroix <loic.lacroix@savoirfairelinux.com>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@naousse Add yourself

@@ -0,0 +1,63 @@
<odoo>
<data>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes!

@max3903 max3903 modified the milestone: 9.0 Apr 25, 2017
@max3903 max3903 merged commit f6a5895 into OCA:9.0 Apr 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants