[ADD][8.0] mrp_production_raw_material_procurement_group #161
Conversation
|
tested 👍 |
|
@mikevhe18 @azmimr67 please review |
|
👍 Tested On Runbot |
|
Very useful @andhit-r . For my use case would be great to create a procurement group for each MO. I would build a separate module, right? (something such as mrp_production_raw_material_procurement_group_auto) |
|
@jbeficent i think i can do something for your use case. Wait for next my commit. |
|
@jbeficent i made some change to cover your use case. Would you kindly review it again. Many thanks. |
* [IMP] - When a manufacturing order is copied, do not copy the procurement group - When a manufacturing order is confirm, the procurement group is assigned to the stock moves from raw material location to the routing location. * [IMP] -added some more tests to cover the previous changes. * [FIX] errors in tests
|
@jbeficent @lreficent would you kindly review this PR again. Many thanks. |
| "procurement.group"] | ||
| if self.auto_create_procurement_group and \ | ||
| not self.raw_material_procurement_group_id: | ||
| self.raw_material_procurement_group_id = obj_group.create({ |
There was a problem hiding this comment.
Wouldn't be better to call self._prepare_procurement_group before creating? That way we have better extensibility.
| self.assertEqual( | ||
| mo2.raw_material_procurement_group_id.id, False) | ||
|
|
||
| def test_copy_mo_2(self): |
There was a problem hiding this comment.
Rename to test_group_name, I think it would be more descriptive.
|
@andhit-r, @lreficent will propose the improvements as a PR to your branch. |
|
@jbeficent @lreficent i did cherry-pick on @lreficent last commit (785b22c). This due conflict on andhit-r#2 Many thanks for revision. |
|
cc @lreficent Can you start to port to v9? |
|
Yes, I'll work in that. |
Create Procurement Group On Manufacturing Order
This module adds ability to group manufacturing order's raw material moves, and
other moves created by it's pull flow, by given procurement group.
Usage
To use this module, you need to:
other moves created by it's pull flow, will be grouped based on Raw Material Procurement Group
given