Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.0][MIG/REN] mrp_repair_calendar_view -> repair_calendar_view #447

Merged
merged 6 commits into from
Feb 10, 2020
Merged

[12.0][MIG/REN] mrp_repair_calendar_view -> repair_calendar_view #447

merged 6 commits into from
Feb 10, 2020

Conversation

mariaasunciondaza
Copy link

@mariaasunciondaza mariaasunciondaza mentioned this pull request Dec 30, 2019
Closed
17 tasks
NachoAlesLopez
NachoAlesLopez approved these changes Jan 2, 2020
View reviewed changes
Copy link
Contributor

@NachoAlesLopez NachoAlesLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and functional review: OK.

@elvise
Copy link

elvise commented Jan 19, 2020

Hi, any good news for merge...?
If I can help please let me know...

ps-tubtim
ps-tubtim approved these changes Jan 27, 2020
View reviewed changes
Copy link
Member

@ps-tubtim ps-tubtim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional Test: Ok. Code review: Ok.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@LoisRForgeFlow
Copy link
Contributor

LoisRForgeFlow commented Jan 29, 2020 •
edited
Loading

@mariaasunciondaza you didn't mention this is also a rename of the module...

Please, squash these commits together:
screenshot-2020-01-29

Thanks for the work.

@LoisRForgeFlow LoisRForgeFlow changed the title [MIG][12.0][WIP] Migrating mrp_repair_calendar_view [12.0][MIG/REN] mrp_repair_calendar_view -> repair_calendar_view Jan 29, 2020
oca-transbot and others added 5 commits January 30, 2020 09:01
@LoisRForgeFlow
Copy link
Contributor

Thanks!

/ocabot merge

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 12.0-ocabot-merge-pr-447-by-LoisRForgeFlow-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Feb 10, 2020
@OCA-git-bot
Merge PR #447 into 12.0
aaebd74 
Signed-off-by LoisRForgeFlow
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 12.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 12.0-ocabot-merge-pr-447-by-LoisRForgeFlow-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Feb 10, 2020
@OCA-git-bot
Merge PR #447 into 12.0
c3c63fa 
Signed-off-by LoisRForgeFlow
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 12.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 12.0-ocabot-merge-pr-447-by-LoisRForgeFlow-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Feb 10, 2020
@OCA-git-bot
Merge PR #447 into 12.0
ce6a1d7 
Signed-off-by LoisRForgeFlow
@OCA-git-bot OCA-git-bot merged commit 607aafa into OCA:12.0 Feb 10, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 2db81d4. Thanks a lot for contributing to OCA. ❤️

@mariaasunciondaza mariaasunciondaza deleted the 12.0-mig-mrp_repair_calendar_view branch February 25, 2020 07:26
rvalyi pushed a commit to akretion/manufacture that referenced this pull request Mar 3, 2020
@OCA-git-bot
Merge PR OCA#447 into 12.0
f3daa5d 
Signed-off-by LoisRForgeFlow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ps-tubtim ps-tubtim ps-tubtim approved these changes

@NachoAlesLopez NachoAlesLopez NachoAlesLopez approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.