Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MIG] Make mrp_bom_note installable in v9 #72

Merged
merged 1 commit into from
Jan 18, 2016
Merged

[MIG] Make mrp_bom_note installable in v9 #72

merged 1 commit into from
Jan 18, 2016

Conversation

oihane
Copy link
Contributor

@oihane oihane commented Jan 14, 2016

  • mrp_bom_note

@pedrobaeza
Copy link
Member

One module per PR, please.

@oihane oihane changed the title [MIG] Make modules installable in v9 [MIG] Make mrp_bom_note installable in v9 Jan 14, 2016
@oihane
Copy link
Contributor Author

oihane commented Jan 14, 2016

Ok, changed, but what about the other two modules that one depends on the other?

max3903
max3903 reviewed Jan 14, 2016
View reviewed changes
mrp_bom_note/views/mrp_bom_view.xml
@@ -2,18 +2,18 @@
<openerp>
<data>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<data> can be removed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@max3903 is that something about v9? What in case it is noupdate?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oihane I don't know if noupdate works in <odoo>, but you don't have any here so it should work.

@max3903 max3903 modified the milestone: 9.0 Jan 15, 2016
@oihane
Copy link
Contributor Author

oihane commented Jan 18, 2016

@pedrobaeza @max3903 there is some issue with coveralls, but module is ready for review

@max3903
Copy link
Member

max3903 commented Jan 18, 2016

👍

@oihane To answer your question about dependency, you need to migrate the dependencies first and once merged, you rebase to migrate your target module.

@pedrobaeza
Copy link
Member

👍 Merging to continue the rest of the modules migration

pedrobaeza added a commit that referenced this pull request Jan 18, 2016
@pedrobaeza
Merge pull request #72 from oihane/9.0-migrated
53a0c1e 
[MIG] Make mrp_bom_note installable in v9
@pedrobaeza pedrobaeza merged commit 53a0c1e into OCA:9.0 Jan 18, 2016
@oihane oihane deleted the 9.0-migrated branch January 18, 2016 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
9.0
Development

Successfully merging this pull request may close these issues.
4 participants
@oihane @pedrobaeza @max3903 @yvaucher