Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][ADD] mrp_unbuild_move_link #908

Merged
merged 1 commit into from
Dec 19, 2022

Conversation

ThiagoMForgeFlow
Copy link

No description provided.

@ThiagoMForgeFlow ThiagoMForgeFlow force-pushed the 14.0-add-mrp_unbuild_move_link branch 2 times, most recently from 6c7cc09 to 7ac6274 Compare December 5, 2022 10:42
Copy link

@mariadforgeflow mariadforgeflow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Just a minor comment, could you put the PR title as [14.0][ADD]...

@ThiagoMForgeFlow ThiagoMForgeFlow changed the title 14.0 add mrp unbuild move link [14.0][ADD] mrp_unbuild_move_link Dec 9, 2022
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@JordiBForgeFlow
Copy link
Member

/ocabot merge

@OCA-git-bot
Copy link
Contributor

Hi @JordiBForgeFlow. Your command failed:

Required option bumpversion_mode for command merge. Possible values : major, minor, patch, nobump.

Ocabot commands

  • ocabot merge major|minor|patch|nobump
  • ocabot rebase
  • ocabot migration {MODULE_NAME}

More information

@JordiBForgeFlow
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Sorry @JordiBForgeFlow you are not allowed to merge.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

@JordiBForgeFlow
Copy link
Member

@LoisRForgeFlow this one is ready to merge

@LoisRForgeFlow
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-908-by-LoisRForgeFlow-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 8838363 into OCA:14.0 Dec 19, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at e5cd187. Thanks a lot for contributing to OCA. ❤️

@LoisRForgeFlow LoisRForgeFlow deleted the 14.0-add-mrp_unbuild_move_link branch December 19, 2022 15:23
@ypapouin
Copy link

@ThiagoMForgeFlow, for the record, a warning is raised in the console, check_company is mispelled.

WARNING demo odoo.fields: Field stock.move.origin_mrp_manufacture_move_id: unknown parameter 'checkcompany', if this is an actual parameter you may want to override the method _valid_field_parameter on the relevant model in order to allow it 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants