Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.0][MIG] account_invoice_inter_company #196

Merged

Conversation

AdriaGForgeFlow
Copy link
Contributor

Standard migration of module account_invoice_inter_company to v13.

cc ~ @ForgeFlow

chafique-delli and others added 29 commits March 27, 2020 11:06
* [10.0]Migrate account_invoice_inter_company module to v10

* refactor code for play onchange method

* active demo datas and fix account_invoice.py, res_config.py, README.rst file

* extract the search domain of users from the _check_intercompany_product method

* fix test

* fix test and update french translation

* rename openerp to odoo

* fix test_flake8 and fix views after David's comment

* add oca_dependencies.txt

* fix bare except

* improve action_cancel method

* fix chart_template_id in tests

* fix transfer_account_id in tests

* fix chart_template_id for company B in tests

* improve tests

* fix tests taking into account the base_multi_company module

* fix tests and contributors after lasley's comment

* improve tests

* fix account_invoice.py after mourad's comment

* fix tests after lasley's comment

* fix transfer account template in demo data

* increases test coverage

* improve action_invoice_open method after astirpe's comment

* fix value for chart_template_id in tests
This demo data is quite dangerous by design, since it creates compenies, accounts, decides the companies country, etc. All of that by hand.

In a tested integration environment, this fails when installing account-related addons due to companies not having a chart of accounts.

The fix is simple: remove this from demo data and leave it just as test data.
… in invoice lines (OCA#111)

* Add product mapping in roadmap
* Allow creation of invoice lines without products
FIX misc annotations from @astirpe, thanks

Co-Authored-By: bealdav <david.beal@akretion.com>
Co-Authored-By: mourad-ehm <mourad.elhadj.mimoune@akretion.com>
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: multi-company-12.0/multi-company-12.0-account_invoice_inter_company
Translate-URL: https://translation.odoo-community.org/projects/multi-company-12-0/multi-company-12-0-account_invoice_inter_company/
…rity

`password_security` asks by default for some minimal rules in the password. If it happens to be installed before this module, in an integration environment, it cannot be loaded.

It's just demo data, so I just use a longer password here.
Currently translated at 100.0% (22 of 22 strings)

Translation: multi-company-12.0/multi-company-12.0-account_invoice_inter_company
Translate-URL: https://translation.odoo-community.org/projects/multi-company-12-0/multi-company-12-0-account_invoice_inter_company/zh_CN/
Currently translated at 50.0% (11 of 22 strings)

Translation: multi-company-12.0/multi-company-12.0-account_invoice_inter_company
Translate-URL: https://translation.odoo-community.org/projects/multi-company-12-0/multi-company-12-0-account_invoice_inter_company/hr/
Currently translated at 100.0% (22 of 22 strings)

Translation: multi-company-12.0/multi-company-12.0-account_invoice_inter_company
Translate-URL: https://translation.odoo-community.org/projects/multi-company-12-0/multi-company-12-0-account_invoice_inter_company/it/
@AdriaGForgeFlow AdriaGForgeFlow force-pushed the 13.0-mig-account_invoice_inter_company branch from 6ce05ca to 6a37538 Compare March 30, 2020 08:41
Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional test in local, LGTM

Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works good. Just a minor remark?

<field name="price_unit" eval="450.0" />
<field name="company_id" ref="company_a" />
</record>
<!-- <record id="customer_invoice_company_a" model="account.move">-->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to remove this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you're right I missed this one.

@AdriaGForgeFlow AdriaGForgeFlow force-pushed the 13.0-mig-account_invoice_inter_company branch from 6a37538 to ac860b2 Compare March 30, 2020 15:20
@OCA-git-bot OCA-git-bot mentioned this pull request Mar 31, 2020
12 tasks
@JordiBForgeFlow JordiBForgeFlow force-pushed the 13.0-mig-account_invoice_inter_company branch 2 times, most recently from db910d8 to 0b81066 Compare March 31, 2020 04:55
* intercompany_invoice_user_id
* company_share_product (restored from previous versions)
@JordiBForgeFlow JordiBForgeFlow force-pushed the 13.0-mig-account_invoice_inter_company branch from 0b81066 to b173f0b Compare March 31, 2020 05:25
@JordiBForgeFlow
Copy link
Member

@AdriaGForgeFlow after reviewing the purchase_sale_inter_company and the previous versions of this module it seems to me that we should better define an inter_company_invoice_user_id, and also we need to add to the config the option to disable the product security rules. Implemented here:
b173f0b

Copy link
Member

@JordiBForgeFlow JordiBForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Functional and technical review.

@AdriaGForgeFlow
Copy link
Contributor Author

@AdriaGForgeFlow after reviewing the purchase_sale_inter_company and the previous versions of this module it seems to me that we should better define an inter_company_invoice_user_id, and also we need to add to the config the option to disable the product security rules. Implemented here:
b173f0b

Makes sense, thanks for the help 👍
Is it ready to merge?

@AdriaGForgeFlow AdriaGForgeFlow force-pushed the 13.0-mig-account_invoice_inter_company branch from af56c17 to ace654c Compare April 1, 2020 07:42
@JordiBForgeFlow
Copy link
Member

/ocabot merge

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 13.0-ocabot-merge-pr-196-by-JordiBForgeFlow-bump-no, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 419beaf into OCA:13.0 Apr 1, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 334c378. Thanks a lot for contributing to OCA. ❤️

SilvioC2C added a commit to camptocamp/multi-company that referenced this pull request Mar 7, 2023
* Fix releases 15.0.1.0.z (OCA#183)

* BSSBG-2749: Remove cloud-platform modules from migration scripts

* BSSBG-2749: Add end-of-migration script to introduce pre-mig releases

* BSSBG-2749: Squash all migration-related releases

* Release 15.0.1.0.3

* BSSBG-2781: Upgrade Odoo core and Enterprise submodules

* BSSBG-2781: Remove deprecated platform script

* Release 15.0.1.0.4

* Fix: Remove ``website`` and related modules from migration (OCA#196)

* Fix: Fix menu icons and remove Odoo upgrade banner and ribbon (OCA#199)

* Fix: Fix wrong migration script for product's ``quality_check`` field

* Fix: Fix wrongly declared view inheritance on ``product.template``

* Imp: Update on-premise ``docker-compose.yml`` file (OCA#201)

* Release 15.0.1.0.5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.