-
-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[13.0][MIG] account_invoice_inter_company #196
[13.0][MIG] account_invoice_inter_company #196
Conversation
* [10.0]Migrate account_invoice_inter_company module to v10 * refactor code for play onchange method * active demo datas and fix account_invoice.py, res_config.py, README.rst file * extract the search domain of users from the _check_intercompany_product method * fix test * fix test and update french translation * rename openerp to odoo * fix test_flake8 and fix views after David's comment * add oca_dependencies.txt * fix bare except * improve action_cancel method * fix chart_template_id in tests * fix transfer_account_id in tests * fix chart_template_id for company B in tests * improve tests * fix tests taking into account the base_multi_company module * fix tests and contributors after lasley's comment * improve tests * fix account_invoice.py after mourad's comment * fix tests after lasley's comment * fix transfer account template in demo data * increases test coverage * improve action_invoice_open method after astirpe's comment * fix value for chart_template_id in tests
This demo data is quite dangerous by design, since it creates compenies, accounts, decides the companies country, etc. All of that by hand. In a tested integration environment, this fails when installing account-related addons due to companies not having a chart of accounts. The fix is simple: remove this from demo data and leave it just as test data.
… in invoice lines (OCA#111) * Add product mapping in roadmap * Allow creation of invoice lines without products
FIX misc annotations from @astirpe, thanks Co-Authored-By: bealdav <david.beal@akretion.com>
Co-Authored-By: mourad-ehm <mourad.elhadj.mimoune@akretion.com>
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: multi-company-12.0/multi-company-12.0-account_invoice_inter_company Translate-URL: https://translation.odoo-community.org/projects/multi-company-12-0/multi-company-12-0-account_invoice_inter_company/
…rity `password_security` asks by default for some minimal rules in the password. If it happens to be installed before this module, in an integration environment, it cannot be loaded. It's just demo data, so I just use a longer password here.
Currently translated at 100.0% (22 of 22 strings) Translation: multi-company-12.0/multi-company-12.0-account_invoice_inter_company Translate-URL: https://translation.odoo-community.org/projects/multi-company-12-0/multi-company-12-0-account_invoice_inter_company/zh_CN/
Currently translated at 50.0% (11 of 22 strings) Translation: multi-company-12.0/multi-company-12.0-account_invoice_inter_company Translate-URL: https://translation.odoo-community.org/projects/multi-company-12-0/multi-company-12-0-account_invoice_inter_company/hr/
Currently translated at 100.0% (22 of 22 strings) Translation: multi-company-12.0/multi-company-12.0-account_invoice_inter_company Translate-URL: https://translation.odoo-community.org/projects/multi-company-12-0/multi-company-12-0-account_invoice_inter_company/it/
6ce05ca
to
6a37538
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional test in local, LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works good. Just a minor remark?
<field name="price_unit" eval="450.0" /> | ||
<field name="company_id" ref="company_a" /> | ||
</record> | ||
<!-- <record id="customer_invoice_company_a" model="account.move">--> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better to remove this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, you're right I missed this one.
6a37538
to
ac860b2
Compare
db910d8
to
0b81066
Compare
* intercompany_invoice_user_id * company_share_product (restored from previous versions)
0b81066
to
b173f0b
Compare
@AdriaGForgeFlow after reviewing the purchase_sale_inter_company and the previous versions of this module it seems to me that we should better define an inter_company_invoice_user_id, and also we need to add to the config the option to disable the product security rules. Implemented here: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Functional and technical review.
Makes sense, thanks for the help 👍 |
af56c17
to
ace654c
Compare
/ocabot merge |
On my way to merge this fine PR! |
Congratulations, your PR was merged at 334c378. Thanks a lot for contributing to OCA. ❤️ |
* Fix releases 15.0.1.0.z (OCA#183) * BSSBG-2749: Remove cloud-platform modules from migration scripts * BSSBG-2749: Add end-of-migration script to introduce pre-mig releases * BSSBG-2749: Squash all migration-related releases * Release 15.0.1.0.3 * BSSBG-2781: Upgrade Odoo core and Enterprise submodules * BSSBG-2781: Remove deprecated platform script * Release 15.0.1.0.4 * Fix: Remove ``website`` and related modules from migration (OCA#196) * Fix: Fix menu icons and remove Odoo upgrade banner and ribbon (OCA#199) * Fix: Fix wrong migration script for product's ``quality_check`` field * Fix: Fix wrongly declared view inheritance on ``product.template`` * Imp: Update on-premise ``docker-compose.yml`` file (OCA#201) * Release 15.0.1.0.5
Standard migration of module account_invoice_inter_company to v13.
cc ~ @ForgeFlow