-
-
Notifications
You must be signed in to change notification settings - Fork 600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix][8.0] Fix the way pricelists are selected when a template_id is set as rule of pricelist #100
Conversation
// Check category | ||
cond = cond && ( | ||
item.categ_id === false || | ||
categ_ids.indexOf(item.categ_id[0]) !== -1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is categ_ids defined?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah this seems to be missing when I moved some code to that method. I'll fix that.
Thanks for the fix! I added some small discussion points to the code. |
I fear it might not be that simple. I remember it was working with pos_pricelist alone, but apparently with pos_template there are still some problems :( |
Ah non forget my previous comment, I just forgot to move some code in the function I added. The problem I had is something completely different. |
Any news about this patch? |
Hi @ismaelcj @jcarlosmontoya @AdilHoumadi , have you experimented this issue with pos_pricelist? Maybe you could take a look here. Thanks! |
Hi @krupesh-weboffice, this PR resolves your issue #90, could you test it please? Thanks! |
Hi @llacroix , there have been some changes in travis. Please could you rebase this PR in order to check it again? Thanks |
I guess I can do that. A bit later today. |
@llacroix : could you rebase ? thanks. |
It can be inherited which allow other modules to extend the way the pricelists are chosen. Also a rule in the while loop could be removed as it duplicated one of the tests when chosing the available pricelists.
496330b
to
3aab34a
Compare
Rebased |
Is this OK? Or should it be closed? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review, no test.
Merging this after a while with one verified reviewer and green status. |
Added a method that help matching which pricelist can be used.
It can be inherited which allow other modules to extend the way the
pricelists are chosen.
Also a rule in the while loop could be removed as it duplicated
one of the tests when chosing the available pricelists.
Fix the issue here:
#90