Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] pylint_odoo: Check if the package start with dot to skip #171

Conversation

JesusZapata
Copy link
Member

@JesusZapata JesusZapata commented Nov 27, 2017

Check if the package start with dot to skip because this package is absolute import

This change now detect when the import start with dot for example

from .no_exists import package

If the import start with dot that import is not detect as external dependency

Related with Vauxoo#134

Fix #170

@JesusZapata
Copy link
Member Author

@moylop260
Your opinion is welcome

@JesusZapata
Copy link
Member Author

@rousseldenis
This change fix your issue related with missing external dependency
Do you check if this change fix your problem?

Copy link

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested

@moylop260 moylop260 merged commit 2f26b15 into OCA:master Nov 28, 2017
@moylop260 moylop260 deleted the master-oca-fix-external-dependency-jesuszapata branch November 28, 2017 01:02
@JesusZapata JesusZapata restored the master-oca-fix-external-dependency-jesuszapata branch December 1, 2017 23:17
@JesusZapata JesusZapata deleted the master-oca-fix-external-dependency-jesuszapata branch December 2, 2017 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants