Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] file-not-used: Emit message if there are xml, yml, sql or csv files but It isn't referenced from manifest #53

Merged
merged 5 commits into from
Aug 19, 2016

Conversation

moylop260
Copy link
Collaborator

No description provided.

@moylop260 moylop260 self-assigned this Jul 27, 2016
@dreispt
Copy link
Member

dreispt commented Jul 27, 2016

👍

@@ -91,7 +91,7 @@
# Files supported from manifest to convert
# Extracted from openerp/tools/convert.py:def convert_file
DFLT_EXTFILES_CONVERT = ['csv', 'sql', 'xml', 'yml']
DFLT_EXTFILES_TO_LINT = DFLT_EXTFILES_CONVERT + ['po', 'js', 'mako']
DFLT_EXTFILES_TO_LINT = DFLT_EXTFILES_CONVERT + ['po', 'js', 'mako', 'rst']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add md, markdown, 'png` ?

Copy link
Collaborator Author

@moylop260 moylop260 Jul 30, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added md and markdown extension to extra files to lint.
I don't understood the png files because they are binary (not text) then I can't add a linter for a binary one

@alan196
Copy link

alan196 commented Aug 16, 2016

👍

1 similar comment
@oscarolar
Copy link

👍

@moylop260
Copy link
Collaborator Author

Could we merge it?

@moylop260
Copy link
Collaborator Author

After merge this one could you create a tag to release a new version with all new checks?
git tag -s 1.3.1

@pedrobaeza
Copy link
Member

Merging. Please proceed yourself with the tag.

@pedrobaeza pedrobaeza merged commit 91dc3e4 into OCA:master Aug 19, 2016
@luisg123v luisg123v deleted the oca-master-file-not-used-moy branch August 6, 2020 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants