[ADD] file-not-used: Emit message if there are xml, yml, sql or csv files but It isn't referenced from manifest #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
| @@ -91,7 +91,7 @@ | |||
| # Files supported from manifest to convert | |||
| # Extracted from openerp/tools/convert.py:def convert_file | |||
| DFLT_EXTFILES_CONVERT = ['csv', 'sql', 'xml', 'yml'] | |||
| DFLT_EXTFILES_TO_LINT = DFLT_EXTFILES_CONVERT + ['po', 'js', 'mako'] | |||
| DFLT_EXTFILES_TO_LINT = DFLT_EXTFILES_CONVERT + ['po', 'js', 'mako', 'rst'] | |||
There was a problem hiding this comment.
add md, markdown, 'png` ?
There was a problem hiding this comment.
Added md and markdown extension to extra files to lint.
I don't understood the png files because they are binary (not text) then I can't add a linter for a binary one
moylop260
force-pushed
the
oca-master-file-not-used-moy
branch
from
dd3fc55
to
2e05397
Compare
|
👍 |
1 similar comment
|
👍 |
…iles but It isn't referenced from manifest
moylop260
force-pushed
the
oca-master-file-not-used-moy
branch
from
2e05397
to
983aefe
Compare
|
Could we merge it? |
|
After merge this one could you create a tag to release a new version with all new checks? |
|
Merging. Please proceed yourself with the tag. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.