[14.0] [MIG] rma module #189

chafique-delli · 2020-12-07T14:42:59Z

No description provided.

OCA-git-bot · 2020-12-07T14:43:03Z

Hi @ernestotejeda,
some modules you are maintaining are being modified, check this out!

chafique-delli · 2020-12-11T11:09:31Z

@pedrobaeza , ping.

sebastienbeau · 2020-12-19T17:34:01Z

Rebased to solve pre-commit issue

pedrobaeza · 2020-12-22T16:50:38Z

Please include #193

chafique-delli · 2021-01-29T15:13:24Z

Please include #193
@pedrobaeza , The PR #193, you're telling me is an improvement that only concerns the modules rma_sale and website_rma ?

pedrobaeza · 2021-01-29T15:16:19Z

Sorry, you're right. The comment should go in #190

chafique-delli · 2021-01-29T15:18:13Z

Sorry, you're right. The comment should go in #190

Ok, I'll take care of integrating it into the PR #190.

ernestotejeda

I think it would be better if you put everything related to the migration in a single commmit:

ernestotejeda · 2021-04-06T15:11:05Z

rma/wizard/rma_delivery.py

            if not self.product_uom or self.product_id.uom_id.id != self.product_uom.id:
                self.product_uom = self.product_id.uom_id
-        return {"domain": {"product_uom": domain_product_uom}}


Why do you think this should be removed?

In the Odoo logs, I had this warning:
....onchange method RmaReDeliveryWizard._onchange_product_id returned a domain, this is deprecated

Solution1:
1.add a field uom_category_id = fields.Many2one(related='product_id.uom_id.category_id')
2. and add on view domain="[('category_id', '=', uom_category_id)]" for product_uom
Solution2:
1.add a field allowed_uom_ids = fields.Many2many('uom.uom', compute="_compute_allowed_uoms")
@api.depends('product_id')
def _compute_allowed_uoms(self):
...
2. and add on view domain="[('id '=', allowed_uom_ids)]" for product_uom

ernestotejeda

ernestotejeda

chienandalu · 2021-04-29T12:36:13Z

Please consider forward ports from v12.0 to v13.0 included here https://github.com/OCA/rma/pull/213/commits to avoid functionality regression

[UPD] Update rma.pot Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: rma-12.0/rma-12.0-rma Translate-URL: https://translation.odoo-community.org/projects/rma-12-0/rma-12-0-rma/

…flow + Translated using Weblate (Spanish) [FIX] rma: views permissions Regular users don't have permissions to rma models, so we should avoid loading views that lead to permission errors. TT24986 rma 12.0.1.1.0 Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: rma-12.0/rma-12.0-rma Translate-URL: https://translation.odoo-community.org/projects/rma-12-0/rma-12-0-rma/ [FIX] rma: portal views access errors - Portal mail thread needs token config. - Unpublished products will raise AccessError on RMAs portal views for portal users due to record rules. - Ensure active_id when getting actions in rma, since we could come from a context that pollutes the expected active rma id. [IMP] rma: teams flow - If no RMA Team is set, we'll assign a default one to the new RMA. - A sequence is now used to search for the top team and assign it. - No default user is assigned when it's not in the context (i.e. portal rmas). [UPD] Update rma.pot rma 12.0.1.2.0 Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: rma-12.0/rma-12.0-rma Translate-URL: https://translation.odoo-community.org/projects/rma-12-0/rma-12-0-rma/ Translated using Weblate (Spanish) Currently translated at 96.2% (253 of 263 strings) Translation: rma-12.0/rma-12.0-rma Translate-URL: https://translation.odoo-community.org/projects/rma-12-0/rma-12-0-rma/es/

- Fix thrown error when trying to download a picking from the portal. - Add the hook method to prepare RMA values from the return pick wizard. - Add the access rule for portal users. - Show the portal 'Request RMAs' button on the sales page only to users related to the sales order. [UPD] Update rma.pot rma 12.0.1.3.0 Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: rma-12.0/rma-12.0-rma Translate-URL: https://translation.odoo-community.org/projects/rma-12-0/rma-12-0-rma/

Currently translated at 100.0% (263 of 263 strings) Translation: rma-12.0/rma-12.0-rma Translate-URL: https://translation.odoo-community.org/projects/rma-12-0/rma-12-0-rma/es/

- Avoid permission blockings on users who doesn't have RMA permissions. - Add activities view on RMA list. [UPD] Update rma.pot rma 12.0.1.3.1

Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: rma-12.0/rma-12.0-rma Translate-URL: https://translation.odoo-community.org/projects/rma-12-0/rma-12-0-rma/

- Now it's possible to open several RMAs in a sale order from the portal - A new comment button has been added to allow the portal user to enter relevant information like serial numbers o issue description. - If the requested operation isn't set no RMA will be opened - The RMA product qty is now a numeric control with limits according to the qty available to return [FIX] rma,rma_sale: fix linter errors [UPD] Update rma.pot rma 12.0.1.4.0 Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: rma-12.0/rma-12.0-rma Translate-URL: https://translation.odoo-community.org/projects/rma-12-0/rma-12-0-rma/

Not indicating account.invoice, it takes the default that is the vendor bill view. We force the suitable one.

…ype use existing lot by default. [IMP] rma: set rma to received on invoice delete. Remove 'waiting_refund' rma state. RMAs go from received to refunded. When the linked refund is deleted the rma is set to received. [UPD] Update rma.pot rma 12.0.1.4.2 Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: rma-12.0/rma-12.0-rma Translate-URL: https://translation.odoo-community.org/projects/rma-12-0/rma-12-0-rma/ [IMP] rma: incoming picking type use existing lot by default. rma 12.0.1.4.3

florian-dacosta · 2021-06-21T18:45:05Z

@pedrobaeza This one seems like a rma_sale fix or am I missing something ?

So it concerns this PR : #190
And I think Chafique will rebase it on top of 13.0, so it should be taken into account when he'll do it

pedrobaeza · 2021-06-21T18:46:09Z

Oh, yes sorry, I mixed both.

chienandalu · 2021-06-29T16:43:38Z

Can you include 69db691 and 3d63ad8 ?

florian-dacosta · 2021-07-26T14:20:31Z

Hello @chienandalu I made 2 cherry-picks to take the commit you mention into account.

Could you review so we can try to merge it soon ?
Thanks

pedrobaeza · 2021-07-26T14:25:05Z

@ernestotejeda please review to see if something is missing and let's try to merge this ASAP.

ernestotejeda

Error during RMA team creation:

ernestotejeda · 2021-07-27T18:34:22Z

rma/models/rma_team.py

+    def get_alias_model_name(self, vals):
+        return vals.get("alias_model", "rma")
+
+    def get_alias_values(self):
+        values = super().get_alias_values()
+        values["alias_defaults"] = {"team_id": self.id}
+        return values


It seems these two methods doesn't exist in v14.0

ernestotejeda

ernestotejeda

@chafique-delli Apart from the error I mentioned above, everything looks good to me; fix them and I will approve the PR. thanks :).

ernestotejeda

@chafique-delli include this commit 3afd940, please

Now we can configure if an automatic notification should be sent when we receive the goods from an RMA in our warehouse If we've got `rma_sale` or `website_rma` we can also configure draft notifications so when the customer places an RMA from the portal the receive an acknowledge email. TT29595

Now we can decide which tags are visible for the customer. This way, we can use them as pseudo-states TT29594

TT30985

rma/views/rma_tag_views.xml

rma/views/rma_team_views.xml

ernestotejeda · 2021-07-28T23:01:28Z

The previous Suggested Changes fix this error #189 (review)

Co-authored-by: Ernesto Tejeda <ernesto.tejeda87@gmail.com>

florian-dacosta · 2021-07-29T08:42:03Z

@ernestotejeda Thanks for the suggestion, I applied it. I think all remarks have been attended now.

ernestotejeda

Thank you very much @florian-dacosta @chafique-delli

pedrobaeza · 2021-07-29T12:05:15Z

Thanks all for the efforts:

/ocabot merge nobump

OCA-git-bot · 2021-07-29T12:05:27Z

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 14.0-ocabot-merge-pr-189-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot · 2021-07-29T12:07:44Z

Congratulations, your PR was merged at 7c3acf6. Thanks a lot for contributing to OCA. ❤️

This was referenced Dec 10, 2020

Migration to version 14.0 #169

Closed

[14.0] [MIG] rma_sale module #190

Merged

sebastienbeau force-pushed the 14.0-mig-rma branch from d966c41 to e8137e7 Compare December 19, 2020 17:33

rousseldenis added migration needs review labels Jan 19, 2021

rousseldenis added this to the 14.0 milestone Jan 19, 2021

This comment has been minimized.

Sign in to view

ernestotejeda reviewed Apr 6, 2021

View reviewed changes

ernestotejeda reviewed Apr 7, 2021

View reviewed changes

chafique-delli force-pushed the 14.0-mig-rma branch from e8137e7 to aaf9055 Compare May 2, 2021 12:52

bguillot force-pushed the 14.0-mig-rma branch from aaf9055 to d89ab60 Compare May 18, 2021 09:03

Ernesto Tejeda and others added 10 commits June 6, 2021 19:14

[ADD] rma: new module

eb0f8c2

[UPD] Update rma.pot Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: rma-12.0/rma-12.0-rma Translate-URL: https://translation.odoo-community.org/projects/rma-12-0/rma-12-0-rma/

Added translation using Weblate (Portuguese (Brazil))

f8677a5

Translated using Weblate (Spanish)

51120ae

Currently translated at 100.0% (263 of 263 strings) Translation: rma-12.0/rma-12.0-rma Translate-URL: https://translation.odoo-community.org/projects/rma-12-0/rma-12-0-rma/es/

[FIX] rma: permissions for general users

cf13fb0

- Avoid permission blockings on users who doesn't have RMA permissions. - Add activities view on RMA list. [UPD] Update rma.pot rma 12.0.1.3.1

[IMP] rma: Return created sequence on create_rma_index

24ae7ba

Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: rma-12.0/rma-12.0-rma Translate-URL: https://translation.odoo-community.org/projects/rma-12-0/rma-12-0-rma/

[FIX] rma: Perform refund with proper view

845a98c

Not indicating account.invoice, it takes the default that is the vendor bill view. We force the suitable one.

dreispt added question and removed needs review labels Jul 3, 2021

florian-dacosta force-pushed the 14.0-mig-rma branch from 3b3aff0 to b450c18 Compare July 26, 2021 11:27

ernestotejeda reviewed Jul 27, 2021

View reviewed changes

ernestotejeda reviewed Jul 28, 2021

View reviewed changes

chafique-delli and others added 4 commits July 28, 2021 17:42

[MIG] rma: Migration to 14.0

b9538d5

[IMP] rma: public tags

7b25e76

Now we can decide which tags are visible for the customer. This way, we can use them as pseudo-states TT29594

[IMP] rma: allow to archive operation types

8e3c179

TT30985

florian-dacosta force-pushed the 14.0-mig-rma branch from b450c18 to 8e3c179 Compare July 28, 2021 15:43

ernestotejeda reviewed Jul 28, 2021

View reviewed changes

rma/views/rma_tag_views.xml Outdated Show resolved Hide resolved

rma/views/rma_team_views.xml Outdated Show resolved Hide resolved

Remove useless archive/unarchive button on form views

174194f

Co-authored-by: Ernesto Tejeda <ernesto.tejeda87@gmail.com>

ernestotejeda approved these changes Jul 29, 2021

View reviewed changes

OCA-git-bot added the bot is merging ⏳ label Jul 29, 2021

OCA-git-bot merged commit ccaeb38 into OCA:14.0 Jul 29, 2021

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Jul 29, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[14.0] [MIG] rma module #189

[14.0] [MIG] rma module #189

chafique-delli commented Dec 7, 2020

OCA-git-bot commented Dec 7, 2020

chafique-delli commented Dec 11, 2020

sebastienbeau commented Dec 19, 2020

pedrobaeza commented Dec 22, 2020

chafique-delli commented Jan 29, 2021

pedrobaeza commented Jan 29, 2021

chafique-delli commented Jan 29, 2021

This comment has been minimized.

ernestotejeda left a comment

ernestotejeda Apr 6, 2021

chafique-delli May 2, 2021

kos94ok-3D May 19, 2021

ernestotejeda left a comment

ernestotejeda left a comment

chienandalu commented Apr 29, 2021

florian-dacosta commented Jun 21, 2021

pedrobaeza commented Jun 21, 2021

chienandalu commented Jun 29, 2021

florian-dacosta commented Jul 26, 2021

pedrobaeza commented Jul 26, 2021

ernestotejeda left a comment

ernestotejeda Jul 27, 2021

ernestotejeda left a comment

ernestotejeda left a comment

ernestotejeda left a comment

ernestotejeda commented Jul 28, 2021

florian-dacosta commented Jul 29, 2021

ernestotejeda left a comment

pedrobaeza commented Jul 29, 2021

OCA-git-bot commented Jul 29, 2021

OCA-git-bot commented Jul 29, 2021

[14.0] [MIG] rma module #189

[14.0] [MIG] rma module #189

Conversation

chafique-delli commented Dec 7, 2020

OCA-git-bot commented Dec 7, 2020

chafique-delli commented Dec 11, 2020

sebastienbeau commented Dec 19, 2020

pedrobaeza commented Dec 22, 2020

chafique-delli commented Jan 29, 2021

pedrobaeza commented Jan 29, 2021

chafique-delli commented Jan 29, 2021

This comment has been minimized.

ernestotejeda left a comment

Choose a reason for hiding this comment

ernestotejeda Apr 6, 2021

Choose a reason for hiding this comment

chafique-delli May 2, 2021

Choose a reason for hiding this comment

kos94ok-3D May 19, 2021

Choose a reason for hiding this comment

ernestotejeda left a comment

Choose a reason for hiding this comment

ernestotejeda left a comment

Choose a reason for hiding this comment

chienandalu commented Apr 29, 2021

florian-dacosta commented Jun 21, 2021

pedrobaeza commented Jun 21, 2021

chienandalu commented Jun 29, 2021

florian-dacosta commented Jul 26, 2021

pedrobaeza commented Jul 26, 2021

ernestotejeda left a comment

Choose a reason for hiding this comment

ernestotejeda Jul 27, 2021

Choose a reason for hiding this comment

ernestotejeda left a comment

Choose a reason for hiding this comment

ernestotejeda left a comment

Choose a reason for hiding this comment

ernestotejeda left a comment

Choose a reason for hiding this comment

ernestotejeda commented Jul 28, 2021

florian-dacosta commented Jul 29, 2021

ernestotejeda left a comment

Choose a reason for hiding this comment

pedrobaeza commented Jul 29, 2021

OCA-git-bot commented Jul 29, 2021

OCA-git-bot commented Jul 29, 2021