Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][MIG] rma_sale: Migration to 15.0 #309

Merged
merged 75 commits into from
Oct 1, 2022
Merged

[15.0][MIG] rma_sale: Migration to 15.0 #309

merged 75 commits into from
Oct 1, 2022

Conversation

Alex-Vining
Copy link
Contributor

First pull request. I also want to update rma_sale_mrp after this as well assuming there are no issues.

Ernesto Tejeda and others added 30 commits September 20, 2022 08:16
[UPD] Update rma_sale.pot

[ADD] icon.png
rma_sale 12.0.1.0.1

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: rma-12.0/rma-12.0-rma_sale
Translate-URL: https://translation.odoo-community.org/projects/rma-12-0/rma-12-0-rma_sale/
[FIX] rma: views permissions

Regular users don't have permissions to rma models, so we should avoid
loading views that lead to permission errors.

TT24986

rma_sale 12.0.1.1.0

[FIX] rma_sale: portal permissions

Some operations need to be sudoed to be reachable by the portal user

[UPD] Update rma_sale.pot

rma_sale 12.0.1.1.1

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: rma-12.0/rma-12.0-rma_sale
Translate-URL: https://translation.odoo-community.org/projects/rma-12-0/rma-12-0-rma_sale/

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: rma-12.0/rma-12.0-rma_sale
Translate-URL: https://translation.odoo-community.org/projects/rma-12-0/rma-12-0-rma_sale/

[IMP] rma: teams flow

- If no RMA Team is set, we'll assign a default one to the new RMA.
- A sequence is now used to search for the top team and assign it.
- No default user is assigned when it's not in the context (i.e. portal
rmas).

[UPD] Update rma_sale.pot

rma_sale 12.0.1.2.0

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: rma-12.0/rma-12.0-rma_sale
Translate-URL: https://translation.odoo-community.org/projects/rma-12-0/rma-12-0-rma_sale/
- Fix thrown error when trying to download a picking from the portal.
- Add the hook method to prepare RMA values ​​from the return pick wizard.
- Add the access rule for portal users.
- Show the portal 'Request RMAs' button on the sales page only to users
related to the sales order.

[UPD] Update rma_sale.pot

rma_sale 12.0.1.3.0

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: rma-12.0/rma-12.0-rma_sale
Translate-URL: https://translation.odoo-community.org/projects/rma-12-0/rma-12-0-rma_sale/
Currently translated at 81.5% (44 of 54 strings)

Translation: rma-12.0/rma-12.0-rma_sale
Translate-URL: https://translation.odoo-community.org/projects/rma-12-0/rma-12-0-rma_sale/es/
- Now it's possible to open several RMAs in a sale order from the portal
- A new comment button has been added to allow the portal user to enter
relevant information like serial numbers o issue description.
- If the requested operation isn't set no RMA will be opened
- The RMA product qty is now a numeric control with limits according to
the qty available to return

[FIX] rma,rma_sale: fix linter errors

[UPD] Update rma_sale.pot

rma_sale 12.0.1.4.0

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: rma-12.0/rma-12.0-rma_sale
Translate-URL: https://translation.odoo-community.org/projects/rma-12-0/rma-12-0-rma_sale/
- Proper dependency is `sale_stock`, not `sale`, as we are using some fields added
  by this module.
- Propagate salesman from sales order when available.

TT25525

rma_sale 12.0.1.4.1
[FIX+IMP] rma: usability

* IMP - Now the description will be an html son we can show rich styles
in the customers report.
* FIX - On locked sale orders it was need to unlock them to be able to open an RMA.
* IMP - Make the description label visible in the backend form so the
user can easily spot it.
* IMP - Added date and deadline filters.
* IMP - Added pending RMAs filter.
* IMP - Added late RMAs filter.
* IMP - Added danger decoration in tree view

rma_sale 12.0.1.5.0

Translated using Weblate (Spanish)

Currently translated at 100.0% (62 of 62 strings)

Translation: rma-12.0/rma-12.0-rma_sale
Translate-URL: https://translation.odoo-community.org/projects/rma-12-0/rma-12-0-rma_sale/es/
Fine-tune of 9a25d6, as for one record, the domain is not applied, but the list is
shown.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: rma-13.0/rma-13.0-rma_sale
Translate-URL: https://translation.odoo-community.org/projects/rma-13-0/rma-13-0-rma_sale/
Currently translated at 77.8% (49 of 63 strings)

Translation: rma-13.0/rma-13.0-rma_sale
Translate-URL: https://translation.odoo-community.org/projects/rma-13-0/rma-13-0-rma_sale/ro/
Currently translated at 61.9% (39 of 63 strings)

Translation: rma-13.0/rma-13.0-rma_sale
Translate-URL: https://translation.odoo-community.org/projects/rma-13-0/rma-13-0-rma_sale/nl/
Currently translated at 90.4% (57 of 63 strings)

Translation: rma-13.0/rma-13.0-rma_sale
Translate-URL: https://translation.odoo-community.org/projects/rma-13-0/rma-13-0-rma_sale/ro/
Currently translated at 100.0% (63 of 63 strings)

Translation: rma-13.0/rma-13.0-rma_sale
Translate-URL: https://translation.odoo-community.org/projects/rma-13-0/rma-13-0-rma_sale/ro/
If there are several stock moves with the same product in the picking we
won't be able to make the RMA
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: rma-13.0/rma-13.0-rma_sale
Translate-URL: https://translation.odoo-community.org/projects/rma-13-0/rma-13-0-rma_sale/
When a sale line has a phantom product (mrp kits) the RMA would not be
possible as the wizard couldn't pair the components moves with the
product in the line. With this approach, we can at least return the
spare components of the original kit line.

We also need some hooks to intervine in the main methods, like in
invoicing.
@oca-clabot
Copy link

Hey @Alex-Vining, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: https://odoo-community.org/page/cla
Here is a list of the users:

Appreciation of efforts,
OCA CLAbot

@victoralmau
Copy link
Member

Please, cherry-pick 53666da and 8c423ee

@Alex-Vining
Copy link
Contributor Author

Please, cherry-pick 53666da and 8c423ee

Done!

@victoralmau
Copy link
Member

Please, cherry-pick 53666da and 8c423ee

Done!

Thanks, can you add them in the correct order (before the migration to 15)?

@Alex-Vining
Copy link
Contributor Author

Alex-Vining commented Sep 21, 2022

Please, cherry-pick 53666da and 8c423ee

Done!

Thanks, can you add them in the correct order (before the migration to 15)?

I think everything should be in order now. I'll keep this in mind for any future PRs.

Copy link
Member

@victoralmau victoralmau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and functional review OK.

It will also be necessary to apply the change #313 when merged.

Ping @chienandalu

Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pedrobaeza pedrobaeza changed the title 15.0 mig rma sale [15.0][MIG] rma_sale: Migration to 15.0 Sep 26, 2022
@pedrobaeza
Copy link
Member

/ocabot merge nobump
/ocabot migration rma_sale

@dreispt
Copy link
Member

dreispt commented Oct 1, 2022

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 15.0-ocabot-merge-pr-309-by-dreispt-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit a38996f into OCA:15.0 Oct 1, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 4fd9a1d. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza
Copy link
Member

/ocabot migration rma_sale

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Oct 1, 2022
@OCA-git-bot OCA-git-bot mentioned this pull request Oct 1, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.