[ADD] Add sale order lot selection #140

hurrinico · 2015-04-20T15:01:04Z

This Module Allows you to select on sale order the production lot that will be delivered

pedrobaeza · 2015-04-20T16:47:43Z

sale_order_lot_selection/README.rst

+Sale Order Lot Selection
+========================
+
+This Module Allow you to select on sale order the production lot that will be delivered


s/Allow/allows

pedrobaeza · 2015-04-20T16:50:34Z

Please put an specific icon (and smaller) for the module, to not confuse with other functionality.

About functionality itself, I miss:

Check that the selected lot has stock available.
Reserve stock when confirming or saving the order.

tafaRU · 2015-04-21T08:22:38Z

sale_order_lot_selection/__openerp__.py

+    'name': 'Sale Order Lot Selection',
+    'version': '1.0',
+    'category': 'Sales Management',
+    'author': "Agile Business Group",


Please add OCA as author

coveralls · 2015-04-22T02:42:47Z

Coverage decreased (-0.11%) to 80.13% when pulling ae02f1f on hurrinico:add_sale_order_lot_selection into a9ed64c on OCA:8.0.

hurrinico · 2015-04-22T10:56:09Z

Hi @pedrobaeza in my last commit i've made some changings.
Now i reserve lot on sale order confirm, i'm thinking on how to check lot's availability on sale order but it's quite difficult; you have some suggestion about it?
Thank you in advance

pedrobaeza · 2015-04-24T00:14:43Z

Why don't you reserve instead quants (with a many2many) in the same manner that Odoo works? That way, you only need to lock that quants. By standard, you can't do that, but you can use same mechanism than this: https://github.com/odoomrp/odoomrp-wip/blob/8.0/mrp_lock_lot/models/stock_quant.py to forbid to use that quants.

coveralls · 2015-04-28T10:26:39Z

Coverage increased (+2.96%) to 83.2% when pulling ec6f8f1 on hurrinico:add_sale_order_lot_selection into a9ed64c on OCA:8.0.

Viggor · 2015-07-02T18:33:13Z

Have you done a similar thing for mrp like #176 because we have done a similar feature for the sale #175 and stock #177.

copy

pedrobaeza · 2015-07-07T14:13:53Z

@hurrinico, please check the PR against your branch and move this to merge the module.

[IMP] better lot names in tests

hurrinico · 2015-07-30T16:47:38Z

@pedrobaeza @eLBati @Viggor i've made some changes to tests and now travis turns green

pedrobaeza · 2015-08-01T19:03:10Z

sale_order_lot_selection/model/procurement.py

+from openerp import fields, models, api
+
+
+class procurement_order(models.Model):


Please use CamelCase for class names

pedrobaeza · 2015-08-01T19:06:29Z

I also wonder if we should restrict the lot selection to the current available lots. If not, we should note in the README that the lot selection doesn't correspond with available lots in stock (it's only a priority), but I'm not sure that in this case, the module will be useful.

eLBati · 2015-08-03T18:43:39Z

Afaik, the module prevents to use unavailable lots.
I suggest to add a test for the failing assignment
On 1 Aug 2015 21:06, "Pedro M. Baeza" notifications@github.com wrote:

I also wonder if we should restrict the lot selection to the current
available lots. If not, we should note in the README that the lot selection
doesn't correspond with available lots in stock (it's only a priority), but
I'm not sure that in this case, the module will be useful.

—
Reply to this email directly or view it on GitHub
#140 (comment).

pedrobaeza · 2015-08-05T21:32:59Z

Indeed there's a warning programmed in an onchange, but it has 2 problems:

The warning is not preventing to select that lot.
You have to click on each lot to see which one is available, so it can be very tedious and not valid for a product with lots of serial numbers.

I suggest you to pre-calculate in a many2many field the available lots using quants, calling the method for getting the preferred domain and mapping the lots of these quants.

hurrinico · 2015-08-11T11:03:12Z

@pedrobaeza I've added a test case in order to dimostrate that if a lot on a sale order is already restricted, you can't confirm the order.

pedrobaeza · 2015-08-11T11:10:43Z

Yeah, I know, but my remark is about the usability. Can you read it again?

hurrinico · 2015-08-11T13:18:46Z

Ok @pedrobaeza we have understand the problem, and we agree with you.
Have you some idea about the fix? (this link doesn't work anymore https://github.com/odoomrp/odoomrp-wip/blob/8.0/mrp_lock_lot/models/stock_quant.py )
I was thinking about a new module that add a computed fields (boolean) to identify an available's lot?

pedrobaeza · 2015-08-11T14:07:51Z

The idea is to have a many2many computed field available lots in the sale.order.line, that depends on the warehouse, product and the quantity. This field is calculated calling the self.env['stock.quant'].quants_get_prefered_domain with the corresponding arguments, and applying that domain to make a search. Then, make a mapped function to retrieve the lots associated (this doesn't remove duplicates).

hurrinico · 2015-08-12T16:29:48Z

Hi @pedrobaeza , we have find this solution; we have replaced the onchange on lot_id with an override to the method "product_id_change_with_wh" where we have called (as you suggest) quants_get_prefered_domain and extended the domain. Could be this a solution?

hurrinico · 2015-08-17T13:34:31Z

@eLBati you are right!! i have made the requested changes.

hurrinico · 2015-08-26T09:19:27Z

@eLBati i've fixed the indentation

eLBati · 2015-08-26T10:47:43Z

Tried on runbot:

install module
create new SO
add a new line, selecting 'Ice Cream' product
go to lot field and click on arrow

get

Traceback (most recent call last):
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3113776-140-40501d/openerp/http.py", line 537, in _handle_exception
    return super(JsonRequest, self)._handle_exception(exception)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3113776-140-40501d/openerp/http.py", line 574, in dispatch
    result = self._call_function(**self.params)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3113776-140-40501d/openerp/http.py", line 310, in _call_function
    return checked_call(self.db, *args, **kwargs)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3113776-140-40501d/openerp/service/model.py", line 113, in wrapper
    return f(dbname, *args, **kwargs)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3113776-140-40501d/openerp/http.py", line 307, in checked_call
    return self.endpoint(*a, **kw)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3113776-140-40501d/openerp/http.py", line 803, in __call__
    return self.method(*args, **kw)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3113776-140-40501d/openerp/http.py", line 403, in response_wrap
    response = f(*args, **kw)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3113776-140-40501d/openerp/addons/web/controllers/main.py", line 944, in call_kw
    return self._call_kw(model, method, args, kwargs)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3113776-140-40501d/openerp/addons/web/controllers/main.py", line 936, in _call_kw
    return getattr(request.registry.get(model), method)(request.cr, request.uid, *args, **kwargs)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3113776-140-40501d/openerp/api.py", line 241, in wrapper
    return old_api(self, *args, **kwargs)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3113776-140-40501d/openerp/api.py", line 336, in old_api
    result = method(recs, *args, **kwargs)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3113776-140-40501d/openerp/models.py", line 1725, in name_search
    return self._name_search(name, args, operator, limit=limit)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3113776-140-40501d/openerp/api.py", line 239, in wrapper
    return new_api(self, *args, **kwargs)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3113776-140-40501d/openerp/api.py", line 463, in new_api
    result = method(self._model, cr, uid, *args, **kwargs)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3113776-140-40501d/openerp/models.py", line 1737, in _name_search
    ids = self._search(cr, user, args, limit=limit, context=context, access_rights_uid=access_rights_uid)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3113776-140-40501d/openerp/api.py", line 241, in wrapper
    return old_api(self, *args, **kwargs)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3113776-140-40501d/openerp/models.py", line 4654, in _search
    query = self._where_calc(cr, user, args, context=context)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3113776-140-40501d/openerp/api.py", line 241, in wrapper
    return old_api(self, *args, **kwargs)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3113776-140-40501d/openerp/models.py", line 4465, in _where_calc
    e = expression.expression(cr, user, domain, self, context)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3113776-140-40501d/openerp/osv/expression.py", line 646, in __init__
    self.parse(cr, uid, context=context)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3113776-140-40501d/openerp/osv/expression.py", line 749, in parse
    self.stack = [ExtendedLeaf(leaf, self.root_model) for leaf in self.expression]
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3113776-140-40501d/openerp/osv/expression.py", line 532, in __init__
    self.check_leaf(internal)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3113776-140-40501d/openerp/osv/expression.py", line 588, in check_leaf
    raise ValueError("Invalid leaf %s" % str(self.leaf))
ValueError: Invalid leaf id

hurrinico · 2015-08-26T15:03:32Z

@eLBati i've fixed with my last commit

eLBati · 2015-08-28T17:43:58Z

I'm closing this in favor of #202 (I fixed last issues and squashed some commits)

Recent updates, which should fix the remaining problems, are
eLBati@57eb332
eLBati@e671c1d

[FIX] Add sale order dolder

c0f8ba6

pedrobaeza reviewed Apr 20, 2015
View reviewed changes

tafaRU reviewed Apr 21, 2015
View reviewed changes

tafaRU added the needs fixing label Apr 21, 2015

[FIX] adds _run_move_create and some other fixes

ae02f1f

hurrinico changed the title ~~[FIX] Add sale order dolder~~ [FIX] Add sale order lot selection Apr 21, 2015

[FIX] add restriction on sale confirm changed icon and minor fix

adbde3a

[FIX] Fix product_id on test

a4c7a37

[FIX] Fix product on test

ec6f8f1

hurrinico added 2 commits April 28, 2015 16:38

[FIX] Add check on sale order

d40281b

[FIX] add _run override

f2d198a

hurrinico changed the title ~~[FIX] Add sale order lot selection~~ [ADD] Add sale order lot selection Apr 29, 2015

[FIX] adding feature and fix contributors

754e283

pedrobaeza mentioned this pull request Jul 2, 2015

8.0 sale prodlot #175

Closed

This was referenced Jul 2, 2015

8.0 sale prodlot mrp #176

Closed

8.0 sale stock prodlot #177

Closed

Viggor pushed a commit to akretion/sale-workflow that referenced this pull request Jul 3, 2015

Remove features already present in OCA#140

e482604

Viggor pushed a commit to akretion/sale-workflow that referenced this pull request Jul 3, 2015

Update to remove features already present in OCA#140

1cddacb

Viggor mentioned this pull request Jul 3, 2015

8.0 sale prodlot #179

Closed

Add transmition of lot_id from move to procurement and delete lot_id on

a1cfb49

copy

hurrinico added 2 commits July 30, 2015 11:48

Merge pull request #6 from eLBati/add_sale_order_lot_selection

afc1a1b

[IMP] better lot names in tests

[FIX] Fixed Tests adding a stock_picking_in to create quants

d8561d1

Nicola Malcontenti added 2 commits July 31, 2015 08:57

[FIX] Use product_14 instead of product_11

1104eed

[FIX] Add test's flow step

c197f08

pedrobaeza reviewed Aug 1, 2015
View reviewed changes

Nicola Malcontenti added 2 commits August 11, 2015 18:07

[FIX] Add check on lot reservation in test

83ce14d

[FIX] Add check on quants

6b176df

[FIX] change data in quant search

5b5e353

[FIX] Fixed tab

40501de

[FIX] Add check on lots list

c401330

eLBati mentioned this pull request Aug 28, 2015

Add sale order lot selection #202

Merged

eLBati closed this Aug 28, 2015

yvaucher removed the needs fixing label Aug 28, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ADD] Add sale order lot selection #140

[ADD] Add sale order lot selection #140

hurrinico commented Apr 20, 2015

pedrobaeza Apr 20, 2015

pedrobaeza commented Apr 20, 2015

tafaRU Apr 21, 2015

coveralls commented Apr 22, 2015

hurrinico commented Apr 22, 2015

pedrobaeza commented Apr 24, 2015

coveralls commented Apr 28, 2015

Viggor commented Jul 2, 2015

pedrobaeza commented Jul 7, 2015

hurrinico commented Jul 30, 2015

pedrobaeza Aug 1, 2015

pedrobaeza commented Aug 1, 2015

eLBati commented Aug 3, 2015

pedrobaeza commented Aug 5, 2015

hurrinico commented Aug 11, 2015

pedrobaeza commented Aug 11, 2015

hurrinico commented Aug 11, 2015

pedrobaeza commented Aug 11, 2015

hurrinico commented Aug 12, 2015

hurrinico commented Aug 17, 2015

hurrinico commented Aug 26, 2015

eLBati commented Aug 26, 2015

hurrinico commented Aug 26, 2015

eLBati commented Aug 28, 2015

		from openerp import fields, models, api


		class procurement_order(models.Model):

[ADD] Add sale order lot selection #140

[ADD] Add sale order lot selection #140

Conversation

hurrinico commented Apr 20, 2015

pedrobaeza Apr 20, 2015

Choose a reason for hiding this comment

pedrobaeza commented Apr 20, 2015

tafaRU Apr 21, 2015

Choose a reason for hiding this comment

coveralls commented Apr 22, 2015

hurrinico commented Apr 22, 2015

pedrobaeza commented Apr 24, 2015

coveralls commented Apr 28, 2015

Viggor commented Jul 2, 2015

pedrobaeza commented Jul 7, 2015

hurrinico commented Jul 30, 2015

pedrobaeza Aug 1, 2015

Choose a reason for hiding this comment

pedrobaeza commented Aug 1, 2015

eLBati commented Aug 3, 2015

pedrobaeza commented Aug 5, 2015

hurrinico commented Aug 11, 2015

pedrobaeza commented Aug 11, 2015

hurrinico commented Aug 11, 2015

pedrobaeza commented Aug 11, 2015

hurrinico commented Aug 12, 2015

hurrinico commented Aug 17, 2015

hurrinico commented Aug 26, 2015

eLBati commented Aug 26, 2015

hurrinico commented Aug 26, 2015

eLBati commented Aug 28, 2015