[15.0][MIG] sale_automatic_workflow_payment_mode #2005

flachica · 2022-05-06T14:00:38Z

Dependency below, please review

OCA/connector-prestashop#151
#2005
OCA/connector-ecommerce#70
OCA/connector#428
OCA/server-tools#2334
OCA/product-attribute#1070
OCA/product-attribute#1069

jacekmichalski

LGTM

flachica · 2022-08-13T11:45:02Z

@jacekmichalski thanks for your review. I just uploaded changes because there were errors in the tests.

I encourage you to review the PR list above to fully migrate connector_prestashop

OCA-git-bot · 2022-09-08T09:59:45Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

flachica · 2022-09-22T06:29:24Z

In order to finish migrating the Prestashop connector I need this PR to be merged. It has two approvals. Any PSC check it out? /cc @HaraldPanten @rafaelbn

rafaelbn · 2022-09-30T22:21:04Z

Thank @flachica !

Could you please take care on this #1795 , maybe you should take it for this PR too 😄

@leemannd @hailangvn @gurneyalex is this PR of you interest?

Thank you again!

rafaelbn · 2022-09-30T22:21:31Z

/ocabot migration sale_automatic_workflow_payment_mode

dreispt · 2022-11-15T15:06:10Z

/ocabot merge nobump

OCA-git-bot · 2022-11-15T15:06:36Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 15.0-ocabot-merge-pr-2005-by-dreispt-bump-nobump, awaiting test results.

Signed-off-by dreispt

OCA-git-bot · 2022-11-15T15:15:46Z

@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-2005-by-dreispt-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

danielduqma · 2022-12-21T15:51:03Z

@flachica could you please rebase to make runboat launch again? Thanks!

[ADD] sale_automatic_workflow_payment_mode

Currently translated at 90.0% (9 of 10 strings) Translation: sale-workflow-12.0/sale-workflow-12.0-sale_automatic_workflow_payment_mode Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_automatic_workflow_payment_mode/es/

Use Queue Jobs to process the Sales Automatic Workflow actions. The default behavior of the automatic workflow module is to use a scheduled action that searches all the record that need a workflow action and sequentially process all of them. It can hit some limits when the number of records is too high. This module keeps the scheduled action to search the records, but instead of directly executing the actions (confirm a sales order, create invoices for a sales order, validate invoices, ...), it creates one job per operation to do. It uses an identity key on the jobs so it will not create the same job for the same record and same operation twice. ~ I needed to extract methods in `sale_automatic_workflow` in order to be able to execute them as jobs. A new decorator "job_auto_delay" (to eventually move in queue_job) makes these methods automatically delayed when called.

Currently translated at 30.0% (3 of 10 strings) Translation: sale-workflow-12.0/sale-workflow-12.0-sale_automatic_workflow_payment_mode Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_automatic_workflow_payment_mode/sl/

… increase coverage

Parts of `sale_automatic_workflow_payment_mode` have been merged into `sale_automatic_workflow`. But these parts have been not removed from `sale_automatic_workflow_payment_mode`. This PR clean both modules after this merge. Originals PR of the merge: OCA#1789

…ng SO's workflow if payment.mode hasn't one set It seems this feature was added during the 14.0 migration PR, here: 111bb97 But it wasn't like this before, and IMO it was ok.

- Move register_payment option from sale_automatic_workflow_payment_mode to sale_automatic_workflow. - Add _register_payments function in sale_automatic_workflow. TT31208

...payment when no fixed journal and remove sale_workflow_process

* Fix tests errors

flachica · 2022-12-21T18:24:38Z

Done @danielduqma

danielduqma · 2022-12-22T07:01:36Z

Thanks! @dreispt could you please run merge command? Now all checks have passed and it will work.

Regards

dreispt · 2022-12-30T15:49:42Z

/ocabot merge nobump

OCA-git-bot · 2022-12-30T15:49:47Z

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 15.0-ocabot-merge-pr-2005-by-dreispt-bump-nobump, awaiting test results.

Signed-off-by dreispt

OCA-git-bot · 2022-12-30T16:13:39Z

It looks like something changed on 15.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 15.0-ocabot-merge-pr-2005-by-dreispt-bump-nobump, awaiting test results.

OCA-git-bot · 2022-12-30T16:36:15Z

Congratulations, your PR was merged at 51bbdab. Thanks a lot for contributing to OCA. ❤️

Signed-off-by dreispt

flachica mentioned this pull request May 6, 2022

Migration to version 15.0 #1741

Open

jacekmichalski approved these changes Aug 12, 2022

View reviewed changes

flachica force-pushed the 15.0-mig-sale_automatic_workflow_payment_mode branch 2 times, most recently from 6699533 to 051aff1 Compare August 13, 2022 11:36

flachica force-pushed the 15.0-mig-sale_automatic_workflow_payment_mode branch from 051aff1 to 6bd541f Compare August 17, 2022 10:35

xAdrianC-Kernet approved these changes Sep 8, 2022

View reviewed changes

OCA-git-bot added approved ready to merge labels Sep 8, 2022

flachica mentioned this pull request Sep 22, 2022

[15.0][MIG] connector_base_product: Migration to 15.0 OCA/connector#428

Merged

juliocabrerizo approved these changes Sep 28, 2022

View reviewed changes

OCA-git-bot added this to the 15.0 milestone Sep 30, 2022

flachica force-pushed the 15.0-mig-sale_automatic_workflow_payment_mode branch from 6bd541f to 50374ab Compare October 18, 2022 09:34

OCA-git-bot added the bot is merging ⏳ label Nov 15, 2022

OCA-git-bot added a commit that referenced this pull request Nov 15, 2022

Merge PR #2005 into 15.0

a5dfd55

Signed-off-by dreispt

OCA-git-bot removed the bot is merging ⏳ label Nov 15, 2022

[WIP][9.0] Add sale_automatic_workflow_payment_mode (OCA#297)

9911d58

[ADD] sale_automatic_workflow_payment_mode

Galoperd and others added 17 commits December 21, 2022 19:23

[FIX] pep8 and pylint

60c64ff

[MIG] sale_automatic_workflow_payment_mode from 12.0 to 13.0

0c4b39a

[MIG] sale_automatic_workflow_payment_mode: run pre-commit

f500831

[IMP] sale_automatic_workflow_payment_mode: black, isort, prettier

f25acfd

[MIG] sale_automatic_workflow_payment_mode: Migration to 14.0

a644172

[IMP] sale_automatic_workflow_payment_mode: sync SO workflow process,…

107bf26

… increase coverage

[FIX] sale_automatic_workflow_payment_mode: avoid overwritting/removi…

7479e1a

…ng SO's workflow if payment.mode hasn't one set It seems this feature was added during the 14.0 migration PR, here: 111bb97 But it wasn't like this before, and IMO it was ok.

sale_automatic_workflow_payment_mode 14.0.1.0.1

db6080c

[IMP] sale_automatic_workflow:

d270fb1

- Move register_payment option from sale_automatic_workflow_payment_mode to sale_automatic_workflow. - Add _register_payments function in sale_automatic_workflow. TT31208

[FIX] sale_automatic_workflow_mode: missing super()

d3ecaa9

[FIX] sale_automatic_workflow_payment_mode: not register...

02b790c

...payment when no fixed journal and remove sale_workflow_process

[IMP] sale_automatic_workflow_payment_mode: black, isort

47af99b

[MIG] sale_automatic_workflow_payment_mode 15.0 &

f9cb74e

* Fix tests errors

flachica force-pushed the 15.0-mig-sale_automatic_workflow_payment_mode branch from 50374ab to f9cb74e Compare December 21, 2022 18:24

OCA-git-bot added the bot is merging ⏳ label Dec 30, 2022

OCA-git-bot added a commit that referenced this pull request Dec 30, 2022

Merge PR #2005 into 15.0

53cc080

Signed-off-by dreispt

OCA-git-bot merged commit 9008e32 into OCA:15.0 Dec 30, 2022

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Dec 30, 2022

pilarvargas-tecnativa pushed a commit to Tecnativa/sale-workflow that referenced this pull request Feb 7, 2023

Merge PR OCA#2005 into 15.0

ddbe84b

Signed-off-by dreispt

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[15.0][MIG] sale_automatic_workflow_payment_mode #2005

[15.0][MIG] sale_automatic_workflow_payment_mode #2005

flachica commented May 6, 2022 •

edited

Loading

jacekmichalski left a comment

flachica commented Aug 13, 2022

OCA-git-bot commented Sep 8, 2022

flachica commented Sep 22, 2022

rafaelbn commented Sep 30, 2022

rafaelbn commented Sep 30, 2022

dreispt commented Nov 15, 2022

OCA-git-bot commented Nov 15, 2022

OCA-git-bot commented Nov 15, 2022

danielduqma commented Dec 21, 2022

flachica commented Dec 21, 2022

danielduqma commented Dec 22, 2022

dreispt commented Dec 30, 2022

OCA-git-bot commented Dec 30, 2022

OCA-git-bot commented Dec 30, 2022

OCA-git-bot commented Dec 30, 2022

[15.0][MIG] sale_automatic_workflow_payment_mode #2005

[15.0][MIG] sale_automatic_workflow_payment_mode #2005

Conversation

flachica commented May 6, 2022 • edited Loading

jacekmichalski left a comment

Choose a reason for hiding this comment

flachica commented Aug 13, 2022

OCA-git-bot commented Sep 8, 2022

flachica commented Sep 22, 2022

rafaelbn commented Sep 30, 2022

rafaelbn commented Sep 30, 2022

dreispt commented Nov 15, 2022

OCA-git-bot commented Nov 15, 2022

OCA-git-bot commented Nov 15, 2022

danielduqma commented Dec 21, 2022

flachica commented Dec 21, 2022

danielduqma commented Dec 22, 2022

dreispt commented Dec 30, 2022

OCA-git-bot commented Dec 30, 2022

OCA-git-bot commented Dec 30, 2022

OCA-git-bot commented Dec 30, 2022

flachica commented May 6, 2022 •

edited

Loading