Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] sale_order_product_recommendation #2454

Conversation

SoporteOperu
Copy link

No description provided.

yajo and others added 30 commits March 29, 2023 15:34
This wizard that you can see now in your quotations will let you add products quickly based on the customer's recent purchase history.
We can't limit results on read_group, because we can't set the same
criteria to order results, and thus the N groups populated might be
not the top ones looked for.
- When a SO is confirmed the button is still visible so the wizard can
be used to add or remove lines and products. The same restrictions that
exist editing the order manually apply to the wizard.
- Improve test declaration inherability
…ok products in recommendation wizard

BTW I fixed a bug that counted products in the active SO as delivered, when it was impossible in most cases. Fixed the test to reflect the new logic.

Co-Authored-By: Jairo Llopis <Yajo@users.noreply.github.com>
Add kanban + form for proper mobile usage.
…fied`

It's better to simply check the flag condition than to keep that field.
…t to product default one

Having a related field to default sale secondary UoM makes this recommendator to not fit
possible different secondary UoM to be used.

This commit fixes this behavior. A refactoring on the main module having a prepare
method hook has been needed.
…hanges

Previous code was not very resilient to possible extra adaptations or require
specific code to be added to the old hook `_trigger_so_line_onchanges`.

With this, we make sure all onchanges are executed thanks to the odoo.tests.Form
class.

We lose a bit of performance, but it's better than to have issues with data not
correctly synchronized.
For avoiding errors like accessing mail.tracking.value when changing values.
…ct.product model instead of product.template in wizard kanban view.

TT26749
…from listprice or from last sale order.

TT26727
…from listprice or from last sale order. Computed with ORM instead of sql queries

TT26727
… line with last_sale_order price unit from recommendation line

TT27183
…recommendation wizard always sort by times delivered desc (even if the sale order already has any line)
victoralmau and others added 16 commits March 29, 2023 15:34
…ivery_address

On delivery address we want to take into account just this field and not
the commercial_partner_id.

And fixed 1 term to make it impersonal.

cc @Tecnativa TT29597
…mber and backward months by settings

TT33165
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: sale-workflow-15.0/sale-workflow-15.0-sale_order_product_recommendation
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-sale_order_product_recommendation/
@rafaelbn rafaelbn added this to the 16.0 milestone Jun 27, 2023
@rafaelbn
Copy link
Member

Hello @SoporteOperu , thank you for this migration! 😄

Are you going to continue with it?

Ping @sergio-teruel @Juangomezzurita

@rafaelbn
Copy link
Member

/ocabot rebase

@OCA-git-bot
Copy link
Contributor

@rafaelbn The rebase process failed, because command git rebase origin/16.0 failed with output:

First, rewinding head to replay your work on top of it...
Applying: [UPD] Update sale_order_product_recommendation.pot
Using index info to reconstruct a base tree...
M	sale_order_product_recommendation/i18n/sale_order_product_recommendation.pot
Falling back to patching base and 3-way merge...
Auto-merging sale_order_product_recommendation/i18n/sale_order_product_recommendation.pot
No changes -- Patch already applied.
Applying: [UPD] README.rst
.git/rebase-apply/patch:22: trailing whitespace.
|badge1| |badge2| |badge3| |badge4| |badge5| 
warning: 1 line adds whitespace errors.
Using index info to reconstruct a base tree...
M	sale_order_product_recommendation/README.rst
M	sale_order_product_recommendation/static/description/index.html
Falling back to patching base and 3-way merge...
Auto-merging sale_order_product_recommendation/static/description/index.html
CONFLICT (content): Merge conflict in sale_order_product_recommendation/static/description/index.html
Auto-merging sale_order_product_recommendation/README.rst
CONFLICT (content): Merge conflict in sale_order_product_recommendation/README.rst
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch' to see the failed patch
Patch failed at 0002 [UPD] README.rst
Resolve all conflicts manually, mark them as resolved with
"git add/rm <conflicted_files>", then run "git rebase --continue".
You can instead skip this commit: run "git rebase --skip".
To abort and get back to the state before "git rebase", run "git rebase --abort".

@rafaelbn
Copy link
Member

Sorry this modules is already migrated in

https://github.com/OCA/sale-workflow/tree/16.0/sale_order_product_recommendation

I was lookging for sale_order_product_recommendation_product_sold_by_delivery_week

Thanks

@rafaelbn rafaelbn closed this Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.