-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[15.0][MIG] product_form_sale_link 2nd #2508
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently translated at 100.0% (2 of 2 strings) Translation: sale-workflow-12.0/sale-workflow-12.0-product_form_sale_link Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-product_form_sale_link/fr/
Currently translated at 100.0% (2 of 2 strings) Translation: sale-workflow-12.0/sale-workflow-12.0-product_form_sale_link Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-product_form_sale_link/ca/
Currently translated at 100.0% (2 of 2 strings) Translation: sale-workflow-12.0/sale-workflow-12.0-product_form_sale_link Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-product_form_sale_link/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-13.0/sale-workflow-13.0-product_form_sale_link Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-13-0/sale-workflow-13-0-product_form_sale_link/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-14.0/sale-workflow-14.0-product_form_sale_link Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-product_form_sale_link/
The button 'action_view_sales' is replaced in sale_stock, so it cannot be referenced.
The sales_count field is already used in odoo for another button, which calculates the sum of the quantity of that product for each sale line instead of the number of sale lines. Now, the number in the button show the correct number of sale lines.
/ocabot merge nobump |
This PR looks fantastic, let's merge it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up #2138
@pedrobaeza I do not understand why the other PR is not merging could you give it a try on this PR. (same hash as other PR)
Maybe there is something internally wrong with PR #2138 .