[16.0][MIG] sales_team_security: Migration to version 16.0 #2602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The previous PR was not incorrect. The translations suggestions are just improvements that can be done later, so you are not bringing too much extra value, and you are removing the authorship of the previous contributor, discouraging future contributions. If you want to "finish" the migration here, please respect the migration commit authorship, add the translation on top, and also squash administrative commits: https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests |
|
Thanks @pedrobaeza , I'll be more careful next time, now I'll do what you suggested and I'll fix it. |
Yadier-Tecnativa
force-pushed
the
16.0-mig-sales_team_security
branch
from
164cb06
to
43a71c0
Compare
|
I still don't see the commits from the other author. |
Yadier-Tecnativa
force-pushed
the
16.0-mig-sales_team_security
branch
2 times, most recently
from
04fe275
to
591e0a0
Compare
Done |
|
You are still not preserving the commit authorship. It's not enough with cherry-picking the commit. You have to replace it in your commit history. |
Yadier-Tecnativa
force-pushed
the
16.0-mig-sales_team_security
branch
5 times, most recently
from
ad19a2c
to
d5387c5
Compare
|
/ocabot migration sales_team_security |
============================== Security rules for sales teams ============================== This module sets different permissions levels for accessing sales and CRM records based on the sales team: customers, sales orders, leads, opportunities, phone calls and sales teams. It also handles the propagation of the sales team from commercial partners to the contacts, which standard doesn't make. Installation ============ At installation time, this module sets int all the contacts that have the sales team empty the sales team of the parent. If you have a lot of contacts, this operation can take a while. Usage ===== On the user configuration (Configuration > Users > Users), select in the *Sales Team* section the option "See only own team". Then, the documents mentioned before will be filtered out to have only those belonging to the teams the user belongs to. This is complementary to the Sales level access, but sometimes can be incoherent depending on the combination chosen. If you chose "See Own Leads" on _Sales_ section, marking on unmarking the sales team check will be irrelevant, because the most restricting level, which the sales one, will prevail. Known issues/Roadmap ==================== * This module is designed for supporting only sales part, so someone that has access to other Odoo parts (for example, an accountant), shouldn't have this new permission, or some access errors will be found when seeing invoices and other documents. A _sales_team_security_account_ bridge module can be done for fixing this case, but not in the case of for example warehouse.
Restrict contacts by code, removing the need of manually manipulating the existing record rules, that can also have some side effects.
- Standard procedure - Adapt partner view - Adapt tests
Translated using Weblate (Spanish) Currently translated at 100.0% (4 of 4 strings) Translation: sale-workflow-13.0/sale-workflow-13.0-sales_team_security Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-13-0/sale-workflow-13-0-sales_team_security/es/ Added translation using Weblate (Italian) Translated using Weblate (Italian) Currently translated at 100.0% (4 of 4 strings) Translation: sale-workflow-13.0/sale-workflow-13.0-sales_team_security Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-13-0/sale-workflow-13-0-sales_team_security/it/
…se is duplicated from sales_team view
…contacts + others - For avoiding access errors on this records that are related to sales flow - Sync salesman on parent change Co-Authored-By: Pedro M. Baeza <pedro.baeza@tecnativa.com>
A team manager wasn't able to access to their orders if the team was different from their team. Whole review has been done for the rest of the channel manager rules, and added some tests. Migration script included.
Steps to reproduce the problem: - Create a main contact. - Create a child contact of the main contact, selecting a salesperson. - Go to the main contact, and check the followers. Expected behavior: The main contact has the salesperson as follower. The same if editing the child contact, the salesperson is changed. Obtained result: No follower for the salesperson. That's because the `create` method is not intercepted to do the followers synchronization. TT39963
Currently translated at 75.0% (6 of 8 strings) Translation: sale-workflow-15.0/sale-workflow-15.0-sales_team_security Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-sales_team_security/it/
pedrobaeza
force-pushed
the
16.0-mig-sales_team_security
branch
from
d5387c5
to
b17f10c
Compare
pedrobaeza
approved these changes
Aug 8, 2023
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 6f9bd1b. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Tecnativa TT43248
Supersede for #2458