[16][ADD][sale_partner_pricelist] New field allowed pricelist in sale/customer to as… #2620
Conversation
oscarjarsa
force-pushed
the
15.0_add_new_fiel_allowed_pricelist
branch
22 times, most recently
from
de6ecc0
to
dd8776d
Compare
alan196
force-pushed
the
15.0_add_new_fiel_allowed_pricelist
branch
2 times, most recently
from
5ed09d9
to
24bd5d0
Compare
alan196
force-pushed
the
15.0_add_new_fiel_allowed_pricelist
branch
from
24bd5d0
to
6ee975c
Compare
|
Functional review |
|
Funtional review, everything looks working. |
|
|
||
| { | ||
| "name": "Sale Partner Pricelist", | ||
| "version": "16.0.1.0.0", |
There was a problem hiding this comment.
| class ResPartnerr(models.Model): | ||
| _inherit = "res.partner" | ||
|
|
||
| allowed_pricelist_ids = fields.Many2many( |
There was a problem hiding this comment.
I'm wondering if default values could come from a configuration on partner category to ease user day-to-day job ? Maybe in a ROADMAP ?
There was a problem hiding this comment.
I changed the behavior of the constraint, if the field is empty, it will allow all the pricelist.
With this change, we don't need to define a default value for this field
|
|
||
| @api.constrains("property_product_pricelist") | ||
| def _check_allowed_pricelist(self): | ||
| test_mode = self.env.registry.in_test_mode() or getattr( |
There was a problem hiding this comment.
I don't really like this kind of code. I'd prefer adding a configuration setting to enable the feature.
oscarjarsa
force-pushed
the
15.0_add_new_fiel_allowed_pricelist
branch
9 times, most recently
from
1696f8e
to
ede8b34
Compare
alan196
force-pushed
the
15.0_add_new_fiel_allowed_pricelist
branch
2 times, most recently
from
c55b093
to
6dbfdeb
Compare
|
@rafaelbn @rousseldenis I take in consideration your comments. I make some changes in the module and I think is ready to merge. Could you help me to review 🙏 |
…ricelist to customers and show only that pricelists in the sale order
alan196
force-pushed
the
15.0_add_new_fiel_allowed_pricelist
branch
from
6dbfdeb
to
c96ae1b
Compare
|
/ocabot merge nobump |
|
On my way to merge this fine PR! |
|
It looks like something changed on |
|
It looks like something changed on |
|
It looks like something changed on |
|
Congratulations, your PR was merged at c7a813f. Thanks a lot for contributing to OCA. ❤️ |
…sign multiple rates a client