[15.0][ADD] sale_deposit_deduction_option #2651
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saran440
force-pushed
the
15.0-add-sale_deposit_clear_option
branch
from
a7e5aa6
to
5a9d58c
Compare
sale_deposit_clear_option/wizard/sale_make_invoice_advance_views.xml
Outdated
Show resolved
Hide resolved
Saran440
changed the title
Saran440
force-pushed
the
15.0-add-sale_deposit_clear_option
branch
from
3201012
to
94c300c
Compare
|
@rousseldenis Thank you for your review. I change module name to |
| sale_orders = self.env["sale.order"].browse( | ||
| self._context.get("active_ids", []) | ||
| ) | ||
| self = self.with_context( |
There was a problem hiding this comment.
@Saran440 I don't like passing things to context if that can be avoided.
Here, you can override _create_invoice() as it returns the created move. Then, you can do the process you have written in account.move.create().
There was a problem hiding this comment.
@Saran440 Any news on this ?
There was a problem hiding this comment.
@rousseldenis Hi, sorry for late reply.
Because user can create invoice either proportional or not each time. (Wizard view)
I don't know how to do if no passed value in context.
it can overwrite function, but this module maybe can't use with other modules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This module add option for clear down payment with Proportional on Sale Order
reference: OCA/purchase-workflow#1939