Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.0] new module remove_odoo_enterprise #12

Merged
merged 9 commits into from
Sep 27, 2019
Merged

[12.0] new module remove_odoo_enterprise #12

merged 9 commits into from
Sep 27, 2019

Conversation

levkar
Copy link

@levkar levkar commented Dec 5, 2018

This is a new module with new name removing enterprise modules and settings.

Includes the functionality of res_config_settings_enterprise_remove module.

@levkar levkar mentioned this pull request Dec 5, 2018
Closed
@astirpe
Copy link
Member

astirpe commented Dec 7, 2018

Is it possible to preserve the commit history from res_config_settings_enterprise_remove ?

Brett Wood and others added 7 commits December 7, 2018 11:54
@lk-eska
[IMP] res_config_settings_enterprise_remove: Merge all enterprise mod…
c309440 
…ules into a single module.
@lk-eska
[IMP] res_config_settings_enterprise_remove: Refactor fields_view_get…
4eae652 
… to reduce amount of xpath queries.
@lk-eska
[IMP] res_config_settings_enterprise_remove: Refactor field removal t…
e180c9f 
…o reduce loops, complexity, and eliminate any risky xpath queries.
@mstuttgart @lk-eska
[MIG][10.0] Migrate 'res_config_settings_enterprise_remove' (#665)
6e40bb1 
* [MIG][10.0] Migrate 'res_config_settings_enterprise_remove'

* [FIX] Use inherit to override 'res.config.settings'.

* [FIX] Remove upgrade_radio widget and group title

* [FIX] Improviments in code to remove upgrade fields

* [NEW] Remove enterprise upgrade from 'project config settings'

* [FIX] Add xpath to remove upgrade fields from 'General Settings'
@oca-transbot @lk-eska
OCA Transbot updated translations from Transifex
7326167
@mstuttgart @lk-eska
[FIX] Remove upgrade button in Mass Mail Settings
fbf8a40
@astirpe @lk-eska
[11.0][MIG] res_config_settings_enterprise_remove: port to V11
4d96ccb
@oca-clabot
Copy link

Hey @levkar, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

Appreciation of efforts,
OCA CLAbot

@levkar
Copy link
Author

levkar commented Dec 7, 2018

commit history included. oca clabot started complaining again.

@levkar
Copy link
Author

levkar commented Dec 7, 2018

clabot is complaining about bret wood!

@pedrobaeza
Copy link
Member

@levkar we are handling this in OCA/oca-github-bot#28

@astirpe
Copy link
Member

astirpe commented Dec 10, 2018

Please fix the Travis error

@oca-clabot
Copy link

Hey @levkar, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

Appreciation of efforts,
OCA CLAbot

1 similar comment
@oca-clabot
Copy link

Hey @levkar, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

Appreciation of efforts,
OCA CLAbot

@oca-clabot
Copy link

Hey @levkar, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

Appreciation of efforts,
OCA CLAbot

@astirpe astirpe mentioned this pull request Mar 26, 2019
Merged
@astirpe
Copy link
Member

astirpe commented Mar 26, 2019

FYI: OCA/multi-company#119 (comment)

@emagdalenaC2i
Copy link

@levkar and @astirpe This PR superseed #7 and rename the module?

@astirpe
Copy link
Member

astirpe commented Jun 3, 2019

@emagdalenaC2i yes, correct.

@emagdalenaC2i emagdalenaC2i mentioned this pull request Jun 3, 2019
Closed
2 tasks
Martronic-SA
Martronic-SA approved these changes Sep 10, 2019
View reviewed changes
Copy link

@Martronic-SA Martronic-SA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working as expected.

sergiocorato
sergiocorato approved these changes Sep 23, 2019
View reviewed changes
Copy link

@sergiocorato sergiocorato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MiquelRForgeFlow MiquelRForgeFlow mentioned this pull request Sep 23, 2019
Merged
@mileo
Copy link
Member

mileo commented Sep 25, 2019

/ocabot merge

@OCA-git-bot
Copy link
Contributor

Sorry @mileo you are not allowed to merge.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

@astirpe
Copy link
Member

astirpe commented Sep 27, 2019

@pedrobaeza there are 6 approvals here. Can we merge this PR?

@pedrobaeza
Copy link
Member

/ocabot merge

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 12.0-ocabot-merge-pr-12-by-pedrobaeza-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Sep 27, 2019
@OCA-git-bot
Merge PR #12 into 12.0
320f885 
Signed-off-by pedrobaeza
@OCA-git-bot OCA-git-bot merged commit 4374897 into OCA:12.0 Sep 27, 2019
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at d6cd43c. Thanks a lot for contributing to OCA. ❤️

mileo pushed a commit to kmee/server-brand that referenced this pull request Mar 31, 2020
@legalsylvain
[FIX] mass_editing: Fixing error when removing value for fields being…
780b4ea 
… translatable, as their translations were not removed. (OCA#12)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eLBati eLBati eLBati approved these changes

@mileo mileo mileo approved these changes

@Martronic-SA Martronic-SA Martronic-SA approved these changes

@sergiocorato sergiocorato sergiocorato approved these changes

@astirpe astirpe astirpe approved these changes

@MiquelRForgeFlow MiquelRForgeFlow MiquelRForgeFlow approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.