Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][MIG] server_action_mass_edit: Migration to 17.0 #838

Closed
wants to merge 22 commits into from
Closed

[17.0][MIG] server_action_mass_edit: Migration to 17.0 #838

wants to merge 22 commits into from

Conversation

rov-adhoc
Copy link

No description provided.

@rov-adhoc rov-adhoc force-pushed the 17.0-mig-server_action_mass_edit branch 2 times, most recently from a4bce60 to 971a59b Compare March 13, 2024 15:17
@rov-adhoc rov-adhoc force-pushed the 17.0-mig-server_action_mass_edit branch from 971a59b to 4a1cfbe Compare March 19, 2024 19:43
@rov-adhoc rov-adhoc changed the title 17.0 mig server action mass edit [17.0][MIG] server_action_mass_edit: Migration to 17.0 Mar 19, 2024
@rov-adhoc rov-adhoc force-pushed the 17.0-mig-server_action_mass_edit branch 5 times, most recently from cf2379c to 3e07123 Compare March 21, 2024 13:15
CRogos
CRogos reviewed Mar 27, 2024
View reviewed changes
Copy link
Contributor

@CRogos CRogos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you still working on this PR? Could you fix pre-commit and also cleanup the commit history according to the migration guide?

server_action_mass_edit/wizard/mass_editing_wizard.py Outdated Show resolved Hide resolved
@rov-adhoc rov-adhoc force-pushed the 17.0-mig-server_action_mass_edit branch 3 times, most recently from 079d7ac to 76b4e67 Compare March 27, 2024 18:36
@rov-adhoc rov-adhoc marked this pull request as ready for review March 27, 2024 20:23
@anhvu-sg
Copy link
Member

Hi @rov-adhoc, thank you for your hard work. Could you please double-check this error?

image

image

TypeError: data.map is not a function
    at Proxy._createStaticListDatapoint (http://oca-server-ux-17-0-pr838-76b4e67dd92a.runboat.odoo-community.org/web/assets/ed0a327/web.assets_web.min.js:6088:330)
    at Proxy._parseServerValues (http://oca-server-ux-17-0-pr838-76b4e67dd92a.runboat.odoo-community.org/web/assets/ed0a327/web.assets_web.min.js:6121:17)
    at Proxy._setData (http://oca-server-ux-17-0-pr838-76b4e67dd92a.runboat.odoo-community.org/web/assets/ed0a327/web.assets_web.min.js:6030:80)
    at Proxy._save (http://oca-server-ux-17-0-pr838-76b4e67dd92a.runboat.odoo-community.org/web/assets/ed0a327/web.assets_web.min.js:6162:6)
    at async FormController.beforeExecuteActionButton (http://oca-server-ux-17-0-pr838-76b4e67dd92a.runboat.odoo-community.org/web/assets/ed0a327/web.assets_web.min.js:8662:310)
    at async execute (http://oca-server-ux-17-0-pr838-76b4e67dd92a.runboat.odoo-community.org/web/assets/ed0a327/web.assets_web.min.js:9861:38)
    at async executeButtonCallback (http://oca-server-ux-17-0-pr838-76b4e67dd92a.runboat.odoo-community.org/web/assets/ed0a327/web.assets_web.min.js:9857:34)

CRogos
CRogos suggested changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@CRogos CRogos left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As soon I add Tags (Contact) to a mass edit form on contact, I get these error messages.

I think there is something not correct. I get a lot of errors like this:
image

And when I close this dialog and click apply again I get this error:
image

Might be this related to your ir.ui.view changes?

Could you also cleanup the commit history?
https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate
image

server_action_mass_edit/demo/mass_editing.xml Outdated Show resolved Hide resolved
@rov-adhoc rov-adhoc force-pushed the 17.0-mig-server_action_mass_edit branch 3 times, most recently from 749e0cc to 88aaf44 Compare April 20, 2024 15:55
@bizzappdev bizzappdev mentioned this pull request Apr 22, 2024
Merged
@rov-adhoc rov-adhoc force-pushed the 17.0-mig-server_action_mass_edit branch 2 times, most recently from 02af9af to 619afd0 Compare April 23, 2024 23:33
bizzappdev
bizzappdev approved these changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@bizzappdev bizzappdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and Functionality LGTM

CRogos
CRogos suggested changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@CRogos CRogos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error message is gone, and it is working a lot better now. Thank you for your effort.
In some cases, I still have the problem that not data is written to the records.
In this video I remove a contact from the follower, but only on the first contact (Colleen Diaz), the contact is removed and remains on Nicole Ford. I also observed this behavior on add, but a also think this is not happening always and I could not figure out the reason yet.
video (22).webm

Could you also clean up the commit history. There are still a lot git-bot and other commits which could be cleaned.

@rov-adhoc rov-adhoc force-pushed the 17.0-mig-server_action_mass_edit branch 3 times, most recently from eaefc05 to 513941f Compare April 26, 2024 18:43
@rov-adhoc
Copy link
Author

@CRogos Hey! You were right! Thank you for testing this out. Please let me know if it's correct now!

@rov-adhoc rov-adhoc force-pushed the 17.0-mig-server_action_mass_edit branch from 513941f to c93113c Compare April 26, 2024 18:53
victoralmau and others added 20 commits May 3, 2024 12:13
@victoralmau @rov-adhoc
[IMP] base_tier_validation: Add _prepare_tier_review_vals() methot to…
15afda0 
… allow inheritance

TT45804
@rven @rov-adhoc
[MIG] base_tier_validation: Migration to 17.0
3c1c627
@legalsylvain @rov-adhoc
[REF] rename 'mass_editing' module into 'server_action_mass_edit'
449d5af
@legalsylvain @rov-adhoc
[UPD] french translation
e68fb07
@victoralmau @rov-adhoc
[IMP] server_action_mass_edit: Do not re-use demo and admin users to …
0e8e02d 
…avoid incompatibilities with data from those users.
@weblate @rov-adhoc
Update translation files
e3eaf2f 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-ux-16.0/server-ux-16.0-server_action_mass_edit
Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-server_action_mass_edit/
@weblate @rov-adhoc
Update translation files
46eb3c6 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-ux-16.0/server-ux-16.0-server_action_mass_edit
Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-server_action_mass_edit/
@tate11 @rov-adhoc
Translated using Weblate (Turkish)
4991d2a 
Currently translated at 100.0% (43 of 43 strings)

Translation: server-ux-16.0/server-ux-16.0-server_action_mass_edit
Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-server_action_mass_edit/tr/
@sysadminmatmoz @rov-adhoc
Translated using Weblate (Slovenian)
beada81 
Currently translated at 18.6% (8 of 43 strings)

Translation: server-ux-16.0/server-ux-16.0-server_action_mass_edit
Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-server_action_mass_edit/sl/
@hbrunn @rov-adhoc
[ADD] server_action_mass_edit: add support for o2m fields
059bcad
@Ivorra78 @rov-adhoc
Translated using Weblate (Spanish)
967750f 
Currently translated at 100.0% (43 of 43 strings)

Translation: server-ux-16.0/server-ux-16.0-server_action_mass_edit
Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-server_action_mass_edit/es/
@OCA-git-bot @rov-adhoc
[UPD] README.rst
1e96e64
@mymage @rov-adhoc
Translated using Weblate (Italian)
d4d0e61 
Currently translated at 58.1% (25 of 43 strings)

Translation: server-ux-16.0/server-ux-16.0-server_action_mass_edit
Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-server_action_mass_edit/it/
@gregory-moka @rov-adhoc
Translated using Weblate (French)
ccbd8a0 
Currently translated at 95.3% (41 of 43 strings)

Translation: server-ux-16.0/server-ux-16.0-server_action_mass_edit
Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-server_action_mass_edit/fr/
@jappi00 @rov-adhoc
Translated using Weblate (German)
22b5059 
Currently translated at 100.0% (43 of 43 strings)

Translation: server-ux-16.0/server-ux-16.0-server_action_mass_edit
Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-server_action_mass_edit/de/
@mymage @rov-adhoc
Translated using Weblate (Italian)
cd99e1d 
Currently translated at 100.0% (43 of 43 strings)

Translation: server-ux-16.0/server-ux-16.0-server_action_mass_edit
Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-server_action_mass_edit/it/
@rov-adhoc
[FIX] server_action_mass_edit: 'Add' readded to many2many
d8822e4
@jakobkrabbe @rov-adhoc
Translated using Weblate (Swedish)
28243dd 
Currently translated at 100.0% (43 of 43 strings)

Translation: server-ux-16.0/server-ux-16.0-server_action_mass_edit
Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-server_action_mass_edit/sv/
@rov-adhoc
[IMP] server_action_mass_edit: pre-commit execution
5ec350c
@rov-adhoc
[MIG] server_action_mass_edit: Migration to 17.0
1908612
@rov-adhoc rov-adhoc force-pushed the 17.0-mig-server_action_mass_edit branch from a6da0ca to 1908612 Compare May 3, 2024 15:15
@rov-adhoc
Copy link
Author

@CRogos done!!

alan196
alan196 suggested changes May 4, 2024
View reviewed changes
base_tier_validation/tests/test_tier_validation.py
@@ -365,51 +365,6 @@ def test_12_approve_sequence_same_user_bypassed(self):
0, len(record1.review_ids.filtered(lambda x: x.status == "waiting"))
)

def test_12_approve_sequence_same_user_bypassed(self):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you make this changes of a non-related module of this PR??

@CRogos CRogos mentioned this pull request May 6, 2024
Merged
@CRogos
Copy link
Contributor

CRogos commented May 6, 2024

I agree with @alan196 and there are some more commits which should have been merged.

I've picked your changes in a new PR with cleaned commit history:
#872

@pedrobaeza pedrobaeza closed this May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@legalsylvain legalsylvain legalsylvain left review comments

@alan196 alan196 alan196 requested changes

@CRogos CRogos CRogos approved these changes

@bizzappdev bizzappdev bizzappdev approved these changes

@HaraldPanten HaraldPanten HaraldPanten approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.