Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][MIG] server_action_mass_edit #872

Merged
merged 15 commits into from
May 6, 2024
Merged

[17.0][MIG] server_action_mass_edit #872

merged 15 commits into from
May 6, 2024

Conversation

CRogos
Copy link
Contributor

@CRogos CRogos commented May 6, 2024

followup #838

@rov-adhoc something got mixed up in your commit history. Maybe you merged into your migration branch instead of rebase it?
I've created a new branch and picked your last commit.

There were also some more commits to cleanup. Here you can see, what should have been sqashed together:
image

legalsylvain and others added 14 commits May 6, 2024 05:29
@legalsylvain @CRogos
[REF] rename 'mass_editing' module into 'server_action_mass_edit'
9018ff6
@legalsylvain @CRogos
[UPD] french translation
5999d4d
@victoralmau @CRogos
[IMP] server_action_mass_edit: Do not re-use demo and admin users to …
c6a1224 
…avoid incompatibilities with data from those users.
@tate11 @CRogos
Translated using Weblate (Turkish)
0f3784d 
Currently translated at 100.0% (43 of 43 strings)

Translation: server-ux-16.0/server-ux-16.0-server_action_mass_edit
Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-server_action_mass_edit/tr/
@sysadminmatmoz @CRogos
Translated using Weblate (Slovenian)
d41d6d4 
Currently translated at 18.6% (8 of 43 strings)

Translation: server-ux-16.0/server-ux-16.0-server_action_mass_edit
Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-server_action_mass_edit/sl/
@hbrunn @CRogos
[ADD] server_action_mass_edit: add support for o2m fields
8b38206
@Ivorra78 @CRogos
Translated using Weblate (Spanish)
4ebb7d9 
Currently translated at 100.0% (43 of 43 strings)

Translation: server-ux-16.0/server-ux-16.0-server_action_mass_edit
Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-server_action_mass_edit/es/
@mymage @CRogos
Translated using Weblate (Italian)
46a5e50 
Currently translated at 58.1% (25 of 43 strings)

Translation: server-ux-16.0/server-ux-16.0-server_action_mass_edit
Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-server_action_mass_edit/it/
@gregory-moka @CRogos
Translated using Weblate (French)
1de1ba7 
Currently translated at 95.3% (41 of 43 strings)

Translation: server-ux-16.0/server-ux-16.0-server_action_mass_edit
Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-server_action_mass_edit/fr/
@jappi00 @CRogos
Translated using Weblate (German)
d250530 
Currently translated at 100.0% (43 of 43 strings)

Translation: server-ux-16.0/server-ux-16.0-server_action_mass_edit
Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-server_action_mass_edit/de/
@mymage @CRogos
Translated using Weblate (Italian)
5cb35a8 
Currently translated at 100.0% (43 of 43 strings)

Translation: server-ux-16.0/server-ux-16.0-server_action_mass_edit
Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-server_action_mass_edit/it/
@CRogos
[FIX] server_action_mass_edit: 'Add' readded to many2many
dc57d94
@jakobkrabbe @CRogos
Translated using Weblate (Swedish)
c0da1fc 
Currently translated at 100.0% (43 of 43 strings)

Translation: server-ux-16.0/server-ux-16.0-server_action_mass_edit
Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-server_action_mass_edit/sv/
@CRogos
[IMP] server_action_mass_edit: black, isort, prettier
3b9eeab
@CRogos CRogos mentioned this pull request May 6, 2024
Closed
HaraldPanten
HaraldPanten approved these changes May 6, 2024
View reviewed changes
Copy link

@HaraldPanten HaraldPanten left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review.

@pedrobaeza do you mind adding this PR to the migration issue, instead of the first one (the old one, seems not to be 100% OK).

MohamedOsman7
MohamedOsman7 approved these changes May 6, 2024
View reviewed changes
Copy link

@MohamedOsman7 MohamedOsman7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

functional & code review LGTM

@pedrobaeza
Copy link
Member

/ocabot migration server_action_mass_edit
/ocabot merge nobump

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone May 6, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request May 6, 2024
Open
22 tasks
@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-872-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request May 6, 2024
@OCA-git-bot
Merge PR #872 into 17.0
d5540de 
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

@pedrobaeza The merge process could not be finalized, because command oca-gen-addon-readme --if-source-changed --org-name OCA --repo-name server-ux --branch 17.0 --addons-dir /tmp/tmp6j8hyqym --commit failed with output:

/tmp/tmp6j8hyqym/server_action_mass_edit/README.rst:95: (ERROR/3) Duplicate substitution definition name: "image".
Traceback (most recent call last):
  File "/usr/local/bin/oca-gen-addon-readme", line 11, in <module>
    load_entry_point('oca-maintainers-tools', 'console_scripts', 'oca-gen-addon-readme')()
  File "/ocamt/lib/python3.8/site-packages/click/core.py", line 1157, in __call__
    return self.main(*args, **kwargs)
  File "/ocamt/lib/python3.8/site-packages/click/core.py", line 1078, in main
    rv = self.invoke(ctx)
  File "/ocamt/lib/python3.8/site-packages/click/core.py", line 1434, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/ocamt/lib/python3.8/site-packages/click/core.py", line 783, in invoke
    return __callback(*args, **kwargs)
  File "/ocamt/src/oca-maintainers-tools/tools/gen_addon_readme.py", line 575, in gen_addon_readme
    check_rst(readme_filename)
  File "/ocamt/src/oca-maintainers-tools/tools/gen_addon_readme.py", line 398, in check_rst
    publish_file(
  File "/ocamt/lib/python3.8/site-packages/docutils/core.py", line 422, in publish_file
    output, publisher = publish_programmatically(
  File "/ocamt/lib/python3.8/site-packages/docutils/core.py", line 722, in publish_programmatically
    output = publisher.publish(enable_exit_status=enable_exit_status)
  File "/ocamt/lib/python3.8/site-packages/docutils/core.py", line 234, in publish
    self.document = self.reader.read(self.source, self.parser,
  File "/ocamt/lib/python3.8/site-packages/docutils/readers/__init__.py", line 70, in read
    self.parse()
  File "/ocamt/lib/python3.8/site-packages/docutils/readers/__init__.py", line 76, in parse
    self.parser.parse(self.input, document)
  File "/ocamt/lib/python3.8/site-packages/docutils/parsers/rst/__init__.py", line 184, in parse
    self.statemachine.run(inputlines, document, inliner=self.inliner)
  File "/ocamt/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 169, in run
    results = StateMachineWS.run(self, input_lines, input_offset,
  File "/ocamt/lib/python3.8/site-packages/docutils/statemachine.py", line 233, in run
    context, next_state, result = self.check_line(
  File "/ocamt/lib/python3.8/site-packages/docutils/statemachine.py", line 445, in check_line
    return method(match, context, next_state)
  File "/ocamt/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 3024, in text
    self.section(title.lstrip(), source, style, lineno + 1, messages)
  File "/ocamt/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 325, in section
    self.new_subsection(title, lineno, messages)
  File "/ocamt/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 391, in new_subsection
    newabsoffset = self.nested_parse(
  File "/ocamt/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 279, in nested_parse
    state_machine.run(block, input_offset, memo=self.memo,
  File "/ocamt/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 195, in run
    results = StateMachineWS.run(self, input_lines, input_offset)
  File "/ocamt/lib/python3.8/site-packages/docutils/statemachine.py", line 233, in run
    context, next_state, result = self.check_line(
  File "/ocamt/lib/python3.8/site-packages/docutils/statemachine.py", line 445, in check_line
    return method(match, context, next_state)
  File "/ocamt/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 2785, in underline
    self.section(title, source, style, lineno - 1, messages)
  File "/ocamt/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 325, in section
    self.new_subsection(title, lineno, messages)
  File "/ocamt/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 391, in new_subsection
    newabsoffset = self.nested_parse(
  File "/ocamt/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 279, in nested_parse
    state_machine.run(block, input_offset, memo=self.memo,
  File "/ocamt/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 195, in run
    results = StateMachineWS.run(self, input_lines, input_offset)
  File "/ocamt/lib/python3.8/site-packages/docutils/statemachine.py", line 233, in run
    context, next_state, result = self.check_line(
  File "/ocamt/lib/python3.8/site-packages/docutils/statemachine.py", line 445, in check_line
    return method(match, context, next_state)
  File "/ocamt/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 2355, in explicit_markup
    nodelist, blank_finish = self.explicit_construct(match)
  File "/ocamt/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 2367, in explicit_construct
    return method(self, expmatch)
  File "/ocamt/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 2085, in substitution_def
    self.document.note_substitution_def(
  File "/ocamt/lib/python3.8/site-packages/docutils/nodes.py", line 1550, in note_substitution_def
    msg = self.reporter.error(
  File "/ocamt/lib/python3.8/site-packages/docutils/utils/__init__.py", line 231, in error
    return self.system_message(self.ERROR_LEVEL, *args, **kwargs)
  File "/ocamt/lib/python3.8/site-packages/docutils/utils/__init__.py", line 197, in system_message
    raise SystemMessage(msg, level)
docutils.utils.SystemMessage: /tmp/tmp6j8hyqym/server_action_mass_edit/README.rst:95: (ERROR/3) Duplicate substitution definition name: "image".

@pedrobaeza
Copy link
Member

@CRogos please fix the readme references

@CRogos CRogos force-pushed the 17.0-mig-server_action_mass_edit branch from cc6b8fa to 1475e6b Compare May 6, 2024 18:51
@CRogos
Copy link
Contributor Author

CRogos commented May 6, 2024

@pedrobaeza could you retry

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-872-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 9333570 into OCA:17.0 May 6, 2024
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 57e1c94. Thanks a lot for contributing to OCA. ❤️

@CRogos CRogos deleted the 17.0-mig-server_action_mass_edit branch May 6, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HaraldPanten HaraldPanten HaraldPanten approved these changes

@MohamedOsman7 MohamedOsman7 MohamedOsman7 approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.

None yet