Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.0] Add mail_template_multi_report #74

Merged
merged 8 commits into from
Jun 29, 2016

Conversation

ghost
Copy link

@ghost ghost commented Jun 23, 2016

This module adds the option to have more than one report in a email template.

2. In the email template form view, go to the Advanced Settings tab.
3. Add extra reports in the Other Reports field.

The other reports added to the template do not support legacy reports such as rml.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put this in Known issues section

@pedrobaeza
Copy link
Member

Extremely useful module!! Thanks for this fine contribution.

As in 9.0 modules are renamed to avoid the initial "e" (mail_template, mail_tip), and also in OCA we name almost all with "mail" (mail_tracking, mail_debrand...), I suggest you to rename the module to mail_template_multi_report.

@pedrobaeza
Copy link
Member

@ghost
Copy link
Author

ghost commented Jun 23, 2016

@pedrobaeza ok for renaming to mail_template_multi_report

@ghost
Copy link
Author

ghost commented Jun 23, 2016

@pedrobaeza Travis fails because of _get_wkhtmltopdf_bin. Maybe wkhtmltopdf is not in the server's PATH. Who can help me for this issue?

@dreispt
Copy link
Member

dreispt commented Jun 23, 2016

Hopefully #75 fixes it.

@rafaelbn rafaelbn added this to the 8.0 milestone Jun 24, 2016

.. image:: https://odoo-community.org/website/image/ir.attachment/5784_f2813bd/datas
:alt: Try me on Runbot
:target: https://runbot.odoo-community.org/runbot/{repo_id}/{branch}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fill please.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@pedrobaeza
Copy link
Member

👍

@pedrobaeza
Copy link
Member

You can now rebase

@ghost ghost force-pushed the 8.0_email_template_multi_report branch from 7b866dd to e76e224 Compare June 28, 2016 13:22
@ghost
Copy link
Author

ghost commented Jun 28, 2016

@yajo thanks for the review. Travis is green, do you have any other comment ?

@Ehtaga
Copy link

Ehtaga commented Jun 28, 2016

👍

1 similar comment
@elicoidal
Copy link

👍

@elicoidal elicoidal merged commit 88e9260 into OCA:8.0 Jun 29, 2016
@ghost
Copy link
Author

ghost commented Jun 29, 2016

@elicoidal @pedrobaeza @yajo @Ehtaga thanks for reviews

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants