-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[11.0][FIX] web_timeline: add_events call and add jsdocs #1087
Conversation
@tarteo any chance to have separated commits? Makes really hard to understand where the fix is... 😉 |
8018649
to
b46bd04
Compare
@simahawk Sorry 😄, Now it should be clear. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wouldn't be better to delegate events binding to
events: _.extend({}, AbstractRenderer.prototype.events, { |
@tarteo I'm not proposing a refactoring: I'm proposing to fix this in a better way 😉 |
@simahawk Oh I see, I understand now. Thanks I didn't notice but of course I'll fix it the Odoo way! 👍 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG :)
Can you squash the last 2 commits?
plus, please, prefix all commits w/ module name ;) |
c796669
to
2ad08b5
Compare
[ADD] web_timeline: JSdocs
[FIX] web_timeline: calling of add_events
2ad08b5
to
9855f42
Compare
This one can be merged IMO |
Please include it in 12.0 migration |
Issue: #1077