Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.0][MIG] web_timeline #1090

Merged
merged 30 commits into from
Nov 16, 2018
Merged

[12.0][MIG] web_timeline #1090

merged 30 commits into from
Nov 16, 2018

Conversation

tarteo
Copy link
Member

@tarteo tarteo commented Oct 23, 2018

Was pretty easy, there were not many changes in the JS:

lmignon and others added 29 commits October 23, 2018 11:13
* Avoid to display all items of group_by model
* Remove unnecessary readgroup
* Remove dependency on project. Modify module structure. Imporve readme file.
* Add setup.py
* [FIX] Correct write when grouped by

* Remove blank lines

* Minor changes
* Update the vis.js framework to latest stable version (v4.20.1) to add new functionality and save almost
400ko of source code in odoo assets (the vis dev team has isolate the code for timeline widget from the
 rest of their widgets)

* Add the possibility to display events with no duration (instantaneous) as the same time has regular events

* Add the possibility to choose between two scroll mode :
  -  zoom in time resolution (default)
  or
  -  vertical scroll (web browser default behaviour)

Signed-off-by: adrien.didenot <adrien.didenot@horanet.com>
Signed-off-by: adrien.didenot <adrien.didenot@horanet.com>
…same as base Calendar view)

In Odoo calendar view, the attribute date_delay is an alternative to date_stop, to provides the duration of the event instead of its end date.
This commit integrate this attribute to the Timeline view, but contrary to the base Calendar view the Timeline view could use both arguments (date_stop and date_delay) simultaneously.

Signed-off-by: adrien.didenot <adrien.didenot@horanet.com>
The default window display all the events (aka 'fit'), in case of events spread over the year, the events are invisibles (too small to be readable)

Signed-off-by: adrien.didenot <adrien.didenot@horanet.com>
Change the attribute 'default_window' to 'mode' like the Odoo calendar view (to be iso functional)
CSS classes have changed with the updated version of vis.js
* Update Version in Manifest
* Remove enconding in .py files
* Rewrite the view definition according to version 11
[IMP] web_timeline: Templates implementation like kanban

[ADD] Check if template exists

Update README.rst
[UPD] Version number

[UPD] README
Update README.rst

[FIX] Remove console.log

[ADD] Make timeline.fit optional

[FIX] Use stringified points

[IMP] Reversed the arrow head and fixed lint issues

[IMP] Use options parameter for line color and width

[FIX] Version number

[IMP] Minor improvements
[IMP] Prevent flickering

[IMP] Fixed headers

[ADD] Create new record by date range selection

Remove roadmap item from readme

[FIX] minimal height
@pedrobaeza pedrobaeza added this to the 12.0 milestone Oct 23, 2018
Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

skimmed tru last commit: seems good.
Would you mind to improve the README layout?
ATM this does not look really nice:

image

A perfect solution would be to have a table... marking attributes' names w/ bold text would be a good starting point tho 😉

@tarteo
Copy link
Member Author

tarteo commented Oct 31, 2018

@simahawk Nice suggestion. I made the table and I think it looks pretty good. 👍

@pedrobaeza pedrobaeza merged commit 725515a into OCA:12.0 Nov 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.