[13.0][MIG] web_timeline: Migration to 13.0 #1557

Tardo · 2020-03-23T11:41:14Z

Supersedes #1470

Improved CSS
Improved default vis options: Now needs hold "ctrl" key to zoom in/out and the space between elements has been reduced
Fixed all travis warnings
Some refactor to ES6
Removed unused code
Improved how the arrows are drawn on canvas

Before:

After:

cc @Tecnativa TT19831

OCA-git-bot · 2020-03-23T11:41:19Z

Hi @tarteo,
some modules you are maintaining are being modified, check this out!

chienandalu

Thanks! Tested on runbot. Just a minor comment:

web_timeline/README.rst

chienandalu

Also, another icon should be used as the activity view type already uses this one:

web_timeline/static/src/js/timeline_view.js

web_notify/tests/test_res_users.py

Tardo · 2020-03-25T12:06:51Z

Changes done

ernestotejeda

Functional review: OK

pedrobaeza · 2020-03-25T20:41:22Z

@yajo please update your review

.isort.cfg

web_notify/tests/test_res_users.py

web_timeline/readme/CREDITS.rst

web_timeline/static/lib/vis-timeline/vis-timeline-graph2d.min.css

web_timeline/static/lib/vis-timeline/vis-timeline-graph2d.min.js

* Avoid to display all items of group_by model * Remove unnecessary readgroup * Remove dependency on project. Modify module structure. Imporve readme file. * Add setup.py

* [FIX] Correct write when grouped by * Remove blank lines * Minor changes

* Update the vis.js framework to latest stable version (v4.20.1) to add new functionality and save almost 400ko of source code in odoo assets (the vis dev team has isolate the code for timeline widget from the rest of their widgets) * Add the possibility to display events with no duration (instantaneous) as the same time has regular events * Add the possibility to choose between two scroll mode : - zoom in time resolution (default) or - vertical scroll (web browser default behaviour) Signed-off-by: adrien.didenot <adrien.didenot@horanet.com>

Signed-off-by: adrien.didenot <adrien.didenot@horanet.com>

Currently translated at 100.0% (23 of 23 strings) Translation: web-12.0/web-12.0-web_timeline Translate-URL: https://translation.odoo-community.org/projects/web-12-0/web-12-0-web_timeline/zh_CN/

Currently translated at 87.0% (20 of 23 strings) Translation: web-12.0/web-12.0-web_timeline Translate-URL: https://translation.odoo-community.org/projects/web-12-0/web-12-0-web_timeline/hr/

pedrobaeza · 2020-03-30T17:52:12Z

You have changed the repo to website in the README.

Tardo · 2020-03-30T18:04:16Z

Oops! sorry, changed!

Tardo · 2020-04-06T14:07:09Z

@dreispt this pr is ready to review.

mohammad0omar · 2020-04-07T18:28:41Z

I am trying to run this with the project timeline module

but in the console, I've got this warning
**
**### vis-timeline-graph2d.min.js:59 This build has been deprecated.

In case you are importing this through a URL it will result in a 404 eventually.
In case you are importing this through Node it will be replaced by the peer build eventually.

Please use the peer or standalone build instead.
Peer: https://visjs.github.io/vis-timeline/examples/timeline/peer-build.html
Standalone: https://visjs.github.io/vis-timeline/examples/timeline/standalone-build.html
(anonymous) @ vis-timeline-graph2d.min.js:59
(anonymous) @ vis-timeline-graph2d.min.js:26
(anonymous) @ vis-timeline-graph2d.min.js:26
21:16:25.228 DevTools failed to parse SourceMap: http://localhost:8069/web_timeline/static/lib/vis-timeline/vis-timeline-graph2d.min.js.map**

then when clicking on the timeline icon in the kanban view to access the timeline view
this error GET http://localhost:8069/web_timeline/static/lib/vis-timeline/vis-timeline-graph2d.min.css net::ERR_ABORTED 404 (NOT FOUND)

, to solve this I've temporary setted the URLs in timeline_view.js to this and same for cssLibs

then the clicking on the icon will let you go to the timeline view but will not be initiated because of this error
util.js:191 Uncaught (in promise) TypeError: i.createNewDataPipeFrom is not a function
at ns (util.js:191)
at e.value (Timeline.js:317)
at Class.on_data_loaded_2 (timeline_renderer.js:358)
at timeline_renderer.js:336

chienandalu · 2020-04-15T14:40:05Z

@yajo Can you update your review?

pedrobaeza · 2020-04-17T07:27:03Z

/ocabot merge nobump

OCA-git-bot · 2020-04-17T07:27:22Z

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 13.0-ocabot-merge-pr-1557-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot · 2020-04-17T07:31:15Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot · 2020-04-17T07:43:57Z

Congratulations, your PR was merged at ad692c0. Thanks a lot for contributing to OCA. ❤️

pedrobaeza mentioned this pull request Mar 23, 2020

[MIG] web_timeline: Migration to 13.0 #1470

Closed

OCA-git-bot mentioned this pull request Mar 23, 2020

Migration to version 13.0 #1388

Closed

41 tasks

Tardo force-pushed the 13.0-mig-web_timeline branch from 4975ed9 to a0427f3 Compare March 23, 2020 12:02

Tardo mentioned this pull request Mar 23, 2020

[13.0][MIG] project_timeline: Migration to 13.0 OCA/project#656

Merged

chienandalu reviewed Mar 24, 2020

View reviewed changes

web_timeline/README.rst Show resolved Hide resolved

chienandalu suggested changes Mar 24, 2020

View reviewed changes

carlosdauden approved these changes Mar 24, 2020

View reviewed changes

carlosdauden reviewed Mar 24, 2020

View reviewed changes

web_timeline/static/src/js/timeline_view.js Outdated Show resolved Hide resolved

yajo requested changes Mar 24, 2020

View reviewed changes

web_notify/tests/test_res_users.py Outdated Show resolved Hide resolved

Tardo changed the title ~~[13.0][MIG] web_timeline: Migration to 13.0~~ [WIP][13.0][MIG] web_timeline: Migration to 13.0 Mar 24, 2020

Tardo force-pushed the 13.0-mig-web_timeline branch 2 times, most recently from 72f8422 to 28fbcbc Compare March 25, 2020 12:05

Tardo changed the title ~~[WIP][13.0][MIG] web_timeline: Migration to 13.0~~ [13.0][MIG] web_timeline: Migration to 13.0 Mar 25, 2020

ernestotejeda reviewed Mar 25, 2020

View reviewed changes

ernestotejeda approved these changes Mar 25, 2020

View reviewed changes

yajo requested changes Mar 26, 2020

View reviewed changes

lmignon and others added 11 commits March 30, 2020 19:20

[IMP] web_timeline: Extracted from incubator

bab7e31

[IMP] web_timeline: Several improvements:

c30c01c

* Avoid to display all items of group_by model * Remove unnecessary readgroup * Remove dependency on project. Modify module structure. Imporve readme file. * Add setup.py

[IMP] web_timeline: add few features

4049b0a

[MIG] web_timeline: Migration to 9.0

4d57cf4

Port web_timeline to v10

36cfd9b

[FIX] web_timeline: fix commas in manifest file

e4ed451

OCA Transbot updated translations from Transifex

0a86f6b

OCA Transbot updated translations from Transifex

73bddec

[10.0] [FIX] [web_timeline] Correct write when grouped by (OCA#678)

03834d6

* [FIX] Correct write when grouped by * Remove blank lines * Minor changes

Cosmetic changes (to skip or squash)

70da4d9

Signed-off-by: adrien.didenot <adrien.didenot@horanet.com>

liweijie0812 and others added 5 commits March 30, 2020 19:20

Added translation using Weblate (Chinese (Simplified))

d8423d9

Translated using Weblate (Chinese (Simplified))

b086d32

Currently translated at 100.0% (23 of 23 strings) Translation: web-12.0/web-12.0-web_timeline Translate-URL: https://translation.odoo-community.org/projects/web-12-0/web-12-0-web_timeline/zh_CN/

Translated using Weblate (Croatian)

987fd13

Currently translated at 87.0% (20 of 23 strings) Translation: web-12.0/web-12.0-web_timeline Translate-URL: https://translation.odoo-community.org/projects/web-12-0/web-12-0-web_timeline/hr/

[IMP] web_timeline: black, isort

a88496b

[MIG] web_timeline: Migration to 13.0

245d308

Tardo force-pushed the 13.0-mig-web_timeline branch from 28fbcbc to 2ba114b Compare March 30, 2020 17:46

Tardo force-pushed the 13.0-mig-web_timeline branch from 2ba114b to 2531103 Compare March 30, 2020 18:04

dreispt added the needs fixing label Apr 6, 2020

dreispt assigned Tardo Apr 6, 2020

dreispt added this to the 13.0 milestone Apr 6, 2020

[MIG] web_timeline: Finish migration to 13.0

07666a2

Tardo force-pushed the 13.0-mig-web_timeline branch from 2531103 to 07666a2 Compare April 6, 2020 14:12

chienandalu approved these changes Apr 15, 2020

View reviewed changes

yajo approved these changes Apr 17, 2020

View reviewed changes

OCA-git-bot added the approved label Apr 17, 2020

OCA-git-bot added bot is merging ⏳ ready to merge labels Apr 17, 2020

OCA-git-bot merged commit c73870e into OCA:13.0 Apr 17, 2020

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Apr 17, 2020

brian10048 mentioned this pull request Oct 16, 2020

[13.0][ADD] fieldservice_timeline OCA/field-service#521

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[13.0][MIG] web_timeline: Migration to 13.0 #1557

[13.0][MIG] web_timeline: Migration to 13.0 #1557

Tardo commented Mar 23, 2020 •

edited by dreispt

Loading

OCA-git-bot commented Mar 23, 2020

chienandalu left a comment

chienandalu left a comment

Tardo commented Mar 25, 2020

ernestotejeda left a comment

pedrobaeza commented Mar 25, 2020

pedrobaeza commented Mar 30, 2020 •

edited

Loading

Tardo commented Mar 30, 2020

Tardo commented Apr 6, 2020

mohammad0omar commented Apr 7, 2020

chienandalu commented Apr 15, 2020

pedrobaeza commented Apr 17, 2020

OCA-git-bot commented Apr 17, 2020

OCA-git-bot commented Apr 17, 2020

OCA-git-bot commented Apr 17, 2020

[13.0][MIG] web_timeline: Migration to 13.0 #1557

[13.0][MIG] web_timeline: Migration to 13.0 #1557

Conversation

Tardo commented Mar 23, 2020 • edited by dreispt Loading

OCA-git-bot commented Mar 23, 2020

chienandalu left a comment

Choose a reason for hiding this comment

chienandalu left a comment

Choose a reason for hiding this comment

Tardo commented Mar 25, 2020

ernestotejeda left a comment

Choose a reason for hiding this comment

pedrobaeza commented Mar 25, 2020

pedrobaeza commented Mar 30, 2020 • edited Loading

Tardo commented Mar 30, 2020

Tardo commented Apr 6, 2020

mohammad0omar commented Apr 7, 2020

chienandalu commented Apr 15, 2020

pedrobaeza commented Apr 17, 2020

OCA-git-bot commented Apr 17, 2020

OCA-git-bot commented Apr 17, 2020

OCA-git-bot commented Apr 17, 2020

Tardo commented Mar 23, 2020 •

edited by dreispt

Loading

pedrobaeza commented Mar 30, 2020 •

edited

Loading