-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[13.0][MIG] web_timeline: Migration to 13.0 #1557
Conversation
Hi @tarteo, |
4975ed9
to
a0427f3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Tested on runbot. Just a minor comment:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
72f8422
to
28fbcbc
Compare
Changes done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional review: OK
@yajo please update your review |
web_timeline/static/lib/vis-timeline/vis-timeline-graph2d.min.css
Outdated
Show resolved
Hide resolved
web_timeline/static/lib/vis-timeline/vis-timeline-graph2d.min.js
Outdated
Show resolved
Hide resolved
* Avoid to display all items of group_by model * Remove unnecessary readgroup * Remove dependency on project. Modify module structure. Imporve readme file. * Add setup.py
* [FIX] Correct write when grouped by * Remove blank lines * Minor changes
* Update the vis.js framework to latest stable version (v4.20.1) to add new functionality and save almost 400ko of source code in odoo assets (the vis dev team has isolate the code for timeline widget from the rest of their widgets) * Add the possibility to display events with no duration (instantaneous) as the same time has regular events * Add the possibility to choose between two scroll mode : - zoom in time resolution (default) or - vertical scroll (web browser default behaviour) Signed-off-by: adrien.didenot <adrien.didenot@horanet.com>
Signed-off-by: adrien.didenot <adrien.didenot@horanet.com>
Currently translated at 100.0% (23 of 23 strings) Translation: web-12.0/web-12.0-web_timeline Translate-URL: https://translation.odoo-community.org/projects/web-12-0/web-12-0-web_timeline/zh_CN/
Currently translated at 87.0% (20 of 23 strings) Translation: web-12.0/web-12.0-web_timeline Translate-URL: https://translation.odoo-community.org/projects/web-12-0/web-12-0-web_timeline/hr/
28fbcbc
to
2ba114b
Compare
You have changed the repo to |
2ba114b
to
2531103
Compare
Oops! sorry, changed! |
@dreispt this pr is ready to review. |
2531103
to
07666a2
Compare
I am trying to run this with the project timeline module but in the console, I've got this warning In case you are importing this through a URL it will result in a 404 eventually. Please use the peer or standalone build instead. then when clicking on the timeline icon in the kanban view to access the timeline view , to solve this I've temporary setted the URLs in timeline_view.js to this and same for cssLibs then the clicking on the icon will let you go to the timeline view but will not be initiated because of this error |
@yajo Can you update your review? |
/ocabot merge nobump |
Hey, thanks for contributing! Proceeding to merge this for you. |
This PR has the |
Congratulations, your PR was merged at ad692c0. Thanks a lot for contributing to OCA. ❤️ |
Supersedes #1470
Before:
After:
cc @Tecnativa TT19831