-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][MIG] web_responsive: Migration to 17.0 #2684
[17.0][MIG] web_responsive: Migration to 17.0 #2684
Conversation
TesaLazarenko
commented
Nov 24, 2023
•
edited
Loading
edited
- change the background of the app menu
- change search list items
- fix sticky buttons panel
- Readme / Description with screenshots
- fix app search
* Add Tecnativa as author * Remove untestable JS method * Rename to web_responsive
* Bump version * Change all openerp to odoo * Fix qunit suite injection * Remove jQuery require * Change to new selectors: * `oe_leftbar` to `o_sub_menu` * `oe_logo` to `o_sub_menu_logo` * `oe_footer` to `o_sub_menu_footer` * `oe_secondary_menus_container` to `o_sub_menu_content` * Add style to hide oe_footer instead of remove to not break `support_branding` * Add note in ReadMe explaining override of `support_branding` * Set top margin of app drawer title to 0 to fit v10 proportions * Fix notification badge positioning * Add o_web_client class to body to fix overlaps * Scroll control panel with page * Change navbar z-index to not be overlapped by buttons * Raise z-index on header to raise over buttons * Handle layered notifications via z-index * Remove `#` from navigation links HREF to prevent history littering
* Rebalance z-indexes to fix overlay issue while still providing notification support
* Bold titles for apps in the app-drawer * Remove z-index from Control Panel buttons, so it doesn't overlap the menu. * Better responsive menus * Move systray icons/menus out of the menu and up to the top bar. * Increase avatar size and visibility. * Other minor menu behavior fixes. * Changes to fit odoo variables * And a little margin adjust on navbar-right * Top menu always thick * Removed overflow:hidden!important from main.less * Local patch: prevent body overflow auto * Stop using `style=` on `<body>` * Fix jquery drawer in anticipation of: blivesta/drawer#36
On screens with less than 768px content is limited to 2 columns. On mobile field labels have their own line. Fix elements width for XS screens
Make image editing controls always available, instead of depending on resolution or hover.
Small makeup to make it look good in XS screens.
* [IMP] drawer-toggle * [IMP] Hitbox of close drawer-toggle * [IMP] Removed outline on menu item * [IMP] Logo positionings * [FIX] Try me on runbot button * [REM] Reversed outline change
* Change accesskey for `edit` in form view back to `e` to fix OCA#587
Before this patch, there was an incompatibility between this addon and l10n_es_toponyms, caused by the lack of wrapping of the special address field that was being added. Now layout works as expected in that case. In any other case, it seems sensible to wrap inputs so no more weird overflows happen and less chances of needing horizontal scrolling happen.
* Initial commit * Initial commit
* FIX hasclass * FIX views * [FIX] web_responsive: Syntax error in xpath
* Update to iScoll bleeding edge to fix OCA#741
* Add a call to the window resize method during init to fix OCA#773
086f150
to
7f9beda
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional tests look good on my side
I'm getting this error in my testing – on Mac with both Firefox and Chrome. There isn't any way to select a menu using the keyboard arrow keys then enter is the usual way). Can't change focus with tab or anything else that I could find. It can only launch the menu with a mouse click.
|
Thanks for the detailed description, I will check and make a fix |
7f9beda
to
0dda0fa
Compare
Done |
Hi, @LazarusUA, thanks for the changes. I'm testing it in runboat, and it seems it still doesn't work as it was in v16-. If I type "invoicustominv", I got the menu Invoicing/Customers/Invoices on the search (using parts of the full menu path). Now I'm not getting it. That's the idea of keeping the old menu search. Right now, we are getting the same features as the other menu search. |
Hi all, 2024-01-16 12:48:34,980 10165 ERROR elena odoo.addons.web.controllers.binary: Impossible de créer 'web_responsive.None' car le modèle à hériter 'web.Legacy.ControlPanel' est introuvable. 2024-01-16 12:48:34,980 10165 INFO elena werkzeug: 127.0.0.1 - - [16/Jan/2024 12:48:34] "GET /web/assets/cc4228f/web.assets_web.min.js HTTP/1.1" 404 - 4 0.004 1.304 Regards Maurice |
I can confirm this fixes what I was seeing. Thanks for the quick update! |
Hello , Upon installing and attempting to perform a database backup, followed by a restoration and login, I encountered an issue where only a white screen appeared. Upon reviewing the logs, I get the following error: 2024-01-19 08:32:34,644 4930 INFO 17_1 odoo.addons.base.models.assetsbundle: Generating a new asset bundle attachment /web/assets/9d93625/web.assets_web.min.css (id:127452) thank you for your efforts ! |
I'll try to check it later on version 16, because at the moment I returned the search code as it was before. |
|
0dda0fa
to
7d4e65d
Compare
@pedrobaeza I now believe that I have completely returned the old search. I also fixed the problems mentioned earlier. Tested locally on odoo:17.0-20240119 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working! Thanks for all your efforts and patience
/ocabot merge nobump
This PR looks fantastic, let's merge it! |
Congratulations, your PR was merged at dc9d457. Thanks a lot for contributing to OCA. ❤️ |