[17.0][MIG] web_responsive: Migration to 17.0 #2684

TesaLazarenko · 2023-11-24T16:19:18Z

* Add Tecnativa as author * Remove untestable JS method * Rename to web_responsive

* Bump version * Change all openerp to odoo * Fix qunit suite injection * Remove jQuery require * Change to new selectors: * `oe_leftbar` to `o_sub_menu` * `oe_logo` to `o_sub_menu_logo` * `oe_footer` to `o_sub_menu_footer` * `oe_secondary_menus_container` to `o_sub_menu_content` * Add style to hide oe_footer instead of remove to not break `support_branding` * Add note in ReadMe explaining override of `support_branding` * Set top margin of app drawer title to 0 to fit v10 proportions * Fix notification badge positioning * Add o_web_client class to body to fix overlaps * Scroll control panel with page * Change navbar z-index to not be overlapped by buttons * Raise z-index on header to raise over buttons * Handle layered notifications via z-index * Remove `#` from navigation links HREF to prevent history littering

* Rebalance z-indexes to fix overlay issue while still providing notification support

* Bold titles for apps in the app-drawer * Remove z-index from Control Panel buttons, so it doesn't overlap the menu. * Better responsive menus * Move systray icons/menus out of the menu and up to the top bar. * Increase avatar size and visibility. * Other minor menu behavior fixes. * Changes to fit odoo variables * And a little margin adjust on navbar-right * Top menu always thick * Removed overflow:hidden!important from main.less * Local patch: prevent body overflow auto * Stop using `style=` on `<body>` * Fix jquery drawer in anticipation of: blivesta/drawer#36

On screens with less than 768px content is limited to 2 columns. On mobile field labels have their own line. Fix elements width for XS screens

Make image editing controls always available, instead of depending on resolution or hover.

Small makeup to make it look good in XS screens.

* [IMP] drawer-toggle * [IMP] Hitbox of close drawer-toggle * [IMP] Removed outline on menu item * [IMP] Logo positionings * [FIX] Try me on runbot button * [REM] Reversed outline change

* Change accesskey for `edit` in form view back to `e` to fix OCA#587

Before this patch, there was an incompatibility between this addon and l10n_es_toponyms, caused by the lack of wrapping of the special address field that was being added. Now layout works as expected in that case. In any other case, it seems sensible to wrap inputs so no more weird overflows happen and less chances of needing horizontal scrolling happen.

* Initial commit * Initial commit

* FIX hasclass * FIX views * [FIX] web_responsive: Syntax error in xpath

* Update to iScoll bleeding edge to fix OCA#741

* Add a call to the window resize method during init to fix OCA#773

…sues 808 (OCA#809) Closes OCA#808

…OCA#951)

AaronHForgeFlow

Functional tests look good on my side

TesaLazarenko · 2024-01-09T09:50:36Z

now the search works as before and by default, but you can change it in the menu configuration.
Click
.

traviswaelbro · 2024-01-16T03:25:12Z

I'm getting this error in my testing – on Mac with both Firefox and Chrome. There isn't any way to select a menu using the keyboard arrow keys then enter is the usual way). Can't change focus with tab or anything else that I could find. It can only launch the menu with a mouse click.

Open the menu picker screen (Cmd-H)
Type in text to any filter for a menu
Click Enter to try to open the menu
Error is raised

TypeError: element.querySelector(...) is null
    _onKeyDown@http://localhost:10102/web/assets/1/a9f463f/web.assets_web.min.js:16604:738
    mainEventHandler@http://localhost:10102/web/assets/1/a9f463f/web.assets_web.min.js:1552:77
    listener@http://localhost:10102/web/assets/1/a9f463f/web.assets_web.min.js:726:15

TesaLazarenko · 2024-01-16T03:27:56Z

I'm getting this error in my testing...

Thanks for the detailed description, I will check and make a fix

TesaLazarenko · 2024-01-16T04:27:21Z

I'm getting this error in my testing – on Mac with both Firefox and Chrome. ...

Done

pedrobaeza · 2024-01-16T07:36:00Z

Hi, @LazarusUA, thanks for the changes. I'm testing it in runboat, and it seems it still doesn't work as it was in v16-. If I type "invoicustominv", I got the menu Invoicing/Customers/Invoices on the search (using parts of the full menu path). Now I'm not getting it. That's the idea of keeping the old menu search. Right now, we are getting the same features as the other menu search.

Maurice67205 · 2024-01-16T12:50:42Z

Hi all,
I just tested the module web_responsive and i get the following error
2024-01-16 12:48:33,656 10165 INFO elena werkzeug: 127.0.0.1 - - [16/Jan/2024 12:48:33] "GET /web HTTP/1.1" 200 - 88 0.022 0.729
2024-01-16 12:48:34,711 10165 INFO elena werkzeug: 127.0.0.1 - - [16/Jan/2024 12:48:34] "GET /web/service-worker.js HTTP/1.1" 200 - 1 0.001 0.025
2024-01-16 12:48:34,731 10165 INFO elena odoo.addons.base.models.assetsbundle: Generating a new asset bundle attachment /web/assets/1870eb4/web.assets_web.min.css (id:201)
2024-01-16 12:48:34,731 10165 INFO elena odoo.addons.base.models.assetsbundle: Deleting attachments [200] (matching /web/assets/_______/web.assets_web.min.css) because it was replaced with /web/assets/1870eb4/web.assets_web.min.css
2024-01-16 12:48:34,738 10165 INFO elena werkzeug: 127.0.0.1 - - [16/Jan/2024 12:48:34] "GET /web/assets/1870eb4/web.assets_web.min.css HTTP/1.1" 200 - 17 0.020 1.047

2024-01-16 12:48:34,980 10165 ERROR elena odoo.addons.web.controllers.binary: Impossible de créer 'web_responsive.None' car le modèle à hériter 'web.Legacy.ControlPanel' est introuvable.

2024-01-16 12:48:34,980 10165 INFO elena werkzeug: 127.0.0.1 - - [16/Jan/2024 12:48:34] "GET /web/assets/cc4228f/web.assets_web.min.js HTTP/1.1" 404 - 4 0.004 1.304
2024-01-16 12:48:35,996 10165 INFO elena werkzeug: 127.0.0.1 - - [16/Jan/2024 12:48:35] "GET /web/service-worker.js HTTP/1.1" 200 - 1 0.001 0.003

Regards

Maurice

traviswaelbro · 2024-01-16T13:03:38Z

I'm getting this error in my testing – on Mac with both Firefox and Chrome. ...

Done

I can confirm this fixes what I was seeing. Thanks for the quick update!

Ramibha · 2024-01-19T08:54:14Z

Hello ,

Upon installing and attempting to perform a database backup, followed by a restoration and login, I encountered an issue where only a white screen appeared. Upon reviewing the logs, I get the following error:

2024-01-19 08:32:34,644 4930 INFO 17_1 odoo.addons.base.models.assetsbundle: Generating a new asset bundle attachment /web/assets/9d93625/web.assets_web.min.css (id:127452)
2024-01-19 08:32:34,645 4930 INFO 17_1 odoo.addons.base.models.assetsbundle: Deleting attachments [118079] (matching /web/assets/_______/web.assets_web.min.css) because it was replaced with /web/assets/9d93625/web.assets_web.min.css
2024-01-19 08:32:34,666 4930 ERROR 17_1 odoo.addons.web.controllers.binary: Element '' cannot be located in parent view
2024-01-19 08:32:34,666 4930 INFO 17_1 werkzeug: 127.0.0.1 - - [19/Jan/2024 08:32:34] "GET /web/assets/716cb07/web.assets_web.min.js HTTP/1.1" 404 - 20 0.011 0.969
2024-01-19 08:32:34,683 4930 INFO 17_1 werkzeug: 127.0.0.1 - - [19/Jan/2024 08:32:34] "GET /web/assets/9d93625/web.assets_web.min.css HTTP/1.1" 200 - 30 0.067 0.930

thank you for your efforts !

TesaLazarenko · 2024-01-19T11:59:45Z

Hi, @LazarusUA, thanks for the changes. I'm testing it in runboat, and it seems it still doesn't work as it was in v16-. ...

I'll try to check it later on version 16, because at the moment I returned the search code as it was before.
Perhaps I didn't see the changes that were there at 16.

jvbp · 2024-01-19T12:10:47Z

Hello ,

Upon installing and attempting to perform a database backup, followed by a restoration and login, I encountered an issue where only a white screen appeared. Upon reviewing the logs, I get the following error:

2024-01-19 08:32:34,644 4930 INFO 17_1 odoo.addons.base.models.assetsbundle: Generating a new asset bundle attachment /web/assets/9d93625/web.assets_web.min.css (id:127452) 2024-01-19 08:32:34,645 4930 INFO 17_1 odoo.addons.base.models.assetsbundle: Deleting attachments [118079] (matching /web/assets/_______/web.assets_web.min.css) because it was replaced with /web/assets/9d93625/web.assets_web.min.css 2024-01-19 08:32:34,666 4930 ERROR 17_1 odoo.addons.web.controllers.binary: Element '' cannot be located in parent view 2024-01-19 08:32:34,666 4930 INFO 17_1 werkzeug: 127.0.0.1 - - [19/Jan/2024 08:32:34] "GET /web/assets/716cb07/web.assets_web.min.js HTTP/1.1" 404 - 20 0.011 0.969 2024-01-19 08:32:34,683 4930 INFO 17_1 werkzeug: 127.0.0.1 - - [19/Jan/2024 08:32:34] "GET /web/assets/9d93625/web.assets_web.min.css HTTP/1.1" 200 - 30 0.067 0.930

thank you for your efforts !

The crash is caused by this Odoo change:

So removing this xpath from chatter.xml in OCA web_responsive result in no error:

Regards

TesaLazarenko · 2024-01-19T12:11:19Z

Hi, @LazarusUA, thanks for the changes. I'm testing it in runboat, and it seems it still doesn't work as it was in v16-. ...

I'll try to check it later on version 16, because at the moment I returned the search code as it was before. Perhaps I didn't see the changes that were there at 16.

I just took a quick look and saw that the method (fuzzyLookup) that the old search used now works a little differently in version 17. When I have time, I will test how big the difference is now. Then maybe I will drag the algorithm from version 16

TesaLazarenko · 2024-01-19T12:13:32Z

The crash is caused by this Odoo change:

So removing this xpath from chatter.xml in OCA web_responsive result in no error:

ok, I'll take that into account, because sometimes odoo changes the xml structure and new releases may have similar problems

TesaLazarenko · 2024-01-19T15:02:38Z

@pedrobaeza I now believe that I have completely returned the old search.

I also fixed the problems mentioned earlier. Tested locally on odoo:17.0-20240119

pedrobaeza

Working! Thanks for all your efforts and patience

/ocabot merge nobump

OCA-git-bot · 2024-01-19T15:12:11Z

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-2684-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot · 2024-01-19T15:16:22Z

Congratulations, your PR was merged at dc9d457. Thanks a lot for contributing to OCA. ❤️

lasley and others added 30 commits November 17, 2023 00:37

[FIX] web_responsive: Other minor fixes

88a9520

* Add Tecnativa as author * Remove untestable JS method * Rename to web_responsive

[FIX] web_responsive: Change z-indexes

8146f4b

* Rebalance z-indexes to fix overlay issue while still providing notification support

Form view improvements to fit smaller screens

5bed732

On screens with less than 768px content is limited to 2 columns. On mobile field labels have their own line. Fix elements width for XS screens

Form image editing controls always present

07cac94

Make image editing controls always available, instead of depending on resolution or hover.

Fix problem with overflowing chatter widget.

add2088

[FIX][web_responsive] Form padding, titles and buttons OK in XS

d54707c

Small makeup to make it look good in XS screens.

[10.0][IMP][web_responsive] (OCA#569)

6ea223c

* [IMP] drawer-toggle * [IMP] Hitbox of close drawer-toggle * [IMP] Removed outline on menu item * [IMP] Logo positionings * [FIX] Try me on runbot button * [REM] Reversed outline change

Update README to fix wikipedia link

f14df31

[FIX] web_responsive: Change edit accesskey

441e5c4

* Change accesskey for `edit` in form view back to `e` to fix OCA#587

[FIX] web_responsive: Execution permission

f6df76d

[10.0][IMP][web_responsive] Make search bar sticky (OCA#633)

84f330d

* Initial commit * Initial commit

[FIX][web_responsive] Long-named multicompanies nice in XS (OCA#688)

2ce6913

[10.0][IMP] web_responsive: Load default kanban view for small screen

caadd7f

UPDT version

481f45b

FIX travis (OCA#747)

139d1bf

* FIX hasclass * FIX views * [FIX] web_responsive: Syntax error in xpath

[FIX] web_responsive: Chrome Slow Scrolling

2403206

* Update to iScoll bleeding edge to fix OCA#741

[FIX] web_responsive: Correct runbot link

edb253b

[MIG] web_responsive test to 11.0

c36d358

[FIX] web_responsive: Menu Height on Init

f00aecd

* Add a call to the window resize method during init to fix OCA#773

[FIX] web_responsive: Hide header when print directly from browser is…

3c9ddf5

…sues 808 (OCA#809) Closes OCA#808

[IMP] web_responsive: Possibility of putting the chatter in the right (…

9817f31

…OCA#951)

[UPD] README.rst

179d1b3

[FIX] Chatter Position

9f8ba3e

[FIX] Read/Write permissions

10c7118

[CLEAN] Comments

c4c5d7a

[IMP] Code

aa0d932

[IMP] Adding res.users chatter_position read/write test

c604ec7

TesaLazarenko force-pushed the 17.0-mig-web_responsive branch 5 times, most recently from 086f150 to 7f9beda Compare January 6, 2024 03:18

AaronHForgeFlow reviewed Jan 9, 2024

View reviewed changes

TesaLazarenko force-pushed the 17.0-mig-web_responsive branch from 7f9beda to 0dda0fa Compare January 16, 2024 04:24

[MIG] web_responsive: Migration to 17.0

7d4e65d

TesaLazarenko force-pushed the 17.0-mig-web_responsive branch from 0dda0fa to 7d4e65d Compare January 19, 2024 15:00

pedrobaeza approved these changes Jan 19, 2024

View reviewed changes

OCA-git-bot added the bot is merging ⏳ label Jan 19, 2024

OCA-git-bot merged commit 6309011 into OCA:17.0 Jan 19, 2024
7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Jan 19, 2024

victoralmau mentioned this pull request Aug 8, 2024

[16.0][FIX] web_responsive: Remove overflow:visible to tables to avoid side effects #2910

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[17.0][MIG] web_responsive: Migration to 17.0 #2684

[17.0][MIG] web_responsive: Migration to 17.0 #2684

TesaLazarenko commented Nov 24, 2023 •

edited

Loading

AaronHForgeFlow left a comment

TesaLazarenko commented Jan 9, 2024 •

edited

Loading

traviswaelbro commented Jan 16, 2024

TesaLazarenko commented Jan 16, 2024

TesaLazarenko commented Jan 16, 2024

pedrobaeza commented Jan 16, 2024

Maurice67205 commented Jan 16, 2024

traviswaelbro commented Jan 16, 2024

Ramibha commented Jan 19, 2024

TesaLazarenko commented Jan 19, 2024

jvbp commented Jan 19, 2024

TesaLazarenko commented Jan 19, 2024 •

edited

Loading

TesaLazarenko commented Jan 19, 2024

TesaLazarenko commented Jan 19, 2024

pedrobaeza left a comment

OCA-git-bot commented Jan 19, 2024

OCA-git-bot commented Jan 19, 2024

[17.0][MIG] web_responsive: Migration to 17.0 #2684

[17.0][MIG] web_responsive: Migration to 17.0 #2684

Conversation

TesaLazarenko commented Nov 24, 2023 • edited Loading

AaronHForgeFlow left a comment

Choose a reason for hiding this comment

TesaLazarenko commented Jan 9, 2024 • edited Loading

traviswaelbro commented Jan 16, 2024

TesaLazarenko commented Jan 16, 2024

TesaLazarenko commented Jan 16, 2024

pedrobaeza commented Jan 16, 2024

Maurice67205 commented Jan 16, 2024

traviswaelbro commented Jan 16, 2024

Ramibha commented Jan 19, 2024

TesaLazarenko commented Jan 19, 2024

jvbp commented Jan 19, 2024

TesaLazarenko commented Jan 19, 2024 • edited Loading

TesaLazarenko commented Jan 19, 2024

TesaLazarenko commented Jan 19, 2024

pedrobaeza left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Jan 19, 2024

OCA-git-bot commented Jan 19, 2024

TesaLazarenko commented Nov 24, 2023 •

edited

Loading

TesaLazarenko commented Jan 9, 2024 •

edited

Loading

TesaLazarenko commented Jan 19, 2024 •

edited

Loading