-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][FIX] web_responsive: Remove overflow:visible to tables to avoid side effects #2910
[16.0][FIX] web_responsive: Remove overflow:visible to tables to avoid side effects #2910
Conversation
Please check why that was introduced, as maybe removing it has another "side effect". You can ask as well the original contributor. |
These changes were added at #2405 (I don't know exactly why) and removed at #2684. Ping @bvanjeelharia Can you tell us why that code was added, is this change correct and will not cause side effects or do you propose a better one? Thanks |
The ping wasn't correct. Trying again @bvanjeelharia |
If removed in 17.0, it seems it's not very needed. |
Specifically, this piece of code was removed in v17 https://github.com/OCA/web/blob/16.0/web_responsive/static/src/legacy/scss/web_responsive.scss#L250-L288 |
Well, it was removed because Odoo incorporates the sticky feature natively, so maybe the overflow was not removed specifically, but inside that block. Anyway, it looks more and more a side effect. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ocabot merge patch
This PR looks fantastic, let's merge it! |
Congratulations, your PR was merged at b9fd7f3. Thanks a lot for contributing to OCA. ❤️ |
Remove overflow:visible to tables to avoid side effects
Without
web_responsive
With
web_responsive
- beforeWith
web_responsive
- afterPlease @CarlosRoca13 can you review it?
@Tecnativa TT50468