-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][MIG] web_tree_dynamic_colored_field #2771
[17.0][MIG] web_tree_dynamic_colored_field #2771
Conversation
support color_field attribute update manifest higher version number bump typo
demo view
The options in <field> attributes are parsed as python expressions: https://github.com/odoo/odoo/blob/d18976d7489f6cd1c904f72557104807233a178d/addons/web/static/src/js/services/data_manager.js#L273 And the options in <button> are parsed as json... https://github.com/odoo/odoo/blob/d18976d7489f6cd1c904f72557104807233a178d/addons/web/static/src/js/services/data_manager.js#L411 This code only support the <field> element because I'm not sure there is a use for the <button> element.
…'color_field' The index at 0 in the following code: var colorField = this.arch.attrs.colors.split(';') .filter(color => color.trim().startsWith('color_field'))[0] Was failing on such valid xml: <tree string="Buffer monitor" colors="red:procure_recommended_qty > 0">
Use more than one color condition
Found in this commit: OCA@3965057
Use 'options' instead of 'colors' on tree views The colors attribute has been removed from the RelaxNG schema in Odoo [0], so use the 'options' instead. Closes OCA#1479 [0] odoo/odoo@7024f8d#diff-e9acd2f731cc01f302055b6e232df983
The 'colors' and 'options' fields are not supported by the RelaxNG schema of the <tree> element. Remove the support until we find a good solution for this.
[UPD] README.rst Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: web-13.0/web-13.0-web_tree_dynamic_colored_field Translate-URL: https://translation.odoo-community.org/projects/web-13-0/web-13-0-web_tree_dynamic_colored_field/
[UPD] README.rst
[UPD] README.rst Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: web-15.0/web-15.0-web_tree_dynamic_colored_field Translate-URL: https://translation.odoo-community.org/projects/web-15-0/web-15-0-web_tree_dynamic_colored_field/ Added translation using Weblate (French)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have checked locally but I can't seem to make it work. I did, as an example, something like this using another view from an OCA module:
<field name="code" options="{'bg_color': 'red:delivery_type != \'fixed\''}"/>
I used it the same way on the previous version (v15) and it works.
Do you have an example where it works? Am I doing something wrong with the notation?
Thanks in advance!
f907634
to
7b94edd
Compare
My bad, didn't test for the last time -- was a typo/gotcha (now fixed). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small comment. Other than that LGTM! Code and functional review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional review LGTM 👍🏿
Just one small thing, could you update the PR title to match the module name?
This PR has the |
@dz0, also please squash the last 2 commits. A migration can only have the pre-commit commit and the migration commit. And change the title of the PR to the name of the module: |
- Implementation now is based on updating `style` attribute of `cell/td` instead of manipulating element's `css` value in js. - Cleanup docs about no more functioning `colors` parameter for `tree` (since 13.0)
6a631d7
to
906bb81
Compare
done
done :) |
Perfect, thank you for the changes! I guess this is ready to merge, @etobella? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and worked properly
/ocabot migration web_tree_dynamic_colored_field
/ocabot merge nobump |
This PR looks fantastic, let's merge it! |
Congratulations, your PR was merged at bc43787. Thanks a lot for contributing to OCA. ❤️ |
Hi @dz0! can you backport to v16.0¿? |
Not sure if will find time soon. Maybe you can try same code in v16 (just change version in manifest)? |
No description provided.