Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fixture for inconsistent id #87

Merged
merged 1 commit into from
Apr 26, 2021
Merged

Add fixture for inconsistent id #87

merged 1 commit into from
Apr 26, 2021

Conversation

pwinckles
Copy link
Contributor

Fixture for inconsistent object id across inventories

@zimeon
Copy link
Collaborator

zimeon commented Apr 20, 2021

The id in v1 does not match the id in the root/v2 inventory, clearly an error.

@zimeon zimeon mentioned this pull request Apr 20, 2021
Closed
@zimeon zimeon requested a review from awoods April 20, 2021 16:12
@awoods
Copy link
Member

awoods commented Apr 25, 2021

Should we add text around https://ocfl.io/draft/spec/#E037 along the lines of:

This must be set in the first version of the object, must be unique in the local context, and must not change between versions of the same object.

@zimeon zimeon mentioned this pull request Apr 26, 2021
Closed
@zimeon
Copy link
Collaborator

zimeon commented Apr 26, 2021

Bumping comment to OCFL/spec#542 and merging.

@zimeon zimeon merged commit 9a9d868 into OCFL:main Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimeon zimeon zimeon approved these changes

@awoods awoods awoods approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pwinckles @zimeon @awoods