Skip to content

Odmtools #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 36 commits into from
May 5, 2017
Merged

Odmtools #76

merged 36 commits into from
May 5, 2017

Conversation

sreeder
Copy link
Contributor

@sreeder sreeder commented Apr 18, 2017

These changes add functionality to the read services and create the basic, create, update and delete functions needed. it also cleans up and improves some of the connection stuff

@emiliom
Copy link
Member

emiliom commented Apr 26, 2017

@sreeder, this is a lot of changes in one PR! I haven't had time to review them, and won't be able to this week. If you're in a hurry go ahead and merge. Otherwise I'll do at least a partial review early next week, then merge the PR.

@emiliom
Copy link
Member

emiliom commented May 2, 2017

@sreeder, I don't think there's any way I can catch up with trying to review so many changes! If you're actively using this new version of odm2api (via ODM tools, as it sounds like you are?), I assume you've tested it well and you're confident about what's in it. I suggest you go ahead and merge, but please make a brief list of the important changes. Seeing the labels for each commit alone can be confusing b/c one commit may tweak what a previous commit did.

Having a few more details than your PR text ("These changes add functionality to the read services and create the basic, create, update and delete functions needed. it also cleans up and improves some of the connection stuff") will be helpful, for future reference. eg, what can kind of functionality was added to read services, and what improvements were made to the connection stuff (briefly)?

Thanks!

cc @horsburgh

@sreeder sreeder merged commit 9808392 into master May 5, 2017
@sreeder sreeder deleted the odmtools branch May 5, 2017 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants