Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plot multiple glaciers in same plot #1508

Merged
merged 7 commits into from
Dec 14, 2022

Conversation

pat-schmitt
Copy link
Member

@pat-schmitt pat-schmitt commented Dec 6, 2022

In this PR I add the functionality to plot multiple glaciers in the same plot.

For this, a new grid is defined which contains all local gdir.grid completely. This new functionality can be used with the kwarg extend_plot_limit (e.g. plot_inversion(gdirs, extend_plot_limit=True)). If this is used there will be no topographic shading!

Closes #1007

(I have not added tests as it is only a plotting function)

  • Fully documented
  • Entry in whats-new.rst

Copy link
Member

@fmaussion fmaussion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Possibly we could add a test for this in this test:

def test_plot_region_model():

Also: add an entry to whats new!

@pat-schmitt
Copy link
Member Author

I added a test in test_plot_region_model(). How can the reference figure be changed?

@fmaussion
Copy link
Member

How can the reference figure be changed?

Open a PR here: https://github.com/OGGM/oggm-sample-data/tree/master/baseline_images/freetype_28

Once merged, change the commit hash here:

SAMPLE_DATA_COMMIT = 'dbd57434df8fade8d8df9206839b9bf26a1ef8e6'

@fmaussion
Copy link
Member

It's actuall best to download the reference images from the test suite fails: they send a link

@fmaussion fmaussion merged commit 26ce6af into OGGM:master Dec 14, 2022
@pat-schmitt pat-schmitt deleted the adapt_plotting_for_gdirs branch January 17, 2023 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

plot_centerlines map extent issue
2 participants