Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check oggm-sample-data github commit for updates #39

Merged
merged 1 commit into from
Mar 1, 2016

Conversation

TimoRoth
Copy link
Member

@TimoRoth TimoRoth commented Mar 1, 2016

I currently don't have a python2 environment to test with.
Works as expected on 3.4 for me.

It only checks for updates once every 30 minutes, to prevent it from doing a http request for each requested sample file.

This Fixes #37

@fmaussion
Copy link
Member

Thanks a lot! It seems to work well on py3, but py2 is making problems. Quite strangely, conda on appveyor is also failing... Any idea why?

@TimoRoth
Copy link
Member Author

TimoRoth commented Mar 1, 2016

It's running into an error 403, which most likely means it hit GitHubs API rate limiting.
That's probably an issue on those Travis/AppVeyor machines, as the limit is 60 requests per IP per hour.
I'll add an additional check, that causes a re-download on those errors, they should rarely be an issue on user-machines, and travis/appveyor have to download it anyway.

@fmaussion
Copy link
Member

This is perfect thanks a lot!

fmaussion added a commit that referenced this pull request Mar 1, 2016
Check oggm-sample-data github commit for updates
@fmaussion fmaussion merged commit 4e2fc23 into OGGM:master Mar 1, 2016
anoukvlug pushed a commit to anoukvlug/oggm that referenced this pull request Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants