Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to 'treatment' and 'prophylaxis' #98

Merged
merged 17 commits into from
Sep 19, 2017

Conversation

mark-jensen
Copy link
Contributor

Moved ’treatment' and 'prophylaxis' to be subclasses of 'planned process’. Also changed the definition of 'treatment' to reflect new superclass.

Jonathan Bona and others added 11 commits October 28, 2015 18:38
Moved ‘treatment’ and ‘prophylaxis’ to be subclasses of ‘planned
process’. Changed definition of ‘treatment’ to reflect new superclass.
This reverts commit 3439b02.
And modified definition, changing ‘measurement assay’ to ‘assay’.
Also slight alteration to definition for ‘laboratory test’.
@mark-jensen
Copy link
Contributor Author

Addresses several outstanding issues, most of which are addressed here.

This was partly done as an example of how proposed changes can be drafted in the OWL file directly by branching the master, modifying the ontology, and then requesting to have it pulled into the main branch when ready. A way for contributors to provide feedback without duplicating work.

@cmungall
Copy link

cmungall commented Sep 6, 2017

Protege + Github's diff make a real mess of tracking changes

https://github.com/ShahimEssaid/git-owl-tools

(local only)

Moving forward, this should be solved with latest versions of Protege. You could roundtrip master than the branch and the diff should look ok.

@mark-jensen mark-jensen merged commit e7ba0ee into OGMS:master Sep 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants