Changes in CMake files to avoid downloading bullet when it is not needed #3051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 thanks! |
paroj
added a commit
to paroj/ogre
that referenced
this pull request
Mar 3, 2024
…Cave#3051)" This reverts commit 254936e.
|
had to revert this again after taking a closer look. The issue is that Dependencies are handled before the options, as options depend on the dependencies having been built: Line 324 in 254936e this leaves OGRE_BUILD_DEPENDENCIES an all or nothing setting for now |
|
Didn´t realize that :/.
Hope it wasn't to much trouble!
El dom, 3 mar 2024 a las 22:32, Pavel Rojtberg ***@***.***>)
escribió:
… had to revert this again after taking a closer look. The issue is that
Dependencies are handled before the options, as options depend on the
dependencies having been built:
https://github.com/OGRECave/ogre/blob/254936ebf20ba9f80386a620803b09734bac44c4/CMakeLists.txt#L324
this leaves OGRE_BUILD_DEPENDENCIES an all or nothing setting for now
—
Reply to this email directly, view it on GitHub
<#3051 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ATUO5J4K3JYELRY54FMBS33YWOJHTAVCNFSM6AAAAABECKAFCSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZVGMZTIMJTG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a check before downloading bullet making sure the user is interested in building the ogre bullet module since otherwise bullet would not really be considered strictly necessary unlike sdl for example.