Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Class inheritance opAttribute,- Super, Numeric, Integer, Date #64

Merged
merged 2 commits into from
Apr 13, 2023

Conversation

mvankessel-EMC
Copy link
Contributor

@mvankessel-EMC mvankessel-EMC commented Apr 13, 2023

Pull Request for issue: #63

opAttribute,- Numeric, Integer and Date now inherit from opAttributeSuper, which contains the show and as.list methods. methods::is() checks have been mildly altered, to accommodate this change.

Copy link
Collaborator

@mdlavallee92 mdlavallee92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice job! Thanks for the suggestion and changes @mvankessel-EMC. Post back on the #64 issue to confirm you are done and the unit tests are passing

@mvankessel-EMC mvankessel-EMC mentioned this pull request Apr 13, 2023
@mdlavallee92 mdlavallee92 merged commit 6c3fbc3 into OHDSI:develop Apr 13, 2023
@mdlavallee92 mdlavallee92 mentioned this pull request May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants