Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to resume execution #109

Open
alondhe opened this issue Mar 23, 2020 · 1 comment
Open

Add ability to resume execution #109

alondhe opened this issue Mar 23, 2020 · 1 comment
Assignees
@alondhe
Labels
enhancement New feature or request

Comments

@alondhe
Copy link
Collaborator

alondhe commented Mar 23, 2020

For executions in which a check throws an error, it would be nice if we could re-run the check and integrate it into the results JSON file.

So, in executeDqChecks(), perhaps we add an optional field of resultsJsonFile, and with the checkNames parameter, can basically re-run the checks identified, and then we produce a new results JSON file that substitutes in the new results back into the original results JSON file.
@alondhe alondhe added the enhancement New feature or request label Mar 23, 2020
@alondhe alondhe self-assigned this Mar 23, 2020
@clairblacketer
Copy link
Collaborator

+1 to this, we have some executions halted due to clusters being restarted and we lose all progress

@ganisimov ganisimov mentioned this issue Aug 26, 2022
Closed
@ganisimov ganisimov mentioned this issue Oct 19, 2022
Closed
ganisimov pushed a commit to ganisimov/DataQualityDashboard that referenced this issue Dec 19, 2022
Add ability to resume execution of DQD checks
a274579 
It happens that due to connection issues or other conditions executeDqChecks fails and progress is lost.

When new resume argument is set to TRUE, file in outputFile path is used as source of check results instead of actual processing. Missing check results or results reporting error are re-processed.

Note that outputFile must be set explicitely to make resuming to take effect. New results overwrite file in outputFile path.

Addresses OHDSI#109
@ganisimov ganisimov mentioned this issue Dec 19, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alondhe alondhe

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alondhe @clairblacketer