Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Covariate balance plot for CohortMethod diagonal is not diagonal #315

Closed
schuemie opened this issue Aug 8, 2024 · 1 comment
Closed

Covariate balance plot for CohortMethod diagonal is not diagonal #315

schuemie opened this issue Aug 8, 2024 · 1 comment
Assignees
@nhall6
Labels
bug Something isn't working

Comments

@schuemie
Copy link
Member

schuemie commented Aug 8, 2024

In the balance plot there's a dashed line that should be the diagonal, but it is not really diagonal. For example:
image
here the line does not go through (0.05, 0.05) or (0.10, 0.10)
@nhall6 nhall6 self-assigned this Aug 8, 2024
@nhall6 nhall6 added the bug Something isn't working label Aug 8, 2024
nhall6 added a commit that referenced this issue Aug 9, 2024
@nhall6
Fixing issue #315 , diagonal line along x = y
9d782f5
@nhall6
Copy link
Collaborator

nhall6 commented Aug 9, 2024

I have fixed this here and submitted a PR @schuemie: https://github.com/OHDSI/OhdsiShinyModules/pull/316/files

@nhall6 nhall6 closed this as completed Aug 9, 2024
jreps added a commit that referenced this issue Aug 16, 2024
@jreps
Merge pull request #316 from OHDSI/prerelease-issue#315
e3a70ff 
Fixing issue #315 , diagonal line along x = y
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nhall6 nhall6

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@schuemie @nhall6