Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes to bigquery support to get achilles heel script working #71

Merged
merged 130 commits into from
Jun 1, 2017
Merged

Changes to bigquery support to get achilles heel script working #71

merged 130 commits into from
Jun 1, 2017

Conversation

myounglai
Copy link
Contributor

No description provided.

hajarhomayouni and others added 30 commits June 7, 2016 19:23
@hajarhomayouni
try testing sqlRender
332c075
add some translations for googlebigquery in replacementPatterns.csv
37acf28
update replacementPatterns.csv
14b1a3c
add mysql to csv
d16296d
add mysql to csv
18509bf
edit csv file for mysql
d1967bd
update queries with temp tables for mysql
51d16a9
no table definition is required in creating temp tables in mysql
5781cf6
update csv file for mysql
f5cd1e3
csv mysql
79aaa83
csv mysql
4520d18
try to resolve an error in mysql
2136304
change order for mysql translations
f85fcbd
translate row_number in mysql
18cc784
row number translation update
78ebf02
csv update
39211cf
update csv
715808f
csv update
fa61820
update and add some general rules for mysql
03ab450
translate simple insert into gbq
bf78b72
insert translation to gbq
aa1012d
insert trans for GBQ
3e007a9
drop table trans into GBQ
4a21ef8
drop trans into GBQ
31c39a5
update drop trans onto GBQ
5fa899c
create table trans into gbq
e107ba3
update
dc7591c
update create translation to gbq
99351b5
insert trans into gbq
ed13e92
insert with different number of columns for gbq
7cb5084
@myounglai
Change to using GROUP BY matching against the select list rather than…
04938f9 
… GROUP BY flattening. Add a few more rewrite rules needed for achilles queries.
@myounglai
Revert extraneous diffs in preparation for creating pull request.
c5f474b
@myounglai
Revert more diffs.
c2c76f5
@myounglai
More reverts.
174a38d
@myounglai
Start adding unit tests for bigquery.
8368715
@myounglai
Remove concat rewrite rules that are no longer needed.
8234c0a
@myounglai
Add lowercasing for bigquery.
58f880d
@myounglai
More unit tests.
ed52893
@myounglai
Add some comments.
28304aa
@myounglai
Fix bug in parse_date rewrite introduced by cleanup.
aa14f87
@myounglai
Merge branch 'master' of https://github.com/OHDSI/SqlRender
dffa378
@myounglai
Rewrite string concatenations to use CONCAT.
941eb1a
@myounglai
More tests and skip group by replacement for simple expressions.
9acb8ad
@myounglai
Simplify GROUP BY rewrites.
9810982
@myounglai
More changes needed to run heel script.
78231ff
@myounglai
Revert test change.
a1dba71
@myounglai
Update jar.
a66bc46
@myounglai
Add lowercasing of everything but string literals.
d10bea1
@myounglai
Exclude row_number from group by translation.
7b60659
@codecov-io
Copy link

codecov-io commented May 31, 2017 •
edited
Loading

Codecov Report

Merging #71 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #71   +/-   ##
=======================================
  Coverage   86.02%   86.02%           
=======================================
  Files           2        2           
  Lines         186      186           
=======================================
  Hits          160      160           
  Misses         26       26

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a45f00...96d2fb5. Read the comment docs.

@schuemie schuemie merged commit 98e6ca0 into OHDSI:master Jun 1, 2017
@t-abdul-basser t-abdul-basser mentioned this pull request Aug 8, 2017
Closed
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schuemie schuemie schuemie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@myounglai @codecov-io @schuemie @hajarhomayouni