Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TMP directory for Apache poi can be read-only (Issue 293) #372

Merged
merged 9 commits into from
May 10, 2023

Conversation

janblom
Copy link
Collaborator

@janblom janblom commented Mar 27, 2023

The proposed solution is to only use an alternative strategy for the tmp dir for Apache poi if the readonly situation situation. If not, proceed as before. A property org.ohdsi.whiterabbit.poi.tmpdircan be optionally used to control the location where the tmp dir is created.

Solves issue 293

@janblom janblom self-assigned this Mar 27, 2023
@blootsvoets
Copy link
Collaborator

Looks fine to me. Just to clarify, the only way to be sure that you can write to a directory is to actually write a file to it. Unfortunately, Files.isWritable is not enough because it doesn't test all additional directory annotations that may exist.
It would be good to add a README / Wiki line about this new property.

FYI, on windows, changing the TMP environment value also changes the base temp directory. On all systems, java -Djava.io.tmpdir=/path/to/tmpdir changes the base temp directory.

@janblom janblom merged commit c7073da into OHDSI:master May 10, 2023
@janblom janblom deleted the issue-293 branch October 26, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants