Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention LibNSS dependency for JA3 #3817

Closed
wants to merge 1 commit into from
Closed

Mention LibNSS dependency for JA3 #3817

wants to merge 1 commit into from

Conversation

DominoTree
Copy link
Contributor

Update util-ja3.c

Update app-layer-ssl.c

Make sure these boxes are signed before submitting your Pull Request -- thank you.

Link to redmine ticket:

Describe changes:

  • Mention that required MD5 support is provided by LibNSS for JA3 (had to look at the code to figure out what additional library I needed)

PRScript output (if applicable):

@DominoTree DominoTree requested review from norg and a team as code owners April 25, 2019 17:23
Update util-ja3.c

Update app-layer-ssl.c
@DominoTree
Copy link
Contributor Author

Argh, tried to pull in upstream changes to avoid a merge conflict and I still ended up with one...

@victorjulien victorjulien mentioned this pull request Aug 26, 2019
@victorjulien
Copy link
Member

Merged in #4123, thanks Nick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants